fix(ci): drop the RBE-fragile binary-size make gate from addon_build_gates (#3425) #3509
No reviewers
Labels
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
carverauto/serviceradar!3509
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/addon-build-gates-drop-fragile-binary-size"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What
The native add-on publish keeps failing in
make addon_build_gates:check_addon_binary_size_bazeldoesbazel build //build/native_addons:all_binariesthen a separatebazel cquery --output=files | stat. Under RBE (--remote_download_minimal) the cross-config (ST-hash) outputs aren't reliably materialized at the cquery paths locally →statfails.--remote_download_outputs=all(#3506) didn't fix it (build/cquery config skew).It's redundant:
//build/native_addons:build_gates_test(the workflow's "Run hermetic native add-on gate fixtures" step) already includesbinary_size_test, which is RBE-correct (binaries delivered as test runfiles;REQUIRE_GSA=0after #3506).Fix
Drop
check_addon_binary_size_bazelfromaddon_build_gates's prerequisites — binary-size stays covered by the Bazel test. The make target remains for local use. Aligns withadd-hermetic-native-addon-builds(moving gates to Bazel tests).🤖 Generated with Claude Code
The native add-on publish keeps failing in `make addon_build_gates`: error: artifact not found: bazel-out/.../{netprobe,bumblebee_scan,sample}_addon_bundle_* binary-size regression gate FAILED (Makefile:259 check_addon_binary_size_bazel, exit 2) `check_addon_binary_size_bazel` does `bazel build //build/native_addons:all_binaries` then a SEPARATE `bazel cquery --output=files | stat`. Under RBE (`--remote_download_minimal`) the cross-config (ST-hash) outputs aren't reliably materialized at the cquery paths locally, so the stat fails. Adding `--remote_download_outputs=all` (#3506) did not fix it — the build/cquery config skew remains. It's also redundant: `//build/native_addons:build_gates_test` (run by the workflow's "Run hermetic native add-on gate fixtures" step) already includes `binary_size_test`, which is RBE-correct because it receives the binaries as test runfiles (and is REQUIRE_GSA=0 after #3506). So drop `check_addon_binary_size_bazel` from `addon_build_gates`'s prerequisites; the binary-size gate stays covered by the Bazel test. (The make target is kept for local use.) This aligns with add-hermetic-native-addon-builds (moving gates to Bazel tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>lgtm