fix(ci): make the native add-on binary-size gate RBE-compatible (#3425) #3506

Merged

mfreeman451 merged 1 commit from fix/addon-binary-size-rbe-compat into staging

2026-06-01 18:16:28 +00:00

mfreeman451 commented

2026-06-01 18:09:09 +00:00

Owner

What

The netprobe publish (and the staging tests(//...) lane) fail in the binary-size gate for two RBE-specific reasons — neither is a real size regression (the baseline is currently empty {}):

1. Make target didn't download the built binaries.
make check_addon_binary_size_bazel runs bazel build //build/native_addons:all_binaries under the CI's --remote_download_minimal (.bazelrc remote_base), so the cross-compiled bundle binaries are built remotely but not downloaded locally. The next cquery --output=files | check-addon-binary-size.sh then fails:

error: artifact not found: bazel-out/.../{netprobe,bumblebee_scan,sample}_addon_bundle_linux_{amd64,arm64}
binary-size regression gate FAILED

→ add --remote_download_outputs=all to that build.

2. binary_size_test sh_test fails closed on missing gsa on RBE.
The test set REQUIRE_GSA=1 but runs on RBE workers where go-size-analyzer isn't installed (it's go installed only on the workflow runner), so it exits 2 ("failing closed because the tool is missing") — the //build/native_addons:binary_size_test FAILED in the main CI. gsa isn't a hermetic Bazel tool yet, so drop to REQUIRE_GSA=0: the baseline size-regression check still runs, and the runner-side make addon_build_gates still produces the gsa breakdown.

Follow-up

add-hermetic-native-addon-builds (task 1.1) will pin gsa as a Bazel tool target and restore REQUIRE_GSA=1; this is the minimal RBE-compat unblock so a netprobe publish can complete.

🤖 Generated with Claude Code

## What The netprobe publish (and the staging `tests(//...)` lane) fail in the binary-size gate for **two RBE-specific reasons** — neither is a real size regression (the baseline is currently empty `{}`): **1. Make target didn't download the built binaries.** `make check_addon_binary_size_bazel` runs `bazel build //build/native_addons:all_binaries` under the CI's `--remote_download_minimal` (`.bazelrc` `remote_base`), so the cross-compiled bundle binaries are built **remotely but not downloaded** locally. The next `cquery --output=files | check-addon-binary-size.sh` then fails: ``` error: artifact not found: bazel-out/.../{netprobe,bumblebee_scan,sample}_addon_bundle_linux_{amd64,arm64} binary-size regression gate FAILED ``` → add `--remote_download_outputs=all` to that build. **2. `binary_size_test` sh_test fails closed on missing `gsa` on RBE.** The test set `REQUIRE_GSA=1` but runs on RBE workers where go-size-analyzer isn't installed (it's `go install`ed only on the workflow runner), so it exits 2 ("failing closed because the tool is missing") — the `//build/native_addons:binary_size_test FAILED` in the main CI. `gsa` isn't a hermetic Bazel tool yet, so drop to `REQUIRE_GSA=0`: the baseline size-regression check still runs, and the runner-side `make addon_build_gates` still produces the gsa breakdown. ## Follow-up `add-hermetic-native-addon-builds` (task 1.1) will pin `gsa` as a Bazel tool target and restore `REQUIRE_GSA=1`; this is the minimal RBE-compat unblock so a netprobe publish can complete. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns