fix(ci): regenerate stale Go BUILD files via gazelle — unbreak bazel (#3425) #3492

Merged

mfreeman451 merged 1 commit from fix/agent-bazel-go-library-srcs into staging

2026-06-01 13:06:27 +00:00

mfreeman451 commented

2026-06-01 05:26:20 +00:00

Owner

What

The bazel lane is red on staging: //go/pkg/agent:agent (+ :agent_test, selected by CI's tests(//...)) fails to build, with cascading staleness:

push_loop.go: undefined: icmpCheckConfig                       (agent: split file not in srcs)
push_loop_config.go: undefined: bumblebee.WriteRuntimeProfile  (bumblebee: stale srcs)
sshca-signer: lib missing @org_golang_x_crypto//ssh dep

Recent refactors added/moved Go files (and a new cross-package symbol) without updating the checked-in BUILD.bazel srcs/deps. CI runs bazel test with no gazelle step, so stale checked-in BUILDs break the lane — go test ./... passed (go.mod) while bazel did not.

Fix — scoped, not blanket

A blanket gazelle //... is unsafe: it clobbers hand-tuned deps (e.g. db-event-writer's otlp pin → "multiple copies of package" linker error) and emits duplicate targets. Scoped to the genuinely-broken packages:

gazelle the agent subtree + bumblebee — adds missing srcs/deps (incl. #3490's push_loop_addon_status_test.go).
sshca-signer — add the missing @org_golang_x_crypto//ssh lib dep by hand; dropped a bogus duplicate test target gazelle emitted (:sshca-signer_lib doesn't exist).
# gazelle:exclude .claude in the root BUILD so gazelle ignores the gitignored agent worktrees under .claude/ (ambiguous duplicate targets locally; CI never sees .claude/).

10 BUILD files; no source changes. Hand-tuned packages left untouched.

Validation

bazel build //go/... --keep_going — completes successfully (was failing).
db-event-writer_test + other hand-tuned packages confirmed still green.

Follow-up

Dir-scoped gazelle PostToolUse hook (local) now runs on Go-file writes; the deeper systemic staleness fits the proposed add-hermetic-native-addon-builds work + a CI gazelle -mode=diff gate.

🤖 Generated with Claude Code

## What The bazel lane is **red** on `staging`: `//go/pkg/agent:agent` (+ `:agent_test`, selected by CI's `tests(//...)`) fails to build, with cascading staleness: ``` push_loop.go: undefined: icmpCheckConfig (agent: split file not in srcs) push_loop_config.go: undefined: bumblebee.WriteRuntimeProfile (bumblebee: stale srcs) sshca-signer: lib missing @org_golang_x_crypto//ssh dep ``` Recent refactors added/moved Go files (and a new cross-package symbol) **without updating the checked-in `BUILD.bazel` srcs/deps**. CI runs `bazel test` with **no gazelle step**, so stale checked-in BUILDs break the lane — `go test ./...` passed (go.mod) while bazel did not. ## Fix — scoped, not blanket A blanket `gazelle //...` is **unsafe**: it clobbers hand-tuned deps (e.g. `db-event-writer`'s otlp pin → "multiple copies of package" linker error) and emits duplicate targets. Scoped to the **genuinely-broken** packages: - **gazelle the `agent` subtree + `bumblebee`** — adds missing srcs/deps (incl. #3490's `push_loop_addon_status_test.go`). - **`sshca-signer`** — add the missing `@org_golang_x_crypto//ssh` lib dep by hand; dropped a bogus duplicate test target gazelle emitted (`:sshca-signer_lib` doesn't exist). - **`# gazelle:exclude .claude`** in the root BUILD so gazelle ignores the gitignored agent worktrees under `.claude/` (ambiguous duplicate targets locally; CI never sees `.claude/`). 10 BUILD files; no source changes. Hand-tuned packages left untouched. ## Validation - `bazel build //go/... --keep_going` — **completes successfully** (was failing). - `db-event-writer_test` + other hand-tuned packages confirmed still green. ## Follow-up Dir-scoped gazelle `PostToolUse` hook (local) now runs on Go-file writes; the deeper systemic staleness fits the proposed `add-hermetic-native-addon-builds` work + a CI `gazelle -mode=diff` gate. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns