feat(agent): surface netprobe as addon:netprobe in capability status (#3425) #3490

Merged

mfreeman451 merged 1 commit from feat/netprobe-addon-status into staging

2026-06-01 05:29:52 +00:00

mfreeman451 commented

2026-06-01 05:12:28 +00:00

Owner

What

migrate-netprobe-to-native-addon §2.3 (partial). netprobe is supervised as a systemd-service, not via the go-plugin addon manager, so it reported under the bare "netprobe" sidecar name — which the core AddonStatusIngestor (ingests only addon:<id> entries) skips. Result: netprobe never appeared in the AddonStatus read model, so Edge Ops drift couldn't show it.

buildAgentCapabilityGatewayStatus now synthesizes an addon:netprobe capability entry when netprobe is installed as a systemd add-on (installedSystemdAddons non-empty):
- state folded in from the live netprobe sidecar entry (else stopped = installed-not-running),
- version from the activation current symlink (versions/<version>),
- arch from runtime.GOARCH (the agent runs the arch-matching artifact).
- Reuses agentaddon.ToProtoStatuses for the addon: prefix + version/arch mapping (built on #3489).
A running-but-incapable netprobe surfaces via state + last_error.

Why partial / capture status

Explicit capture-active reporting (the "+ capture status" in §2.3) needs a netprobe IPC signal — none exists today (Ping/PingAck only; StartRemoteCapture is a Phase-5 TODO). That's a focused follow-up (netprobe-side signal + proto + agent). This PR delivers the read-model integration + state/version/arch, which is what the Edge Ops drift card (Agent C) needs to render netprobe.

Validation

go build ./go/pkg/agent/... + go vet — clean
go test ./go/pkg/agent/ — new tests (not-installed→nil; installed+running→active w/ version+arch+pid; installed+no-sidecar→stopped) + the existing capability test green.
Note: the agent bazel lib is pre-existing-broken on staging — push_loop_state.go is missing from the go_library srcs (identical failure without this PR's changes). Fixed in a separate fix(ci) PR; this PR adds no go_library files and no new deps.

🤖 Generated with Claude Code

## What `migrate-netprobe-to-native-addon` **§2.3** (partial). netprobe is supervised as a `systemd-service`, **not** via the go-plugin addon manager, so it reported under the bare `"netprobe"` sidecar name — which the core `AddonStatusIngestor` (ingests only `addon:<id>` entries) skips. Result: netprobe never appeared in the `AddonStatus` read model, so Edge Ops drift couldn't show it. - `buildAgentCapabilityGatewayStatus` now synthesizes an **`addon:netprobe`** capability entry when netprobe is installed as a systemd add-on (`installedSystemdAddons` non-empty): - **state** folded in from the live `netprobe` sidecar entry (else `stopped` = installed-not-running), - **version** from the activation `current` symlink (`versions/<version>`), - **arch** from `runtime.GOARCH` (the agent runs the arch-matching artifact). - Reuses `agentaddon.ToProtoStatuses` for the `addon:` prefix + version/arch mapping (built on #3489). - A running-but-incapable netprobe surfaces via `state` + `last_error`. ## Why partial / capture status Explicit **capture-active** reporting (the "+ capture status" in §2.3) needs a netprobe **IPC signal** — none exists today (`Ping`/`PingAck` only; `StartRemoteCapture` is a Phase-5 TODO). That's a focused follow-up (netprobe-side signal + proto + agent). This PR delivers the read-model integration + state/version/arch, which is what the Edge Ops drift card (Agent C) needs to render netprobe. ## Validation - `go build ./go/pkg/agent/...` + `go vet` — clean - `go test ./go/pkg/agent/` — new tests (not-installed→nil; installed+running→active w/ version+arch+pid; installed+no-sidecar→stopped) + the existing capability test green. - **Note:** the agent `bazel` lib is **pre-existing-broken on `staging`** — `push_loop_state.go` is missing from the `go_library` srcs (identical failure without this PR's changes). Fixed in a separate `fix(ci)` PR; this PR adds no `go_library` files and no new deps. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns