carverauto/serviceradar

test(core): DB-backed end-to-end test for the native add-on importer (#3425) #3477

Merged

mfreeman451 merged 2 commits from feat/native-addon-importer-db-test into staging

2026-05-31 23:35:58 +00:00

mfreeman451 commented

2026-05-31 22:10:39 +00:00

Owner

What

DB-backed end-to-end coverage of ServiceRadar.Plugins.NativeAddonImporter.import_entry/4 (build-signing §4) — the AddonPackage persist path the merged pure-unit suite (#3476) could only inject around.

The test verifies the per-arch ed25519 signatures, mirrors (faked), and creates a real staged AddonPackage, asserting:

the persisted artifacts map keyed "os/arch" => {object_key, sha256, signature} (exactly what AgentConfigGenerator.select_addon_artifact/3 reads);
the kind/delivery/supervision atoms + binary + source_release_tag;
it re-reads back out of Postgres (Ash.get);
a bad per-arch signature fails closed and persists nothing (:by_addon_id → []).

@moduletag :integration.

Verified

Ran against an srql-fixtures scratch CNPG database (per the srql-fixtures-db-tests skill): created a scratch DB, applied the branch migrations, then mix test --include integration → 2 tests, 0 failures. Scratch DB dropped afterward; no secrets printed.

🤖 Generated with Claude Code

## What DB-backed end-to-end coverage of `ServiceRadar.Plugins.NativeAddonImporter.import_entry/4` (build-signing §4) — the `AddonPackage` persist path the merged pure-unit suite (#3476) could only inject around. The test verifies the per-arch ed25519 signatures, mirrors (faked), and creates a **real staged `AddonPackage`**, asserting: - the persisted `artifacts` map keyed `"os/arch" => {object_key, sha256, signature}` (exactly what `AgentConfigGenerator.select_addon_artifact/3` reads); - the `kind`/`delivery`/`supervision` atoms + `binary` + `source_release_tag`; - it re-reads back out of Postgres (`Ash.get`); - a **bad per-arch signature fails closed and persists nothing** (`:by_addon_id` → `[]`). `@moduletag :integration`. ## Verified Ran against an **srql-fixtures scratch CNPG database** (per the `srql-fixtures-db-tests` skill): created a scratch DB, applied the branch migrations, then `mix test --include integration` → **2 tests, 0 failures**. Scratch DB dropped afterward; no secrets printed. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

mfreeman451 added 1 commit

2026-05-31 22:10:39 +00:00

test(core): DB-backed end-to-end test for the native add-on importer (#3425 )

Secret Scan / gitleaks (pull_request) Successful in 53s

Details

Golang Tests / test-go (push) Successful in 1m18s

Details

lint / lint (pull_request) Successful in 1m53s

Details

lint / lint (push) Successful in 2m24s

Details

Elixir Quality / Elixir Quality (pull_request) Failing after 13m49s

Details

CI / build (pull_request) Failing after 14m48s

Details

599e7bc761

Covers the AddonPackage persist path the pure unit suite injects around
(build-signing §4). `NativeAddonImporter.import_entry/4` verifies the per-arch
ed25519 signatures, mirrors (faked), and creates a real staged AddonPackage; the
test asserts the persisted `artifacts` map (keyed "os/arch" -> object_key/sha256/
signature, the shape AgentConfigGenerator reads), the kind/delivery/supervision
atoms, the source release tag, and that it re-reads back out of Postgres — plus
that a bad per-arch signature fails closed and persists nothing
(`:by_addon_id` returns []).

`@moduletag :integration`. Verified against an srql-fixtures scratch CNPG
database (per the srql-fixtures-db-tests skill): branch migrations applied, then
`mix test --include integration` = 2 tests, 0 failures; scratch DB dropped after.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

mfreeman451 reviewed

2026-05-31 23:23:23 +00:00

mfreeman451 left a comment

lgtm

lgtm

mfreeman451 added 1 commit

2026-05-31 23:24:22 +00:00

style(core): mix format the native add-on importer DB test (#3425 )

lint / lint (push) Successful in 1m21s

Details

Secret Scan / gitleaks (pull_request) Successful in 59s

Details

lint / lint (pull_request) Successful in 2m28s

Details

Golang Tests / test-go (push) Successful in 2m37s

Details

CI / build (pull_request) Failing after 15m47s

Details

Elixir Quality / Elixir Quality (pull_request) Failing after 22m33s

Details

e6ee99f620

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

mfreeman451 merged commit 80fdf88b1a into staging

2026-05-31 23:35:58 +00:00

mfreeman451 referenced this pull request from a commit

2026-05-31 23:36:00 +00:00

Merge pull request 'test(core): DB-backed end-to-end test for the native add-on importer (#3425)' (#3477) from feat/native-addon-importer-db-test into staging

mfreeman451 referenced this pull request

2026-05-31 23:42:51 +00:00

feat(core): native add-on object-storage mirror (build-signing §4.2) (#3425) #3478

mfreeman451 referenced this pull request

2026-06-01 00:18:09 +00:00

feat(web-ng): native add-on import orchestration on a shared OCI client (#3425) #3479

mfreeman451 referenced this pull request

2026-06-01 04:33:29 +00:00

Tracker: host-network-visibility + native add-on framework OpenSpec proposals #3456

Sign in to join this conversation.

No reviewers

No labels

Failed compliance check

Possible security concern

Review effort 1/5

Review effort 2/5

Review effort 3/5

Review effort 4/5

Review effort 5/5

device-management

good first issue

serviceradar-agent

serviceradar-agent-gateway

serviceradar-web

serviceradar-web-ng

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

carverauto/serviceradar!3477

No description provided.