feat(core): native add-on importer verify-then-persist core (#3425) #3476

Merged

mfreeman451 merged 1 commit from feat/native-addon-importer into staging

2026-05-31 22:03:12 +00:00

mfreeman451 commented

2026-05-31 22:01:10 +00:00

Owner

What

The verify-then-persist core of the native add-on control-plane importer (build-signing §4.1/4.2). ServiceRadar.Plugins.NativeAddonImporter (serviceradar_core) turns a verified serviceradar-native-addon-index.json entry + the add-on's addon.yaml manifest into a staged AddonPackage whose per-arch artifacts map is exactly what AgentConfigGenerator.select_addon_artifact/3 already reads ("os/arch" => {object_key, sha256, signature}).

Per architecture it:

checks the tarball sha256,
verifies the raw ed25519 signature over the tarball bytes against the agent release public key — the agent's exact verifyAddonArtifactSignature check, with the same hex/base64 decode parity, so a tarball the control plane accepts is one the agent will accept,
mirrors via an injected :mirror function,

then maps the manifest → AddonPackage create attrs (kind/delivery/supervision → atoms, fail-closed on unknown enums; binary/install_path/capabilities/requires; source oci ref/digest/release tag) and creates a staged package via an injected actor (a SystemActor for background callers — never authorize?: false, per serviceradar_core/CLAUDE.md).

Why injected deps

The OCI fetch, Cosign verify, and object-storage upload are injected so the verification + persistence logic is unit-testable without a registry or DB — mirroring the ReleaseArtifactMirror DI pattern.

Tests

test/serviceradar/plugins/native_addon_importer_test.exs (no DB): valid-sig (hex + base64) / tampered / wrong-key / malformed-sig; sha256 match/mismatch; decode encodings; per-arch verify+mirror map and fail-closed-never-mirror; attrs mapping + unknown-delivery rejection + install_path default. mix test green (11 tests); mix compile --warnings-as-errors + mix credo --strict clean.

Remaining (tasks.md §4, noted)

web-ng OCI-fetch orchestration: fetch the index from the trusted release, bounded-fetch the bundle, Cosign-verify the OCI digest (reuse CosignVerifier), parse the bundle's addon.yaml + config.schema.json, assemble the per-arch fetched artifacts, and call import_entry/4.
default object-storage mirror: ServiceRadar.Sync.Client.upload_object (object key native-addons/<addon_id>/<version>/<os>-<arch>/<sha256>-<file>), mirroring ReleaseArtifactMirror.
Then onboarding/Edge-Ops can seed + approve the imported AddonPackage.

🤖 Generated with Claude Code

## What The **verify-then-persist core** of the native add-on control-plane importer (build-signing §4.1/4.2). `ServiceRadar.Plugins.NativeAddonImporter` (serviceradar_core) turns a verified `serviceradar-native-addon-index.json` entry + the add-on's `addon.yaml` manifest into a **staged `AddonPackage`** whose per-arch `artifacts` map is exactly what `AgentConfigGenerator.select_addon_artifact/3` already reads (`"os/arch" => {object_key, sha256, signature}`). Per architecture it: 1. checks the tarball `sha256`, 2. **verifies the raw ed25519 signature over the tarball bytes against the agent release public key** — the agent's exact `verifyAddonArtifactSignature` check, with the same hex/base64 decode parity, so a tarball the control plane accepts is one the agent will accept, 3. mirrors via an injected `:mirror` function, then maps the manifest → `AddonPackage` create attrs (kind/delivery/supervision → atoms, **fail-closed** on unknown enums; binary/install_path/capabilities/requires; source oci ref/digest/release tag) and creates a **staged** package via an injected actor (a `SystemActor` for background callers — never `authorize?: false`, per `serviceradar_core/CLAUDE.md`). ## Why injected deps The OCI fetch, Cosign verify, and object-storage upload are **injected** so the verification + persistence logic is unit-testable without a registry or DB — mirroring the `ReleaseArtifactMirror` DI pattern. ## Tests `test/serviceradar/plugins/native_addon_importer_test.exs` (no DB): valid-sig (hex + base64) / tampered / wrong-key / malformed-sig; sha256 match/mismatch; decode encodings; per-arch verify+mirror map **and fail-closed-never-mirror**; attrs mapping + unknown-delivery rejection + install_path default. **`mix test` green (11 tests); `mix compile --warnings-as-errors` + `mix credo --strict` clean.** ## Remaining (tasks.md §4, noted) - **web-ng OCI-fetch orchestration**: fetch the index from the trusted release, bounded-fetch the bundle, Cosign-verify the OCI digest (reuse `CosignVerifier`), parse the bundle's `addon.yaml` + `config.schema.json`, assemble the per-arch fetched artifacts, and call `import_entry/4`. - **default object-storage mirror**: `ServiceRadar.Sync.Client.upload_object` (object key `native-addons/<addon_id>/<version>/<os>-<arch>/<sha256>-<file>`), mirroring `ReleaseArtifactMirror`. - Then onboarding/Edge-Ops can seed + approve the imported `AddonPackage`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns