2618 bug not capturing response time from sweep results #2815

Merged
mfreeman451 merged 14 commits from refs/pull/2815/head into staging 2026-01-31 02:03:28 +00:00
mfreeman451 commented 2026-01-30 21:45:41 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #2624
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624
Original created: 2026-01-30T21:45:41Z
Original updated: 2026-01-31T02:03:30Z
Original head: carverauto/serviceradar:2618-bug-not-capturing-response-time-from-sweep-results
Original base: staging
Original merged: 2026-01-31T02:03:28Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Code checklist before requesting a review

  • I have signed the DCO?
  • The build completes without errors?
  • All tests are passing when running make test?
Imported from GitHub pull request. Original GitHub pull request: #2624 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2624 Original created: 2026-01-30T21:45:41Z Original updated: 2026-01-31T02:03:30Z Original head: carverauto/serviceradar:2618-bug-not-capturing-response-time-from-sweep-results Original base: staging Original merged: 2026-01-31T02:03:28Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?
mfreeman451 commented 2026-01-30 21:46:51 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748083945
Original created: 2026-01-30T21:46:51Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 60

shouldnt be looking at agent gateway id anymore

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748083945 Original created: 2026-01-30T21:46:51Z Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex Original line: 60 --- shouldnt be looking at agent gateway id anymore
mfreeman451 commented 2026-01-30 21:46:59 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748084411
Original created: 2026-01-30T21:46:59Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 130

same thing here

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748084411 Original created: 2026-01-30T21:46:59Z Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex Original line: 130 --- same thing here
mfreeman451 commented 2026-01-30 21:47:06 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748084785
Original created: 2026-01-30T21:47:06Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 140

dont need gw id

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748084785 Original created: 2026-01-30T21:47:06Z Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex Original line: 140 --- dont need gw id
mfreeman451 commented 2026-01-30 21:47:15 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748085414
Original created: 2026-01-30T21:47:15Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 151

-gw id

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748085414 Original created: 2026-01-30T21:47:15Z Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex Original line: 151 --- -gw id
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!2815
No description provided.