carverauto/serviceradar

Fork 0

Feat/db event writer elx #2624

Merged

mfreeman451 merged 18 commits from refs/pull/2624/head into testing

2025-12-30 17:36:31 +00:00

mfreeman451 commented

2025-12-29 15:50:14 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2215
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215
Original created: 2025-12-29T15:50:14Z
Original updated: 2025-12-30T17:36:33Z
Original head: carverauto/serviceradar:feat/db_event_writer_elx
Original base: testing
Original merged: 2025-12-30T17:36:31Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2215 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215 Original created: 2025-12-29T15:50:14Z Original updated: 2025-12-30T17:36:33Z Original head: carverauto/serviceradar:feat/db_event_writer_elx Original base: testing Original merged: 2025-12-30T17:36:31Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2025-12-29 18:23:51 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651515024
Original created: 2025-12-29T18:23:51Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/logs.ex
Original line: 18

should be in ocsf schema

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651515024 Original created: 2025-12-29T18:23:51Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/logs.ex Original line: 18 --- should be in ocsf schema

mfreeman451 commented

2025-12-29 18:24:50 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651516397
Original created: 2025-12-29T18:24:50Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/otel_metrics.ex
Original line: 18

i believe this should be in ocsf metrics schema format as well

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651516397 Original created: 2025-12-29T18:24:50Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/otel_metrics.ex Original line: 18 --- i believe this should be in ocsf metrics schema format as well

mfreeman451 commented

2025-12-29 18:25:29 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651517252
Original created: 2025-12-29T18:25:29Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/otel_metrics.ex
Original line: 147

cant these be re-usable functions here seems like we are recreating these a bunch

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651517252 Original created: 2025-12-29T18:25:29Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/otel_metrics.ex Original line: 147 --- cant these be re-usable functions here seems like we are recreating these a bunch

mfreeman451 commented

2025-12-29 18:25:38 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651517519
Original created: 2025-12-29T18:25:38Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/otel_traces.ex
Original line: 18

should be in ocsf?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651517519 Original created: 2025-12-29T18:25:38Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/otel_traces.ex Original line: 18 --- should be in ocsf?

mfreeman451 commented

2025-12-29 18:26:08 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651518233
Original created: 2025-12-29T18:26:08Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/sweep.ex
Original line: 30

again, can we put this in an ocsf format?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651518233 Original created: 2025-12-29T18:26:08Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/sweep.ex Original line: 30 --- again, can we put this in an ocsf format?

mfreeman451 commented

2025-12-29 18:26:26 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651518722
Original created: 2025-12-29T18:26:26Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/telemetry.ex
Original line: 29

is this in ocsf? should it be?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2651518722 Original created: 2025-12-29T18:26:26Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/telemetry.ex Original line: 29 --- is this in ocsf? should it be?

mfreeman451 commented

2025-12-30 03:55:50 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2652162388
Original created: 2025-12-30T03:55:50Z
Original path: elixir/serviceradar_core/lib/serviceradar/jobs/refresh_trace_summaries_worker.ex
Original line: 17

shouldnt we be using an ash adapter here?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2215#discussion_r2652162388 Original created: 2025-12-30T03:55:50Z Original path: elixir/serviceradar_core/lib/serviceradar/jobs/refresh_trace_summaries_worker.ex Original line: 17 --- shouldnt we be using an ash adapter here?