carverauto/serviceradar

Fork 0

sync #2755

Open

mfreeman451 wants to merge 512 commits from refs/pull/2755/head into main

mfreeman451 commented

2026-01-24 09:05:19 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2493
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2493
Original created: 2026-01-24T09:05:19Z
Original updated: 2026-03-27T22:06:21Z
Original head: carverauto/serviceradar:staging
Original base: main

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2493 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2493 Original created: 2026-01-24T09:05:19Z Original updated: 2026-03-27T22:06:21Z Original head: carverauto/serviceradar:staging Original base: main --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

CLAassistant commented

2026-02-01 04:18:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @CLAassistant
Original URL: https://github.com/carverauto/serviceradar/pull/2493#issuecomment-3830343972
Original created: 2026-02-01T04:18:43Z

All committers have signed the CLA.

Imported GitHub PR comment. Original author: @CLAassistant Original URL: https://github.com/carverauto/serviceradar/pull/2493#issuecomment-3830343972 Original created: 2026-02-01T04:18:43Z --- [![CLA assistant check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/carverauto/serviceradar?pullRequest=2493) <br/>All committers have signed the CLA.

github-advanced-security[bot] commented

2026-02-27 21:31:15 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2866286342
Original created: 2026-02-27T21:31:15Z
Original path: elixir/web-ng/assets/js/lib/god_view/lifecycle_dom_setup_methods.js
Original line: 7

DOM text reinterpreted as HTML

DOM text is reinterpreted as HTML without escaping meta-characters.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2866286342 Original created: 2026-02-27T21:31:15Z Original path: elixir/web-ng/assets/js/lib/god_view/lifecycle_dom_setup_methods.js Original line: 7 --- ## DOM text reinterpreted as HTML [DOM text](1) is reinterpreted as HTML without escaping meta-characters. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/98)

Copilot commented

2026-03-25 23:13:47 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598833
Original created: 2026-03-25T23:13:47Z
Original path: build/bazel/README.md
Original line: 6

These markdown links point to an absolute local filesystem path (/home/mfreeman/...), which will be broken for all other developers and in GitHub rendering. Replace them with repo-relative links (e.g. /tools/bazel and /tools/bazel/README.md).

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598833 Original created: 2026-03-25T23:13:47Z Original path: build/bazel/README.md Original line: 6 --- These markdown links point to an absolute local filesystem path (`/home/mfreeman/...`), which will be broken for all other developers and in GitHub rendering. Replace them with repo-relative links (e.g. `/tools/bazel` and `/tools/bazel/README.md`).

Copilot commented

2026-03-25 23:13:47 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598877
Original created: 2026-03-25T23:13:47Z
Original path: build/packaging/agent/scripts/postinstall.sh
Original line: 58

This setcap call is duplicated: the script already sets cap_net_raw earlier with error handling, but this final call is unconditional and can cause the postinstall to fail if capabilities can't be set. Remove the duplicate or keep a single guarded setcap invocation.

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598877 Original created: 2026-03-25T23:13:47Z Original path: build/packaging/agent/scripts/postinstall.sh Original line: 58 --- This `setcap` call is duplicated: the script already sets `cap_net_raw` earlier with error handling, but this final call is unconditional and can cause the postinstall to fail if capabilities can't be set. Remove the duplicate or keep a single guarded `setcap` invocation. ```suggestion ```

Copilot commented

2026-03-25 23:13:48 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598925
Original created: 2026-03-25T23:13:48Z
Original path: BUILD.md
Original line: 6

This doc claims .bazelversion pins Bazel to 9.0.0, but the PR updates .bazelversion to 9.0.1. Update the documentation (or reference .bazelversion without hardcoding the value) to avoid misleading setup instructions.

* The repository currently pins Bazel via `.bazelversion`; see that file for the exact version.

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598925 Original created: 2026-03-25T23:13:48Z Original path: BUILD.md Original line: 6 --- This doc claims `.bazelversion` pins Bazel to `9.0.0`, but the PR updates `.bazelversion` to `9.0.1`. Update the documentation (or reference `.bazelversion` without hardcoding the value) to avoid misleading setup instructions. ```suggestion * The repository currently pins Bazel via `.bazelversion`; see that file for the exact version. ```

Copilot commented

2026-03-25 23:13:48 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @Copilot
Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598948
Original created: 2026-03-25T23:13:48Z
Original path: .gitmodules
Original line: 3

Using an SSH URL for the submodule requires developer SSH key setup and can break CI or downstream consumers cloning without SSH credentials. Prefer an HTTPS URL (e.g., https://github.com/carverauto/arancini.git) unless the repo is strictly internal and CI is guaranteed to have SSH access.

	url = https://github.com/carverauto/arancini.git

Imported GitHub PR review comment. Original author: @Copilot Original URL: https://github.com/carverauto/serviceradar/pull/2493#discussion_r2991598948 Original created: 2026-03-25T23:13:48Z Original path: .gitmodules Original line: 3 --- Using an SSH URL for the submodule requires developer SSH key setup and can break CI or downstream consumers cloning without SSH credentials. Prefer an HTTPS URL (e.g., `https://github.com/carverauto/arancini.git`) unless the repo is strictly internal and CI is guaranteed to have SSH access. ```suggestion url = https://github.com/carverauto/arancini.git ```

Source Code SBOM / generate-sbom (release) Has been cancelled

Details

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin refs/pull/2755/head:refs/pull/2755/head

git switch refs/pull/2755/head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff refs/pull/2755/head

git switch refs/pull/2755/head

git rebase main

git switch main

git merge --ff-only refs/pull/2755/head

git switch refs/pull/2755/head

git rebase main

git switch main

git merge --no-ff refs/pull/2755/head

git switch main

git merge --squash refs/pull/2755/head