2618 bug not capturing response time from sweep results #2815
No reviewers
Labels
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
carverauto/serviceradar!2815
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "refs/pull/2815/head"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Imported from GitHub pull request.
Original GitHub pull request: #2624
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624
Original created: 2026-01-30T21:45:41Z
Original updated: 2026-01-31T02:03:30Z
Original head: carverauto/serviceradar:2618-bug-not-capturing-response-time-from-sweep-results
Original base: staging
Original merged: 2026-01-31T02:03:28Z by @mfreeman451
IMPORTANT: Please sign the Developer Certificate of Origin
Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:
Describe your changes
Issue ticket number and link
Code checklist before requesting a review
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748083945
Original created: 2026-01-30T21:46:51Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 60
shouldnt be looking at agent gateway id anymore
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748084411
Original created: 2026-01-30T21:46:59Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 130
same thing here
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748084785
Original created: 2026-01-30T21:47:06Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 140
dont need gw id
Imported GitHub PR review comment.
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2624#discussion_r2748085414
Original created: 2026-01-30T21:47:15Z
Original path: elixir/serviceradar_core/lib/serviceradar/agent_config/compilers/sweep_compiler.ex
Original line: 151
-gw id