carverauto/serviceradar
carverauto/serviceradar
2
3
Fork 0
Code Issues 233 Pull requests 24 Projects Releases 254 Packages Wiki Activity Actions 8

fix(addons): drop agent_uid when upserting an add-on assignment to :update (#3425) #3529

Merged
mfreeman451 merged 1 commit from fix/addon-assignment-upsert-agent-uid into staging 2026-06-04 22:19:38 +00:00
Conversation 0 Commits 1 Files changed 1 +4 -1
mfreeman451 commented 2026-06-04 22:11:03 +00:00
Owner
Copy link

Assigning an add-on to an agent (single or cohort) that already had it failed with
'No such input agent_uid for action ...AddonAssignment.update'. The upsert path
passed the full attrs — including the immutable agent_uid identity — to :update,
which only accepts mutable fields. Drop agent_uid (the existing row already carries
it) and pass only the mutable attrs when re-enabling/upgrading in place.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

  • I have signed the DCO?
  • The build completes without errors?
  • All tests are passing when running make test?
Assigning an add-on to an agent (single or cohort) that already had it failed with 'No such input `agent_uid` for action ...AddonAssignment.update'. The upsert path passed the full attrs — including the immutable agent_uid identity — to :update, which only accepts mutable fields. Drop agent_uid (the existing row already carries it) and pass only the mutable attrs when re-enabling/upgrading in place. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?
fix(addons): drop agent_uid when upserting an add-on assignment to :update (#3425)
Some checks failed
lint / lint (push) Successful in 53s
Details
Golang Tests / test-go (push) Successful in 1m28s
Details
Helm Lint / Helm Lint (pull_request) Successful in 16s
Details
Secret Scan / gitleaks (pull_request) Successful in 29s
Details
Fingerprint Licensing / netprobe-fingerprint-licenses (pull_request) Failing after 1m3s
Details
lint / lint (pull_request) Successful in 1m19s
Details
Elixir Quality / Elixir Quality (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
f86a61de39 
Assigning an add-on to an agent (single or cohort) that already had it failed with
'No such input `agent_uid` for action ...AddonAssignment.update'. The upsert path
passed the full attrs — including the immutable agent_uid identity — to :update,
which only accepts mutable fields. Drop agent_uid (the existing row already carries
it) and pass only the mutable attrs when re-enabling/upgrading in place.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mfreeman451 force-pushed fix/addon-assignment-upsert-agent-uid from f86a61de39
Some checks failed
lint / lint (push) Successful in 53s
Details
Golang Tests / test-go (push) Successful in 1m28s
Details
Helm Lint / Helm Lint (pull_request) Successful in 16s
Details
Secret Scan / gitleaks (pull_request) Successful in 29s
Details
Fingerprint Licensing / netprobe-fingerprint-licenses (pull_request) Failing after 1m3s
Details
lint / lint (pull_request) Successful in 1m19s
Details
Elixir Quality / Elixir Quality (pull_request) Has been cancelled
Details
CI / build (pull_request) Has been cancelled
Details
to f01b16484d
Some checks failed
Netprobe eBPF Verifier / Verify eBPF programs on Linux 5.15 (push) Waiting to run
Details
Netprobe eBPF Verifier / Verify eBPF programs on Linux 5.8 (push) Waiting to run
Details
Netprobe eBPF Verifier / Verify eBPF programs on Linux 6.x (push) Waiting to run
Details
Netprobe eBPF Verifier / Verify eBPF refusal on Linux 5.4 (push) Waiting to run
Details
Secret Scan / gitleaks (pull_request) Successful in 1m11s
Details
Fingerprint Licensing / netprobe-fingerprint-licenses (push) Failing after 1m18s
Details
lint / lint (push) Successful in 1m51s
Details
Rust Tests / test-rust (rust/rdp-adapter, cargo) (push) Successful in 1m33s
Details
lint / lint (pull_request) Successful in 2m10s
Details
Golang Tests / test-go (push) Successful in 2m10s
Details
Rust Tests / test-rust (//rust/netprobe:netprobe, //build/platforms:linux_aarch64_musl, rust/netprobe, bazel-static) (push) Successful in 2m18s
Details
Rust Tests / test-rust (//rust/netprobe:netprobe_test, rust/netprobe, bazel-test) (push) Successful in 2m23s
Details
Rust Tests / test-rust (//rust/rperf-server:rperf, rust/rperf-server, bazel) (push) Successful in 2m48s
Details
Rust Tests / test-rust (rust/log-collector, cargo) (push) Successful in 2m51s
Details
Rust Tests / test-rust (rust/consumers/zen, cargo) (push) Successful in 3m1s
Details
Rust Tests / test-rust (rust/rperf-client, cargo) (push) Successful in 2m37s
Details
Rust Tests / test-rust (//rust/netprobe:netprobe, //build/platforms:linux_x86_64_musl, rust/netprobe, bazel-static) (push) Successful in 3m13s
Details
Rust Tests / test-rust (rust/trapd, cargo) (push) Successful in 2m47s
Details
Rust Tests / test-rust (rust/rdp-connector-probe, cargo) (push) Successful in 3m47s
Details
Rust Tests / test-rust (rust/srql, cargo) (push) Successful in 5m45s
Details
Elixir Quality / Elixir Quality (pull_request) Failing after 15m5s
Details
CI / build (pull_request) Failing after 25m31s
Details
2026-06-04 22:15:21 +00:00 Compare
mfreeman451 deleted branch fix/addon-assignment-upsert-agent-uid 2026-06-04 22:19:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1week

   
2weeks

   
Failed compliance check

   
IP cameras

   
NATS
NATS JetStream

  
Possible security concern

   
Review effort 1/5

   
Review effort 2/5

   
Review effort 3/5

   
Review effort 4/5

   
Review effort 5/5

   
UI

   
aardvark

   
accessibility

   
amd64

   
api

   
arm64

   
auth

   
back-end

   
bgp

   
blog

   
bug
Something isn't working

  
build

   
checkers

   
ci-cd
continuous integration-continuous deployments

  
cleanup

   
cnpg
cloud-native postgres

  
codex

   
core
core service

  
dependencies
Pull requests that update a dependency file

  
device-management

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
dusk

   
ebpf

   
enhancement
New feature or request

  
eta 1d

   
eta 1hr

   
eta 3d

   
eta 3hr

   
feature

   
fieldsurvey

   
github_actions
Pull requests that update GitHub Actions code

  
go
Pull requests that update Go code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
javascript
Pull requests that update Javascript code

  
k8s

   
log-collector

   
mapper

   
mtr
multi traceroute

  
needs-triage

   
netflow

   
network-sweep

   
observability

   
oracle
Oracle Linux related issues

  
otel
opentelemetry logs, traces, metrics

  
plug-in

   
proton
timeplus proton streaming database

  
python

   
question
Further information is requested

  
reddit

   
redhat

   
research

   
rperf

   
rperf-checker

   
rust
Pull requests that update rust code

  
sdk

   
security

   
serviceradar-agent

   
serviceradar-agent-gateway

   
serviceradar-web

   
serviceradar-web-ng

   
siem

   
snmp

   
sysmon

   
topology

   
ubiquiti

   
wasm

   
wontfix
This will not be worked on

  
zen-engine
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!3529
No description provided.