test(agent): cover netprobe add-on activation rollback paths (#3425) #3498

Closed

mfreeman451 wants to merge 0 commits from feat/netprobe-rollback-tests into staging

mfreeman451 commented

2026-06-01 13:35:04 +00:00

Owner

What

migrate-netprobe-to-native-addon §2.4 — test the activation rollback paths so a failed netprobe add-on activation never leaves a half-installed/enabled unit or a running-but-incapable process.

The rollback behavior already existed, but the post-stage orchestration in applySystemdAddon was untestable (hardcoded artifact root + a root-owned-updater shell-out).

Refactor (behavior-preserving): extract the post-stage unit reconcile/rollback into reconcileStagedSystemdUnits with an injectable installer (installUnitsFn) + a threaded runtime root. applySystemdAddon still passes runtimeRoot="" + the real updater installer — production path unchanged.
Tests (push_loop_addon_rollback_test.go):
- install-failure → current rolled back to the prior version, no remembered units;
- no units in the staged bundle → rollback without an install attempt;
- success → stays on the new version + records the installed units.

The capability-application failure path already rolls back inside stageAndCapability (covered there); this PR closes the unit discovery/selection/install paths.

Validation

go test ./go/pkg/agent/ -run TestReconcileStagedSystemdUnits — 3/3 pass; go vet clean.
bazel build //go/pkg/agent:agent_test — green (new test registered in the go_test srcs).

Note: //:gazelle is currently broken on staging by an unrelated root-BUILD reference (#3496 made scripts/ a bazel package, invalidating srcs = ["scripts/swiftlint_bazel.sh"]). Fixed in a separate PR; here the test file was registered by hand.

🤖 Generated with Claude Code

## What `migrate-netprobe-to-native-addon` **§2.4** — test the activation rollback paths so a failed netprobe add-on activation never leaves a half-installed/enabled unit or a running-but-incapable process. The rollback *behavior* already existed, but the post-stage orchestration in `applySystemdAddon` was **untestable** (hardcoded artifact root + a root-owned-updater shell-out). - **Refactor (behavior-preserving):** extract the post-stage unit reconcile/rollback into `reconcileStagedSystemdUnits` with an injectable installer (`installUnitsFn`) + a threaded runtime root. `applySystemdAddon` still passes `runtimeRoot=""` + the real updater installer — production path unchanged. - **Tests** (`push_loop_addon_rollback_test.go`): - install-failure → `current` rolled back to the prior version, no remembered units; - no units in the staged bundle → rollback **without** an install attempt; - success → stays on the new version + records the installed units. The capability-application failure path already rolls back inside `stageAndCapability` (covered there); this PR closes the unit discovery/selection/install paths. ## Validation - `go test ./go/pkg/agent/ -run TestReconcileStagedSystemdUnits` — 3/3 pass; `go vet` clean. - `bazel build //go/pkg/agent:agent_test` — green (new test registered in the `go_test` srcs). > Note: `//:gazelle` is currently broken on `staging` by an unrelated root-BUILD reference (`#3496` made `scripts/` a bazel package, invalidating `srcs = ["scripts/swiftlint_bazel.sh"]`). Fixed in a separate PR; here the test file was registered by hand. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns

test(agent): cover netprobe add-on activation rollback paths (#3425) #3498

What

Validation

Pull request closed