feat(agent): extract pushed-artifact add-on tarballs (delivery-models 1.2) (#3425) #3468

Merged

mfreeman451 merged 1 commit from feat/addon-pushed-tarball into staging

2026-05-31 16:16:35 +00:00

mfreeman451 commented

2026-05-31 16:15:35 +00:00

Owner

What

delivery-models task 1.2 (agent-side tarball delivery). A pushed-artifact add-on can now be a gzip tarball bundling the binary + its addon.yaml/config.schema.json + any .service/.timer units — not just a bare executable.

stageAddonArtifact auto-detects gzip (a bare binary still works unchanged for single-binary agent-sidecar add-ons), verifies the sha256/signature over the raw artifact bytes, and extracts the tarball into the versioned staging dir so the binary and its units land side-by-side under current/ — exactly where the agent discovers units and the root-owned updater applies setcap / installs systemd units.

This is the missing delivery link: it's what gets the .service/.timer files to the agent so the systemd supervision dispatch (the supervision slice) can install them.

Security

Extraction is hardened against hostile/malformed artifacts:

every entry must be a regular file named as a single safe path segment — rejects ../ traversal, subdirectories, symlinks, and hardlinks (ErrAddonTarballUnsafe);
bounded entry count (64) and per-file (512 MiB) / total (1 GiB) sizes, with a hard read cap independent of the declared header size — decompression-bomb guard (ErrAddonTarballTooLarge);
the declared binary must be present (ErrAddonTarballBinaryMissing);
binary written 0755, all other files 0644.

Verification

Unit tests: tarball extraction (binary executable + manifest/units 0644 under current/), missing-binary, unsafe entries (traversal / subdir / symlink), too-many-entries; bare-binary delivery regression intact. go build/vet/golangci-lint clean. (Extraction is platform-agnostic; the downstream setcap/systemctl were host-verified in the prior slices.)

Scope / follow-ups

Off staging, independent of the supervision-dispatch PR (different files); they compose when both land.
Build-side production of the per-arch tarball (the assembler/inventory + the signed-publish pipeline) is the complementary build-signing follow-up; this PR makes the agent ready to receive them.

🤖 Generated with Claude Code

## What delivery-models **task 1.2** (agent-side tarball delivery). A pushed-artifact add-on can now be a **gzip tarball** bundling the binary + its `addon.yaml`/`config.schema.json` + any `.service`/`.timer` units — not just a bare executable. `stageAddonArtifact` auto-detects gzip (a bare binary still works unchanged for single-binary `agent-sidecar` add-ons), verifies the sha256/signature over the raw artifact bytes, and extracts the tarball into the versioned staging dir so the binary and its units land **side-by-side under `current/`** — exactly where the agent discovers units and the root-owned updater applies `setcap` / installs systemd units. This is the missing delivery link: it's what gets the `.service`/`.timer` files to the agent so the systemd supervision dispatch (the supervision slice) can install them. ## Security Extraction is hardened against hostile/malformed artifacts: - every entry must be a **regular file** named as a **single safe path segment** — rejects `../` traversal, subdirectories, symlinks, and hardlinks (`ErrAddonTarballUnsafe`); - **bounded** entry count (64) and per-file (512 MiB) / total (1 GiB) sizes, with a hard read cap independent of the declared header size — decompression-bomb guard (`ErrAddonTarballTooLarge`); - the declared binary must be present (`ErrAddonTarballBinaryMissing`); - binary written `0755`, all other files `0644`. ## Verification Unit tests: tarball extraction (binary executable + manifest/units `0644` under `current/`), missing-binary, unsafe entries (traversal / subdir / symlink), too-many-entries; **bare-binary delivery regression intact**. `go build`/`vet`/`golangci-lint` clean. (Extraction is platform-agnostic; the downstream `setcap`/`systemctl` were host-verified in the prior slices.) ## Scope / follow-ups - Off `staging`, independent of the supervision-dispatch PR (different files); they compose when both land. - Build-side **production** of the per-arch tarball (the assembler/inventory + the signed-publish pipeline) is the complementary build-signing follow-up; this PR makes the agent **ready to receive** them. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns