2916 feat add support for IP cameras #3073

Merged

mfreeman451 merged 37 commits from refs/pull/3073/head into staging

2026-03-25 17:48:06 +00:00

mfreeman451 commented

2026-03-24 02:30:19 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #3069
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/3069
Original created: 2026-03-24T02:30:19Z
Original updated: 2026-03-25T17:48:08Z
Original head: carverauto/serviceradar:2916-feat-add-support-for-rtsp-cameras-in-topo-view
Original base: staging
Original merged: 2026-03-25T17:48:06Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #3069 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/3069 Original created: 2026-03-24T02:30:19Z Original updated: 2026-03-25T17:48:08Z Original head: carverauto/serviceradar:2916-feat-add-support-for-rtsp-cameras-in-topo-view Original base: staging Original merged: 2026-03-25T17:48:06Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

github-advanced-security[bot] commented

2026-03-24 02:33:53 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/3069#discussion_r2978641993
Original created: 2026-03-24T02:33:53Z
Original path: go/cmd/wasm-plugins/axis/rtsp_stream.go
Original line: 489

Use of a broken or weak cryptographic hashing algorithm on sensitive data

Sensitive data (password) is used in a hashing algorithm (MD5) that is insecure for password hashing, since it is not a computationally expensive hash function.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/3069#discussion_r2978641993 Original created: 2026-03-24T02:33:53Z Original path: go/cmd/wasm-plugins/axis/rtsp_stream.go Original line: 489 --- ## Use of a broken or weak cryptographic hashing algorithm on sensitive data [Sensitive data (password)](1) is used in a hashing algorithm (MD5) that is insecure for password hashing, since it is not a computationally expensive hash function. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/101)

gitguardian[bot] commented

2026-03-25 01:37:46 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @gitguardian[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/3069#issuecomment-4122552213
Original created: 2026-03-25T01:37:46Z

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.

^{_{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}}

Imported GitHub PR comment. Original author: @gitguardian[bot] Original URL: https://github.com/carverauto/serviceradar/pull/3069#issuecomment-4122552213 Original created: 2026-03-25T01:37:46Z --- #### ️✅ There are no secrets present in this pull request anymore. If these secrets were true positive and are still valid, we highly recommend you to revoke them. While these secrets were previously flagged, we no longer have a reference to the specific commits where they were detected. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find [here](https://docs.gitguardian.com/platform/remediate/remediate-incidents) more information about risks. --- 🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&utm_campaign=cr1) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.