carverauto/serviceradar

Fork 0

sync #3006

Merged

mfreeman451 merged 2 commits from refs/pull/3006/head into 2965-feat-netflow-stats

2026-03-02 06:22:10 +00:00

mfreeman451 commented

2026-03-02 06:21:35 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2980
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2980
Original created: 2026-03-02T06:21:35Z
Original updated: 2026-03-02T06:24:51Z
Original head: carverauto/serviceradar:staging
Original base: 2965-feat-netflow-stats
Original merged: 2026-03-02T06:22:10Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2980 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2980 Original created: 2026-03-02T06:21:35Z Original updated: 2026-03-02T06:24:51Z Original head: carverauto/serviceradar:staging Original base: 2965-feat-netflow-stats Original merged: 2026-03-02T06:22:10Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

qodo-code-review[bot] commented

2026-03-02 06:21:56 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2980#issuecomment-3982384722
Original created: 2026-03-02T06:21:56Z

Review Summary by Qodo

Update color scheme to Nocturne cyber palette and refresh theme variables

✨ Enhancement 🐞 Bug fix

Walkthroughs

Description

• Update color scheme from Dracula to Nocturne cyber palette
  - Replace green (#50fa7b) with cyan (#00D8FF) and neon green (#00E676)
  - Replace purple (#bd93f9) with magenta (#FF2A7A) and violet (#A855F7)
  - Replace orange (#ffb86c) with amber (#FF9A00)
• Refresh light and dark theme CSS variables for improved contrast
  - Light theme: zinc-scale backgrounds with deeper accent colors
  - Dark theme: near-black void backgrounds with neon cyber accents
• Add new Nocturne palette CSS custom properties for glow effects
• Fix GitHub Actions workflow variable handling in e2e-tests.yml

Diagram

flowchart LR
  A["Dracula Theme<br/>Green/Purple/Orange"] -->|"Replace Colors"| B["Nocturne Palette<br/>Cyan/Magenta/Amber"]
  B -->|"Update CSS Variables"| C["Light Theme<br/>Zinc Backgrounds"]
  B -->|"Update CSS Variables"| D["Dark Theme<br/>Neon Accents"]
  E["GitHub Actions<br/>Variable Refs"] -->|"Fix Syntax"| F["Env Variables<br/>in Script"]

File Changes

1. elixir/web-ng/assets/js/app.js ✨ Enhancement +1/-1

Update progress bar color to cyan

elixir/web-ng/assets/js/app.js

2. elixir/web-ng/assets/js/hooks/MapboxFlowMap.js ✨ Enhancement +4/-4

Update marker and line colors to new palette

elixir/web-ng/assets/js/hooks/MapboxFlowMap.js

3. elixir/web-ng/assets/js/hooks/charts/NetflowLineSeriesChart.js ✨ Enhancement +1/-1

Update previous series stroke color

elixir/web-ng/assets/js/hooks/charts/NetflowLineSeriesChart.js

View more (11)

4. elixir/web-ng/assets/js/hooks/charts/NetflowSankeyChart.js ✨ Enhancement +1/-1

Update color scale for source/mid/dest nodes

elixir/web-ng/assets/js/hooks/charts/NetflowSankeyChart.js

5. elixir/web-ng/assets/js/hooks/charts/NetflowStackedAreaChart.js ✨ Enhancement +3/-3

Update overlay stroke colors for chart

elixir/web-ng/assets/js/hooks/charts/NetflowStackedAreaChart.js

6. elixir/web-ng/assets/js/hooks/charts/TimeseriesCombinedChart.js ✨ Enhancement +1/-1

Update default series color fallback

elixir/web-ng/assets/js/hooks/charts/TimeseriesCombinedChart.js

7. elixir/web-ng/assets/js/lib/god_view/lifecycle_dom_setup_methods.js ✨ Enhancement +3/-3

Update HUD styling with new color palette

elixir/web-ng/assets/js/lib/god_view/lifecycle_dom_setup_methods.js

8. elixir/web-ng/assets/js/lib/god_view/rendering_tooltip_methods.js ✨ Enhancement +8/-8

Update tooltip background and text colors

elixir/web-ng/assets/js/lib/god_view/rendering_tooltip_methods.js

9. elixir/web-ng/lib/serviceradar_web_ng_web/dashboard/plugins/timeseries.ex ✨ Enhancement +7/-7

Update series color palette to Nocturne

elixir/web-ng/lib/serviceradar_web_ng_web/dashboard/plugins/timeseries.ex

10. elixir/web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex ✨ Enhancement +4/-4

Update tone stroke colors for states

elixir/web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex

11. elixir/web-ng/lib/serviceradar_web_ng_web/live/metric_live/show.ex ✨ Enhancement +1/-1

Update sparkline stroke color to cyan

elixir/web-ng/lib/serviceradar_web_ng_web/live/metric_live/show.ex

12. elixir/web-ng/lib/serviceradar_web_ng_web/live/spatial_live/index.ex ✨ Enhancement +3/-3

Update signal indicator colors and text styling

elixir/web-ng/lib/serviceradar_web_ng_web/live/spatial_live/index.ex

13. elixir/web-ng/assets/css/app.css ✨ Enhancement +73/-61

Refresh light/dark theme CSS variables and add glow effects

elixir/web-ng/assets/css/app.css

14. .github/workflows/e2e-tests.yml 🐞 Bug fix +6/-3

Fix GitHub Actions variable reference syntax

.github/workflows/e2e-tests.yml

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2980#issuecomment-3982384722 Original created: 2026-03-02T06:21:56Z --- <h3>Review Summary by Qodo</h3> Update color scheme to Nocturne cyber palette and refresh theme variables <code>✨ Enhancement</code> <code>🐞 Bug fix</code> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <h3>Walkthroughs</h3> <details open> <summary>Description</summary> <br/> <pre> • Update color scheme from Dracula to Nocturne cyber palette - Replace green (#50fa7b) with cyan (#00D8FF) and neon green (#00E676) - Replace purple (#bd93f9) with magenta (#FF2A7A) and violet (#A855F7) - Replace orange (#ffb86c) with amber (#FF9A00) • Refresh light and dark theme CSS variables for improved contrast - Light theme: zinc-scale backgrounds with deeper accent colors - Dark theme: near-black void backgrounds with neon cyber accents • Add new Nocturne palette CSS custom properties for glow effects • Fix GitHub Actions workflow variable handling in e2e-tests.yml </pre> </details> <details> <summary>Diagram</summary> <br/> > ```mermaid flowchart LR A["Dracula Theme<br/>Green/Purple/Orange"] -->|"Replace Colors"| B["Nocturne Palette<br/>Cyan/Magenta/Amber"] B -->|"Update CSS Variables"| C["Light Theme<br/>Zinc Backgrounds"] B -->|"Update CSS Variables"| D["Dark Theme<br/>Neon Accents"] E["GitHub Actions<br/>Variable Refs"] -->|"Fix Syntax"| F["Env Variables<br/>in Script"] ``` </details> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <h3>File Changes</h3> <details> <summary>1. elixir/web-ng/assets/js/app.js <code>✨ Enhancement</code> <code> +1/-1 </code> </summary> <br/> >Update progress bar color to cyan > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-cb037e30725231d82e904a1dccdbcb4a7a5c3c58f410627748c353dec4d40d3d'> elixir/web-ng/assets/js/app.js </a> <hr/> </details> <details> <summary>2. elixir/web-ng/assets/js/hooks/MapboxFlowMap.js <code>✨ Enhancement</code> <code> +4/-4 </code> </summary> <br/> >Update marker and line colors to new palette > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-2d8dd0175678c4b8eecca8eca366991da9b7863e640badf7adf4d87813305ab1'> elixir/web-ng/assets/js/hooks/MapboxFlowMap.js </a> <hr/> </details> <details> <summary>3. elixir/web-ng/assets/js/hooks/charts/NetflowLineSeriesChart.js <code>✨ Enhancement</code> <code> +1/-1 </code> </summary> <br/> >Update previous series stroke color > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-b078a99dbb234d0c9b13ca8d36e57696e70a4bbb9213f31a2de2c17935ad8074'> elixir/web-ng/assets/js/hooks/charts/NetflowLineSeriesChart.js </a> <hr/> </details> <details><summary><ins><strong>View more (11)</strong></ins></summary><br/> <details> <summary>4. elixir/web-ng/assets/js/hooks/charts/NetflowSankeyChart.js <code>✨ Enhancement</code> <code> +1/-1 </code> </summary> <br/> >Update color scale for source/mid/dest nodes > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-b22f1da647d47fed924dc9bf69d0c722bf6cba6f2d2390643ac8d354606da692'> elixir/web-ng/assets/js/hooks/charts/NetflowSankeyChart.js </a> <hr/> </details> <details> <summary>5. elixir/web-ng/assets/js/hooks/charts/NetflowStackedAreaChart.js <code>✨ Enhancement</code> <code> +3/-3 </code> </summary> <br/> >Update overlay stroke colors for chart > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-9fa93b4c4ca0213f2295f2cb318766449b02b7fc59efda96a02273f5f12b76b3'> elixir/web-ng/assets/js/hooks/charts/NetflowStackedAreaChart.js </a> <hr/> </details> <details> <summary>6. elixir/web-ng/assets/js/hooks/charts/TimeseriesCombinedChart.js <code>✨ Enhancement</code> <code> +1/-1 </code> </summary> <br/> >Update default series color fallback > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-09abac7a6d77b7fc8de16307bb50f8f8d6c06e1fb5a427a906a78cacc3f69023'> elixir/web-ng/assets/js/hooks/charts/TimeseriesCombinedChart.js </a> <hr/> </details> <details> <summary>7. elixir/web-ng/assets/js/lib/god_view/lifecycle_dom_setup_methods.js <code>✨ Enhancement</code> <code> +3/-3 </code> </summary> <br/> >Update HUD styling with new color palette > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-7b88fcb183a776c3df89b3352962b5cc6164d2302a74d211fb3fe4df9776cdd7'> elixir/web-ng/assets/js/lib/god_view/lifecycle_dom_setup_methods.js </a> <hr/> </details> <details> <summary>8. elixir/web-ng/assets/js/lib/god_view/rendering_tooltip_methods.js <code>✨ Enhancement</code> <code> +8/-8 </code> </summary> <br/> >Update tooltip background and text colors > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-b1bb8790f097597d140b2a2ec4cafd9f7d1c2e3f71af20b41b4501b693b40672'> elixir/web-ng/assets/js/lib/god_view/rendering_tooltip_methods.js </a> <hr/> </details> <details> <summary>9. elixir/web-ng/lib/serviceradar_web_ng_web/dashboard/plugins/timeseries.ex <code>✨ Enhancement</code> <code> +7/-7 </code> </summary> <br/> >Update series color palette to Nocturne > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-1f5919cc23cb8cb0d0180271abfce217f3632e5705e8854557a8262b8369f90f'> elixir/web-ng/lib/serviceradar_web_ng_web/dashboard/plugins/timeseries.ex </a> <hr/> </details> <details> <summary>10. elixir/web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex <code>✨ Enhancement</code> <code> +4/-4 </code> </summary> <br/> >Update tone stroke colors for states > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-ce40fa1e12333f9d0b573e75f869a3608615d20a828e4abadd42d464bafc9284'> elixir/web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex </a> <hr/> </details> <details> <summary>11. elixir/web-ng/lib/serviceradar_web_ng_web/live/metric_live/show.ex <code>✨ Enhancement</code> <code> +1/-1 </code> </summary> <br/> >Update sparkline stroke color to cyan > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-fc89bdd96552e701d38e302e717ea2c34df19556861c13c8dbaf932d63461c02'> elixir/web-ng/lib/serviceradar_web_ng_web/live/metric_live/show.ex </a> <hr/> </details> <details> <summary>12. elixir/web-ng/lib/serviceradar_web_ng_web/live/spatial_live/index.ex <code>✨ Enhancement</code> <code> +3/-3 </code> </summary> <br/> >Update signal indicator colors and text styling > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-0c1f654cc2fc4b47c7266a6938721dc2a4729ea41ac7ebbc3a3a6b451c9658dd'> elixir/web-ng/lib/serviceradar_web_ng_web/live/spatial_live/index.ex </a> <hr/> </details> <details> <summary>13. elixir/web-ng/assets/css/app.css <code>✨ Enhancement</code> <code> +73/-61 </code> </summary> <br/> >Refresh light/dark theme CSS variables and add glow effects > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-e764ac9c51c5322e453d34626027fbc055903829693f09b826c914ac3c2e7709'> elixir/web-ng/assets/css/app.css </a> <hr/> </details> <details> <summary>14. .github/workflows/e2e-tests.yml <code>🐞 Bug fix</code> <code> +6/-3 </code> </summary> <br/> >Fix GitHub Actions variable reference syntax > ><a href='https://github.com/carverauto/serviceradar/pull/2980/files#diff-194218c48b9a0cdd03974145733804c2d992ca818529fe2fa69a501d8b5b1cc3'> .github/workflows/e2e-tests.yml </a> <hr/> </details> </details> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <a href="https://www.qodo.ai"><img src="https://www.qodo.ai/wp-content/uploads/2025/03/qodo-logo.svg" width="80" alt="Qodo Logo"></a>

qodo-code-review[bot] commented

2026-03-02 06:21:57 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2980#issuecomment-3982384818
Original created: 2026-03-02T06:21:57Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2980#issuecomment-3982384818 Original created: 2026-03-02T06:21:57Z --- <h3>Code Review by Qodo</h3> <code>🐞 Bugs (0)</code> <code>📘 Rule violations (0)</code> <code>📎 Requirement gaps (0)</code> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <img src="https://www.qodo.ai/wp-content/uploads/2025/06/qodo-anteater.svg" width="25%"> <h3>Great, no issues found!</h3> Qodo reviewed your code and found no material issues that require review <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider"> <pre>ⓘ The new review experience is currently in Beta. <a href="https://docs.qodo.ai/qodo-documentation/code-review">Learn more</a></pre> <img src="https://www.qodo.ai/wp-content/uploads/2025/11/light-grey-line.svg" height="10%" alt="Grey Divider">  <a href="https://www.qodo.ai"><img src="https://www.qodo.ai/wp-content/uploads/2025/03/qodo-logo.svg" width="80" alt="Qodo Logo"></a>