carverauto/serviceradar

Fork 0

feat: "godview" visualizations #2923

Merged

mfreeman451 merged 40 commits from refs/pull/2923/head into staging

2026-02-17 06:32:49 +00:00

mfreeman451 commented

2026-02-14 05:47:36 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2836
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2836
Original created: 2026-02-14T05:47:36Z
Original updated: 2026-02-17T06:32:51Z
Original head: carverauto/serviceradar:2834-feat-ng-visualizations-deepcausality-integration
Original base: staging
Original merged: 2026-02-17T06:32:49Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2836 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2836 Original created: 2026-02-14T05:47:36Z Original updated: 2026-02-17T06:32:51Z Original head: carverauto/serviceradar:2834-feat-ng-visualizations-deepcausality-integration Original base: staging Original merged: 2026-02-17T06:32:49Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2026-02-14 06:57:53 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2807130225
Original created: 2026-02-14T06:57:53Z
Original path: web-ng/lib/serviceradar_web_ng/topology/god_view_stream.ex
Original line: 6

need to make sure this gets done

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2807130225 Original created: 2026-02-14T06:57:53Z Original path: web-ng/lib/serviceradar_web_ng/topology/god_view_stream.ex Original line: 6 --- need to make sure this gets done

mfreeman451 commented

2026-02-14 06:58:08 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2807130352
Original created: 2026-02-14T06:58:08Z
Original path: openspec/changes/add-god-view-topology-platform/tasks.md
Original line: 2

need to make sure we are implementing full telemetry atmosphere here

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2807130352 Original created: 2026-02-14T06:58:08Z Original path: openspec/changes/add-god-view-topology-platform/tasks.md Original line: 2 --- need to make sure we are implementing full telemetry atmosphere here

github-advanced-security[bot] commented

2026-02-15 08:43:47 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2808817437
Original created: 2026-02-15T08:43:47Z
Original path: pkg/mapper/snmp_polling.go
Original line: 2265

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from strconv.Atoi to a lower bit size type int32 without an upper bound check.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2808817437 Original created: 2026-02-15T08:43:47Z Original path: pkg/mapper/snmp_polling.go Original line: 2265 --- ## Incorrect conversion between integer types Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/94)

github-advanced-security[bot] commented

2026-02-15 08:43:47 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2808817441
Original created: 2026-02-15T08:43:47Z
Original path: pkg/mapper/snmp_polling.go
Original line: 2284

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from strconv.Atoi to a lower bit size type int32 without an upper bound check.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2808817441 Original created: 2026-02-15T08:43:47Z Original path: pkg/mapper/snmp_polling.go Original line: 2284 --- ## Incorrect conversion between integer types Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/95)

github-advanced-security[bot] commented

2026-02-17 02:43:44 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2814725977
Original created: 2026-02-17T02:43:44Z
Original path: pkg/mapper/snmp_polling.go
Original line: 2408

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from strconv.Atoi to a lower bit size type int32 without an upper bound check.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2814725977 Original created: 2026-02-17T02:43:44Z Original path: pkg/mapper/snmp_polling.go Original line: 2408 --- ## Incorrect conversion between integer types Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/96)

github-advanced-security[bot] commented

2026-02-17 04:25:23 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2814918902
Original created: 2026-02-17T04:25:23Z
Original path: pkg/mapper/snmp_polling.go
Original line: 2495

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from strconv.Atoi to a lower bit size type int32 without an upper bound check.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2836#discussion_r2814918902 Original created: 2026-02-17T04:25:23Z Original path: pkg/mapper/snmp_polling.go Original line: 2495 --- ## Incorrect conversion between integer types Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type int32 without an upper bound check. [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/97)