carverauto/serviceradar

Fork 0

feat: mdns collector #2861

Open

mikemiles-dev wants to merge 5 commits from refs/pull/2861/head into staging

mikemiles-dev commented

2026-02-06 04:05:03 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2714
Original author: @mikemiles-dev
Original URL: https://github.com/carverauto/serviceradar/pull/2714
Original created: 2026-02-06T04:05:03Z
Original updated: 2026-02-06T23:29:39Z
Original head: mikemiles-dev/serviceradar:feature/mdns-collector
Original base: staging

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2714 Original author: @mikemiles-dev Original URL: https://github.com/carverauto/serviceradar/pull/2714 Original created: 2026-02-06T04:05:03Z Original updated: 2026-02-06T23:29:39Z Original head: mikemiles-dev/serviceradar:feature/mdns-collector Original base: staging --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2026-02-06 05:04:20 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772306302
Original created: 2026-02-06T05:04:20Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/mdns.ex
Original line: 5

this comment might be outdated, i think the rust mDNS collector is now actually a golang collector?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772306302 Original created: 2026-02-06T05:04:20Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/mdns.ex Original line: 5 --- this comment might be outdated, i think the rust mDNS collector is now actually a golang collector?

mfreeman451 commented

2026-02-06 05:06:21 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772311892
Original created: 2026-02-06T05:06:21Z
Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/mdns.ex
Original line: 11

need to look into this more myself, we binary encode stuff with protobuf and throw it on NATS becuase we can, and then we have to deserialize it later on in the pipeline. are we really saving anything here or are we actually slowing things down by doing this..

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772311892 Original created: 2026-02-06T05:06:21Z Original path: elixir/serviceradar_core/lib/serviceradar/event_writer/processors/mdns.ex Original line: 11 --- need to look into this more myself, we binary encode stuff with protobuf and throw it on NATS becuase we can, and then we have to deserialize it later on in the pipeline. are we really saving anything here or are we actually slowing things down by doing this..

mfreeman451 commented

2026-02-06 06:14:57 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772507347
Original created: 2026-02-06T06:14:57Z
Original path: openspec/changes/refactor-mdns-grpc-ingestion/specs/mdns-discovery/spec.md
Original line: 4

note: need to update docs site with docs around available GRPC methods

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772507347 Original created: 2026-02-06T06:14:57Z Original path: openspec/changes/refactor-mdns-grpc-ingestion/specs/mdns-discovery/spec.md Original line: 4 --- note: need to update docs site with docs around available GRPC methods

mfreeman451 commented

2026-02-06 06:16:51 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772516601
Original created: 2026-02-06T06:16:51Z
Original path: openspec/changes/refactor-mdns-grpc-ingestion/specs/mdns-discovery/spec.md
Original line: 54

this is not a realistic scenario

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772516601 Original created: 2026-02-06T06:16:51Z Original path: openspec/changes/refactor-mdns-grpc-ingestion/specs/mdns-discovery/spec.md Original line: 54 --- this is not a realistic scenario

mfreeman451 commented

2026-02-06 06:18:35 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772522461
Original created: 2026-02-06T06:18:35Z
Original path: openspec/changes/refactor-mdns-grpc-ingestion/design.md
Original line: 4

need to double check this, I thought it was PushResults for stuff like this, status should just be for healthcheck/heartbeat kinda thing

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772522461 Original created: 2026-02-06T06:18:35Z Original path: openspec/changes/refactor-mdns-grpc-ingestion/design.md Original line: 4 --- need to double check this, I thought it was `PushResults` for stuff like this, status should just be for healthcheck/heartbeat kinda thing

mfreeman451 commented

2026-02-06 06:20:42 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772527682
Original created: 2026-02-06T06:20:42Z
Original path: openspec/changes/refactor-mdns-grpc-ingestion/design.md
Original line: 18

again, need to check if we should be using PushResults here, might need to update this as well

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772527682 Original created: 2026-02-06T06:20:42Z Original path: openspec/changes/refactor-mdns-grpc-ingestion/design.md Original line: 18 --- again, need to check if we should be using PushResults here, might need to update this as well

mfreeman451 commented

2026-02-06 06:38:01 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772570961
Original created: 2026-02-06T06:38:01Z
Original path: openspec/changes/refactor-mdns-grpc-ingestion/proposal.md
Original line: 32

not sure why this is a non-goal, we should surface this in the UI or at least through SRQL

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772570961 Original created: 2026-02-06T06:38:01Z Original path: openspec/changes/refactor-mdns-grpc-ingestion/proposal.md Original line: 32 --- not sure why this is a non-goal, we should surface this in the UI or at least through SRQL

mfreeman451 commented

2026-02-06 06:39:27 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772574438
Original created: 2026-02-06T06:39:27Z
Original path: openspec/changes/refactor-mdns-grpc-ingestion/tasks.md
Original line: 2

batch sending this stuff isnt a hard requirement, i just dont know the rate at which it is going to generate events/messages, we might be better off trying to batch stuff and sending when our buffer either gets full and on a timer

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2714#discussion_r2772574438 Original created: 2026-02-06T06:39:27Z Original path: openspec/changes/refactor-mdns-grpc-ingestion/tasks.md Original line: 2 --- batch sending this stuff isnt a hard requirement, i just dont know the rate at which it is going to generate events/messages, we might be better off trying to batch stuff and sending when our buffer either gets full and on a timer

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin refs/pull/2861/head:refs/pull/2861/head

git switch refs/pull/2861/head

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch staging

git merge --no-ff refs/pull/2861/head

git switch refs/pull/2861/head

git rebase staging

git switch staging

git merge --ff-only refs/pull/2861/head

git switch refs/pull/2861/head

git rebase staging

git switch staging

git merge --no-ff refs/pull/2861/head

git switch staging

git merge --squash refs/pull/2861/head