carverauto/serviceradar

Fork 0

fixing add device bug #2851

Merged

mfreeman451 merged 8 commits from refs/pull/2851/head into staging

2026-02-05 03:18:33 +00:00

mfreeman451 commented

2026-02-05 00:42:52 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2701
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2701
Original created: 2026-02-05T00:42:52Z
Original updated: 2026-02-05T03:18:35Z
Original head: carverauto/serviceradar:2700-bugweb-ng-cant-add-device-through-ui
Original base: staging
Original merged: 2026-02-05T03:18:33Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Bug fix

Description

Replace actor parameter with scope in Device API calls
Remove build_device_actor() helper function from two modules
Update Device.get_by_uid() calls to use positional boolean parameter
Standardize scope-based authorization across device operations

Diagram Walkthrough

flowchart LR
  A["Device Controller & Live Views"] -->|"Replace actor with scope"| B["Device API Calls"]
  C["build_device_actor Function"] -->|"Remove"| D["Simplified Code"]
  B -->|"Update parameter format"| E["Device.get_by_uid calls"]
  D -->|"Use scope directly"| E

File Walkthrough

Relevant files

Bug fix

device_controller.ex `Update device controller API call signature` web-ng/lib/serviceradar_web_ng/api/device_controller.ex Update `Device.get_by_uid()` call to include boolean parameter `false` and use `scope:` keyword argument	+1/-1
index.ex `Replace actor with scope in device import operations` web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex Remove `build_device_actor()` function entirely Replace all `actor` parameters with `scope` in device import and creation functions Update `Device.get_by_uid()` calls to use positional boolean parameter and `scope:` keyword Simplify `create_device()` and `create_single_device()` to pass scope directly	+9/-30
show.ex `Standardize scope-based authorization in show operations` web-ng/lib/serviceradar_web_ng_web/live/device_live/show.ex Remove `build_device_actor()` function Replace `actor:` parameter with `scope:` in `InterfaceSettings.get_by_interface()` call Update `Device.get_by_uid()` calls to use positional boolean parameter instead of `include_deleted:` keyword Change `Ash.update()` call to use `scope:` instead of `actor:` parameter	+4/-24

Imported from GitHub pull request. Original GitHub pull request: #2701 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2701 Original created: 2026-02-05T00:42:52Z Original updated: 2026-02-05T03:18:35Z Original head: carverauto/serviceradar:2700-bugweb-ng-cant-add-device-through-ui Original base: staging Original merged: 2026-02-05T03:18:33Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Bug fix ___ ### **Description** - Replace `actor` parameter with `scope` in Device API calls - Remove `build_device_actor()` helper function from two modules - Update `Device.get_by_uid()` calls to use positional boolean parameter - Standardize scope-based authorization across device operations ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Device Controller & Live Views"] -->|"Replace actor with scope"| B["Device API Calls"] C["build_device_actor Function"] -->|"Remove"| D["Simplified Code"] B -->|"Update parameter format"| E["Device.get_by_uid calls"] D -->|"Use scope directly"| E ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>device_controller.ex</strong><dd><code>Update device controller API call signature</code>                            </dd></summary> <hr> web-ng/lib/serviceradar_web_ng/api/device_controller.ex <ul><li>Update <code>Device.get_by_uid()</code> call to include boolean parameter <code>false</code> and <br>use <code>scope:</code> keyword argument</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2701/files#diff-ac55b43afa10dd331fa712def4e0af4608417e58727fbde08a6702ef180e46d4">+1/-1</a>      </td> </tr> <tr> <td> <details> <summary><strong>index.ex</strong><dd><code>Replace actor with scope in device import operations</code>          </dd></summary> <hr> web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex <ul><li>Remove <code>build_device_actor()</code> function entirely<br> <li> Replace all <code>actor</code> parameters with <code>scope</code> in device import and creation <br>functions<br> <li> Update <code>Device.get_by_uid()</code> calls to use positional boolean parameter <br>and <code>scope:</code> keyword<br> <li> Simplify <code>create_device()</code> and <code>create_single_device()</code> to pass scope <br>directly</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2701/files#diff-261a01f4876e5984e1d9e9b38a3540675dfb0272abc30e6bdb2a4fa610353cc7">+9/-30</a>    </td> </tr> <tr> <td> <details> <summary><strong>show.ex</strong><dd><code>Standardize scope-based authorization in show operations</code>  </dd></summary> <hr> web-ng/lib/serviceradar_web_ng_web/live/device_live/show.ex <ul><li>Remove <code>build_device_actor()</code> function<br> <li> Replace <code>actor:</code> parameter with <code>scope:</code> in <br><code>InterfaceSettings.get_by_interface()</code> call<br> <li> Update <code>Device.get_by_uid()</code> calls to use positional boolean parameter <br>instead of <code>include_deleted:</code> keyword<br> <li> Change <code>Ash.update()</code> call to use <code>scope:</code> instead of <code>actor:</code> parameter</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2701/files#diff-92d8e0af57d2f65dfb8562e896dbea17ef9f47074ffd14f58261decc76f80c24">+4/-24</a>    </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2026-02-05 00:43:21 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2701#issuecomment-3850453533
Original created: 2026-02-05T00:43:21Z

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance

🟢

No security concerns identified

No security vulnerabilities detected by AI analysis. Human verification advised for critical code.

Ticket Compliance

🟡

🎫 #2700

🟢	Ensure device-related API/UI calls use the correct authorization context (use `scope` rather than an `actor` map) so requests execute successfully.
⚪	Fix the Device Inventory "New Device" UI flow so adding a device no longer fails with an Ash query error about missing `:actor` field on `ServiceRadar.Inventory.Device`.
⚪	Verify in the UI that adding a device works end-to-end (no ash error; device is created/visible as expected).

Codebase Duplication Compliance

⚪

Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance

🟢

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

⚪

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Actor context removed: The PR removes build_device_actor/1 and replaces actor: usage with scope: which may reduce
user-identifying context available to audit logs depending on how scope is logged
downstream.

Referred Code

  create_single_device(device_data, scope)
end

defp create_single_device(device_data, scope) do
  # Generate a UID based on IP (or use a UUID)
  uid = generate_device_uid(device_data.ip)

  # First check if device already exists
  case Device.get_by_uid(uid, false, scope: scope) do
    {:ok, _existing} ->
      {:error, :already_exists}

    {:error, %Ash.Error.Query.NotFound{}} ->
      # Device doesn't exist, create it
      now = DateTime.utc_now()

      attrs =
        %{
          uid: uid,
          hostname: device_data.hostname,
          ip: device_data.ip,


 ... (clipped 16 lines)

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status:
Authorization context shift: The PR changes authorization context passing from actor: to scope: for read/update
operations, which requires verification that scope enforces equivalent
authentication/authorization guarantees in the underlying Ash actions.

Referred Code

# First get the device, then update it
case Device.get_by_uid(device_uid, false, scope: scope) do
  {:ok, device} ->
    device
    |> Ash.Changeset.for_update(:update, attrs)
    |> Ash.update(scope: scope)

Learn more about managing compliance generic rules or creating your own custom rules

Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2701#issuecomment-3850453533 Original created: 2026-02-05T00:43:21Z --- <pre>ⓘ You are approaching your monthly quota for Qodo. <a href="https://www.qodo.ai/pricing">Upgrade your plan</a></pre> ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>🟡</td> <td> <details> <summary>🎫 <a href=https://github.com/carverauto/serviceradar/issues/2700>#2700</a></summary> <table width='100%'><tbody> <tr><td rowspan=1>🟢</td> <td>Ensure device-related API/UI calls use the correct authorization context (use <code>scope</code> rather <br>than an <code>actor</code> map) so requests execute successfully.<br></td></tr> <tr><td rowspan=2>⚪</td> <td>Fix the Device Inventory "New Device" UI flow so adding a device no longer fails with an <br>Ash query error about missing <code>:actor</code> field on <code>ServiceRadar.Inventory.Device</code>.<br></td></tr> <tr><td>Verify in the UI that adding a device works end-to-end (no ash error; device is <br>created/visible as expected).<br></td></tr> </tbody></table> </details> </td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td rowspan=4>🟢</td><td> <details><summary><strong>Generic: Meaningful Naming and Self-Documenting Code</strong></summary><br> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code <br>self-documenting<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Robust Error Handling and Edge Case Management</strong></summary><br> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful <br>degradation<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Error Handling</strong></summary><br> **Objective:** To prevent the leakage of sensitive system information through error messages while <br>providing sufficient detail for internal debugging.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Logging Practices</strong></summary><br> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive <br>information like PII, PHI, or cardholder data.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td rowspan=2>⚪</td> <td><details> <summary><strong>Generic: Comprehensive Audit Trails</strong></summary><br> **Objective:** To create a detailed and reliable record of critical system actions for security analysis <br>and compliance.<br> **Status:** <br><a href='https://github.com/carverauto/serviceradar/pull/2701/files#diff-261a01f4876e5984e1d9e9b38a3540675dfb0272abc30e6bdb2a4fa610353cc7R2622-R2658'><strong>Actor context removed</strong></a>: The PR removes <code>build_device_actor/1</code> and replaces <code>actor:</code> usage with <code>scope:</code> which may reduce <br>user-identifying context available to audit logs depending on how <code>scope</code> is logged <br>downstream.<br> <details open><summary>Referred Code</summary> ```elixir create_single_device(device_data, scope) end defp create_single_device(device_data, scope) do # Generate a UID based on IP (or use a UUID) uid = generate_device_uid(device_data.ip) # First check if device already exists case Device.get_by_uid(uid, false, scope: scope) do {:ok, _existing} -> {:error, :already_exists} {:error, %Ash.Error.Query.NotFound{}} -> # Device doesn't exist, create it now = DateTime.utc_now() attrs = %{ uid: uid, hostname: device_data.hostname, ip: device_data.ip, ... (clipped 16 lines) ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary><strong>Generic: Security-First Input Validation and Data Handling</strong></summary><br> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent <br>vulnerabilities<br> **Status:** <br><a href='https://github.com/carverauto/serviceradar/pull/2701/files#diff-92d8e0af57d2f65dfb8562e896dbea17ef9f47074ffd14f58261decc76f80c24R4898-R4904'><strong>Authorization context shift</strong></a>: The PR changes authorization context passing from <code>actor:</code> to <code>scope:</code> for read/update <br>operations, which requires verification that <code>scope</code> enforces equivalent <br>authentication/authorization guarantees in the underlying Ash actions.<br> <details open><summary>Referred Code</summary> ```elixir # First get the device, then update it case Device.get_by_uid(device_uid, false, scope: scope) do {:ok, device} -> device |> Ash.Changeset.for_update(:update, attrs) |> Ash.update(scope: scope) ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2026-02-05 00:44:17 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2701#issuecomment-3850455969
Original created: 2026-02-05T00:44:17Z

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

PR Code Suggestions ✨

Explore these optional code suggestions:

Category Suggestion Impact

Possible issue

Category	Suggestion	Impact
Possible issue	Prevent race conditions during creation To prevent a race condition when creating a device, refactor the `create_single_device` function to use `Ash.create/2` with the `on_conflict` option, making the operation atomic. web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex [2625-2661] defp create_single_device(device_data, scope) do # Generate a UID based on IP (or use a UUID) uid = generate_device_uid(device_data.ip) - # First check if device already exists - case Device.get_by_uid(uid, false, scope: scope) do - {:ok, _existing} -> - {:error, :already_exists} + # Build device attributes for creation + attrs = + %{ + uid: uid, + hostname: device_data.hostname, + ip: device_data.ip, + type: device_data.type, + tags: device_data.tags + } + \|> Enum.reject(fn {_k, v} -> is_nil(v) or v == "" end) + \|> Map.new() - {:error, %Ash.Error.Query.NotFound{}} -> - # Build device attributes for creation - attrs = - %{ - uid: uid, - hostname: device_data.hostname, - ip: device_data.ip, - type: device_data.type, - tags: device_data.tags - } - \|> Enum.reject(fn {_k, v} -> is_nil(v) or v == "" end) - \|> Map.new() - - Device - \|> Ash.Changeset.for_create(:create, attrs) - \|> Ash.create(scope: scope) - - {:error, _} = error -> - error + Device + \|> Ash.Changeset.for_create(:create, attrs) + \|> Ash.create(scope: scope, on_conflict: :nothing, returning: [:uid]) + \|> case do + {:ok, %{uid: nil}} -> {:error, :already_exists} + other -> other end end Apply / Chat Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies a potential race condition in the `create_single_device` function and proposes an idiomatic, atomic solution using `on_conflict`, which improves the application's robustness.	Medium
Update

Prevent race conditions during creation

To prevent a race condition when creating a device, refactor the
create_single_device
function to use Ash.create/2 with the on_conflict option,
making the operation
atomic.

web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex [2625-2661]

 defp create_single_device(device_data, scope) do
   # Generate a UID based on IP (or use a UUID)
   uid = generate_device_uid(device_data.ip)
 
-  # First check if device already exists
-  case Device.get_by_uid(uid, false, scope: scope) do
-    {:ok, _existing} ->
-      {:error, :already_exists}
+  # Build device attributes for creation
+  attrs =
+    %{
+      uid: uid,
+      hostname: device_data.hostname,
+      ip: device_data.ip,
+      type: device_data.type,
+      tags: device_data.tags
+    }
+    |> Enum.reject(fn {_k, v} -> is_nil(v) or v == "" end)
+    |> Map.new()
 
-    {:error, %Ash.Error.Query.NotFound{}} ->
-      # Build device attributes for creation
-      attrs =
-        %{
-          uid: uid,
-          hostname: device_data.hostname,
-          ip: device_data.ip,
-          type: device_data.type,
-          tags: device_data.tags
-        }
-        |> Enum.reject(fn {_k, v} -> is_nil(v) or v == "" end)
-        |> Map.new()
-
-      Device
-      |> Ash.Changeset.for_create(:create, attrs)
-      |> Ash.create(scope: scope)
-
-    {:error, _} = error ->
-      error
+  Device
+  |> Ash.Changeset.for_create(:create, attrs)
+  |> Ash.create(scope: scope, on_conflict: :nothing, returning: [:uid])
+  |> case do
+    {:ok, %{uid: nil}} -> {:error, :already_exists}
+    other -> other
   end
 end

Apply / Chat

Suggestion importance[1-10]: 8

Why: The suggestion correctly identifies a potential race condition in the create_single_device
function and proposes an idiomatic, atomic solution using on_conflict, which
improves the application's robustness.

Medium

Update

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2701#issuecomment-3850455969 Original created: 2026-02-05T00:44:17Z --- <pre>ⓘ You are approaching your monthly quota for Qodo. <a href="https://www.qodo.ai/pricing">Upgrade your plan</a></pre> ## PR Code Suggestions ✨  Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>Possible issue</td> <td> <details><summary>Prevent race conditions during creation</summary> ___ **To prevent a race condition when creating a device, refactor the <br><code>create_single_device</code><br> function to use <code>Ash.create/2</code> with the <code>on_conflict</code> option, <br>making the operation<br> atomic.** [web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex [2625-2661]](https://github.com/carverauto/serviceradar/pull/2701/files#diff-261a01f4876e5984e1d9e9b38a3540675dfb0272abc30e6bdb2a4fa610353cc7R2625-R2661) ```diff defp create_single_device(device_data, scope) do # Generate a UID based on IP (or use a UUID) uid = generate_device_uid(device_data.ip) - # First check if device already exists - case Device.get_by_uid(uid, false, scope: scope) do - {:ok, _existing} -> - {:error, :already_exists} + # Build device attributes for creation + attrs = + %{ + uid: uid, + hostname: device_data.hostname, + ip: device_data.ip, + type: device_data.type, + tags: device_data.tags + } + |> Enum.reject(fn {_k, v} -> is_nil(v) or v == "" end) + |> Map.new() - {:error, %Ash.Error.Query.NotFound{}} -> - # Build device attributes for creation - attrs = - %{ - uid: uid, - hostname: device_data.hostname, - ip: device_data.ip, - type: device_data.type, - tags: device_data.tags - } - |> Enum.reject(fn {_k, v} -> is_nil(v) or v == "" end) - |> Map.new() - - Device - |> Ash.Changeset.for_create(:create, attrs) - |> Ash.create(scope: scope) - - {:error, _} = error -> - error + Device + |> Ash.Changeset.for_create(:create, attrs) + |> Ash.create(scope: scope, on_conflict: :nothing, returning: [:uid]) + |> case do + {:ok, %{uid: nil}} -> {:error, :already_exists} + other -> other end end ``` - [ ] **Apply / Chat**  <details><summary>Suggestion importance[1-10]: 8</summary> __ Why: The suggestion correctly identifies a potential race condition in the `create_single_device` function and proposes an idiomatic, atomic solution using `on_conflict`, which improves the application's robustness. </details></details></td><td align=center>Medium </td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td><td></td></tr></tbody></table>