carverauto/serviceradar

Fork 0

changing default tab #2828

Merged

mfreeman451 merged 1 commit from refs/pull/2828/head into staging

2026-02-02 01:39:02 +00:00

mfreeman451 commented

2026-02-02 01:38:46 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2662
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2662
Original created: 2026-02-02T01:38:46Z
Original updated: 2026-02-02T01:39:37Z
Original head: carverauto/serviceradar:2660-feat-logs-should-be-default-tab-in-observability-page
Original base: staging
Original merged: 2026-02-02T01:39:02Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Enhancement

Description

Changes default tab to "logs" in observability page
Updates default_tab_for_path/1 function behavior

Diagram Walkthrough

flowchart LR
  observability["/observability path"]
  default["default_tab_for_path/1"]
  logs["logs tab"]
  observability -- "routes to" --> default
  default -- "returns" --> logs

File Walkthrough

Relevant files

Enhancement

index.ex

Change observability default tab to logs

web-ng/lib/serviceradar_web_ng_web/live/log_live/index.ex

Modified default_tab_for_path/1 function to return "logs" instead of
"traces" for "/observability" path
Ensures logs tab is displayed by default when accessing observability
page

+1/-1

Imported from GitHub pull request. Original GitHub pull request: #2662 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2662 Original created: 2026-02-02T01:38:46Z Original updated: 2026-02-02T01:39:37Z Original head: carverauto/serviceradar:2660-feat-logs-should-be-default-tab-in-observability-page Original base: staging Original merged: 2026-02-02T01:39:02Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Enhancement ___ ### **Description** - Changes default tab to "logs" in observability page - Updates `default_tab_for_path/1` function behavior ___ ### Diagram Walkthrough ```mermaid flowchart LR observability["/observability path"] default["default_tab_for_path/1"] logs["logs tab"] observability -- "routes to" --> default default -- "returns" --> logs ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Enhancement</strong></td><td><table> <tr> <td> <details> <summary><strong>index.ex</strong><dd><code>Change observability default tab to logs</code>                                  </dd></summary> <hr> web-ng/lib/serviceradar_web_ng_web/live/log_live/index.ex <ul><li>Modified <code>default_tab_for_path/1</code> function to return "logs" instead of <br>"traces" for "/observability" path<br> <li> Ensures logs tab is displayed by default when accessing observability <br>page</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2662/files#diff-5c469994d989d04955c9b8a31536ed518a182b3f46819ecee9c3c22f651a4321">+1/-1</a>      </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2026-02-02 01:39:03 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2662#issuecomment-3832483172
Original created: 2026-02-02T01:39:03Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance

🟢

No security concerns identified

No security vulnerabilities detected by AI analysis. Human verification advised for critical code.

Ticket Compliance

🟡

🎫 #2660

🟢	Change the Observability page default tab from `Traces` to `Logs` when visiting `/observability` (i.e., open on logs by default).
⚪	Confirm in the browser that navigating to `/observability` now lands on the Logs tab by default (including any routing/query-param interactions such as `?tab=`).

Codebase Duplication Compliance

⚪

Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance

🟢

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2662#issuecomment-3832483172 Original created: 2026-02-02T01:39:03Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>🟡</td> <td> <details> <summary>🎫 <a href=https://github.com/carverauto/serviceradar/issues/2660>#2660</a></summary> <table width='100%'><tbody> <tr><td rowspan=1>🟢</td> <td>Change the Observability page default tab from <code>Traces</code> to <code>Logs</code> when visiting <code>/observability</code> <br>(i.e., open on logs by default).<br></td></tr> <tr><td rowspan=1>⚪</td> <td>Confirm in the browser that navigating to <code>/observability</code> now lands on the Logs tab by <br>default (including any routing/query-param interactions such as <code>?tab=</code>).<br></td></tr> </tbody></table> </details> </td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td rowspan=6>🟢</td><td> <details><summary><strong>Generic: Comprehensive Audit Trails</strong></summary><br> **Objective:** To create a detailed and reliable record of critical system actions for security analysis <br>and compliance.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Meaningful Naming and Self-Documenting Code</strong></summary><br> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code <br>self-documenting<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Robust Error Handling and Edge Case Management</strong></summary><br> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful <br>degradation<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Error Handling</strong></summary><br> **Objective:** To prevent the leakage of sensitive system information through error messages while <br>providing sufficient detail for internal debugging.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Logging Practices</strong></summary><br> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive <br>information like PII, PHI, or cardholder data.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Security-First Input Validation and Data Handling</strong></summary><br> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent <br>vulnerabilities<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2026-02-02 01:39:37 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2662#issuecomment-3832484010
Original created: 2026-02-02T01:39:37Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Remove redundant function clause Remove the redundant `default_tab_for_path/1` function clause for `"/observability"`, as the catch-all clause already provides the same behavior. web-ng/lib/serviceradar_web_ng_web/live/log_live/index.ex [1720-1721] `-defp default_tab_for_path("/observability"), do: "logs" defp default_tab_for_path(_), do: "logs"` Apply / Chat Suggestion importance[1-10]: 5 __ Why: The suggestion correctly identifies that the function clause for `"/observability"` is redundant due to the catch-all clause and proposes its removal, which simplifies the code.	Low
More

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2662#issuecomment-3832484010 Original created: 2026-02-02T01:39:37Z --- ## PR Code Suggestions ✨  Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>General</td> <td> <details><summary>Remove redundant function clause</summary> ___ **Remove the redundant <code>default_tab_for_path/1</code> function clause for <br><code>"/observability"</code>, as the catch-all clause already provides the same behavior.** [web-ng/lib/serviceradar_web_ng_web/live/log_live/index.ex [1720-1721]](https://github.com/carverauto/serviceradar/pull/2662/files#diff-5c469994d989d04955c9b8a31536ed518a182b3f46819ecee9c3c22f651a4321R1720-R1721) ```diff -defp default_tab_for_path("/observability"), do: "logs" defp default_tab_for_path(_), do: "logs" ``` - [ ] **Apply / Chat**  <details><summary>Suggestion importance[1-10]: 5</summary> __ Why: The suggestion correctly identifies that the function clause for `"/observability"` is redundant due to the catch-all clause and proposes its removal, which simplifies the code. </details></details></td><td align=center>Low </td></tr> <tr><td align="center" colspan="2"> - [ ] More  </td><td></td></tr></tbody></table>