carverauto/serviceradar

Fork 0

Feature/netflow collection #2794

Merged

mikemiles-dev merged 14 commits from refs/pull/2794/head into staging

2026-02-01 04:18:30 +00:00

mikemiles-dev commented

2026-01-28 22:50:09 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2571
Original author: @mikemiles-dev
Original URL: https://github.com/carverauto/serviceradar/pull/2571
Original created: 2026-01-28T22:50:09Z
Original updated: 2026-02-01T04:18:30Z
Original head: mikemiles-dev/serviceradar:feature/netflow_collection
Original base: staging
Original merged: 2026-02-01T04:18:30Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2571 Original author: @mikemiles-dev Original URL: https://github.com/carverauto/serviceradar/pull/2571 Original created: 2026-01-28T22:50:09Z Original updated: 2026-02-01T04:18:30Z Original head: mikemiles-dev/serviceradar:feature/netflow_collection Original base: staging Original merged: 2026-02-01T04:18:30Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

CLAassistant commented

2026-01-28 22:50:20 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @CLAassistant
Original URL: https://github.com/carverauto/serviceradar/pull/2571#issuecomment-3814326610
Original created: 2026-01-28T22:50:20Z

All committers have signed the CLA.

Imported GitHub PR comment. Original author: @CLAassistant Original URL: https://github.com/carverauto/serviceradar/pull/2571#issuecomment-3814326610 Original created: 2026-01-28T22:50:20Z --- [![CLA assistant check](https://cla-assistant.io/pull/badge/signed)](https://cla-assistant.io/carverauto/serviceradar?pullRequest=2571) <br/>All committers have signed the CLA.

mfreeman451 commented

2026-01-28 22:57:00 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738955941
Original created: 2026-01-28T22:57:00Z
Original path: cmd/consumers/zen/src/flow_proto.rs
Original line: 183

do you mind moving these tests into their own files please?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738955941 Original created: 2026-01-28T22:57:00Z Original path: cmd/consumers/zen/src/flow_proto.rs Original line: 183 --- do you mind moving these tests into their own files please?

mfreeman451 commented

2026-01-28 22:58:17 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738958979
Original created: 2026-01-28T22:58:17Z
Original path: cmd/netflow-collector/src/config.rs
Original line: 162

should be /etc/serviceradar/certs

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738958979 Original created: 2026-01-28T22:58:17Z Original path: cmd/netflow-collector/src/config.rs Original line: 162 --- should be `/etc/serviceradar/certs`

mfreeman451 commented

2026-01-28 22:59:25 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738961597
Original created: 2026-01-28T22:59:25Z
Original path: rust/netflow-collector/src/converter.rs
Original line: 477

should we have a debug print here?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738961597 Original created: 2026-01-28T22:59:25Z Original path: rust/netflow-collector/src/converter.rs Original line: 477 --- should we have a debug print here?

mfreeman451 commented

2026-01-28 23:06:19 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738978103
Original created: 2026-01-28T23:06:19Z
Original path: cmd/netflow-collector/Dockerfile
Original line: 58

can we rename to /usr/local/bin/serviceradar-netflow ? or netflowd

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738978103 Original created: 2026-01-28T23:06:19Z Original path: cmd/netflow-collector/Dockerfile Original line: 58 --- can we rename to `/usr/local/bin/serviceradar-netflow` ? or `netflowd`

mfreeman451 commented

2026-01-28 23:07:45 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738982288
Original created: 2026-01-28T23:07:45Z
Original path: cmd/otel/Cargo.toml
Original line: 4

why did we have to downgrade this?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738982288 Original created: 2026-01-28T23:07:45Z Original path: cmd/otel/Cargo.toml Original line: 4 --- why did we have to downgrade this?

mfreeman451 commented

2026-01-28 23:09:02 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738985653
Original created: 2026-01-28T23:09:02Z
Original path: docker/compose/Dockerfile.web-ng
Original line: 67

not sure if we need these changes here, do we really need rust in our web-ng build?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738985653 Original created: 2026-01-28T23:09:02Z Original path: docker/compose/Dockerfile.web-ng Original line: 67 --- not sure if we need these changes here, do we really need rust in our web-ng build?

mfreeman451 commented

2026-01-28 23:11:31 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738993658
Original created: 2026-01-28T23:11:31Z
Original path: docker/compose/nats.docker.conf
Original line: 35

I think we may need to bring this back too or maybe re-name it so that it is clear it is for a development environment

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738993658 Original created: 2026-01-28T23:11:31Z Original path: docker/compose/nats.docker.conf Original line: 35 --- I think we may need to bring this back too or maybe re-name it so that it is clear it is for a development environment

mfreeman451 commented

2026-01-28 23:12:58 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738997660
Original created: 2026-01-28T23:12:58Z
Original path: pkg/consumers/db-event-writer/processor.go
Original line: 340

nit: wondering if these should all be constants

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2738997660 Original created: 2026-01-28T23:12:58Z Original path: pkg/consumers/db-event-writer/processor.go Original line: 340 --- nit: wondering if these should all be constants

mfreeman451 commented

2026-01-28 23:13:39 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739000023
Original created: 2026-01-28T23:13:39Z
Original path: pkg/consumers/db-event-writer/processor.go
Original line: 1370

nit: I don't think this will pass the linter test for dynamic error check

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739000023 Original created: 2026-01-28T23:13:39Z Original path: pkg/consumers/db-event-writer/processor.go Original line: 1370 --- nit: I don't think this will pass the linter test for dynamic error check

mfreeman451 commented

2026-01-28 23:14:18 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739001708
Original created: 2026-01-28T23:14:18Z
Original path: pkg/consumers/db-event-writer/processor.go
Original line: 1381

would we want to consider using a Bytes pool here?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739001708 Original created: 2026-01-28T23:14:18Z Original path: pkg/consumers/db-event-writer/processor.go Original line: 1381 --- would we want to consider using a Bytes pool here?

mfreeman451 commented

2026-01-28 23:20:58 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739016529
Original created: 2026-01-28T23:20:58Z
Original path: web-ng/lib/serviceradar_web_ng_web/components/layouts.ex
Original line: 162

I'm not sure where the best place for this is yet, or if it should even be in the sidebar nav, this is more a comment for myself than anything else.

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739016529 Original created: 2026-01-28T23:20:58Z Original path: web-ng/lib/serviceradar_web_ng_web/components/layouts.ex Original line: 162 --- I'm not sure where the best place for this is yet, or if it should even be in the sidebar nav, this is more a comment for myself than anything else.

mfreeman451 commented

2026-01-28 23:52:35 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739119086
Original created: 2026-01-28T23:52:35Z
Original path: web/src/components/Network/NetFlowView.tsx
Original line: 2

should be removed, part of legacy web (react/next)

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739119086 Original created: 2026-01-28T23:52:35Z Original path: web/src/components/Network/NetFlowView.tsx Original line: 2 --- should be removed, part of legacy web (react/next)

mikemiles-dev commented

2026-01-29 03:42:58 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mikemiles-dev
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739784668
Original created: 2026-01-29T03:42:58Z
Original path: cmd/otel/Cargo.toml
Original line: 4

shouldn't be. Need to fix.

Imported GitHub PR review comment. Original author: @mikemiles-dev Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739784668 Original created: 2026-01-29T03:42:58Z Original path: cmd/otel/Cargo.toml Original line: 4 --- shouldn't be. Need to fix.

mikemiles-dev commented

2026-01-29 03:43:39 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mikemiles-dev
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739787113
Original created: 2026-01-29T03:43:39Z
Original path: pkg/consumers/db-event-writer/processor.go
Original line: 1381

sure, haven't really done go in a couple years.

Imported GitHub PR review comment. Original author: @mikemiles-dev Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739787113 Original created: 2026-01-29T03:43:39Z Original path: pkg/consumers/db-event-writer/processor.go Original line: 1381 --- sure, haven't really done go in a couple years.

mikemiles-dev commented

2026-01-29 05:05:49 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mikemiles-dev
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739964791
Original created: 2026-01-29T05:05:49Z
Original path: web-ng/lib/serviceradar_web_ng_web/components/layouts.ex
Original line: 162

Yea I was sort of unsure where the best place for this observations would be myself

Imported GitHub PR review comment. Original author: @mikemiles-dev Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2739964791 Original created: 2026-01-29T05:05:49Z Original path: web-ng/lib/serviceradar_web_ng_web/components/layouts.ex Original line: 162 --- Yea I was sort of unsure where the best place for this observations would be myself

mfreeman451 commented

2026-01-29 05:51:58 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2740072853
Original created: 2026-01-29T05:51:58Z
Original path: pkg/consumers/db-event-writer/processor.go
Original line: 1381

This might help https://victoriametrics.com/blog/go-sync-pool/

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2740072853 Original created: 2026-01-29T05:51:58Z Original path: pkg/consumers/db-event-writer/processor.go Original line: 1381 --- This might help https://victoriametrics.com/blog/go-sync-pool/

mfreeman451 commented

2026-01-29 08:30:09 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2740502999
Original created: 2026-01-29T08:30:09Z
Original path: pkg/consumers/db-event-writer/processor.go
Original line: 1381

probably also worth mentioning there are some gotchas, https://x.com/func25/status/2016454182765822295

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2571#discussion_r2740502999 Original created: 2026-01-29T08:30:09Z Original path: pkg/consumers/db-event-writer/processor.go Original line: 1381 --- probably also worth mentioning there are some gotchas, https://x.com/func25/status/2016454182765822295