carverauto/serviceradar

Fork 0

2533 feat agent missing edge onboarding support #2776

Merged

mfreeman451 merged 30 commits from refs/pull/2776/head into staging

2026-01-27 23:03:51 +00:00

mfreeman451 commented

2026-01-27 09:29:24 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2539
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2539
Original created: 2026-01-27T09:29:24Z
Original updated: 2026-01-27T23:03:53Z
Original head: carverauto/serviceradar:2533-feat-agent-missing-edge-onboarding-support
Original base: staging
Original merged: 2026-01-27T23:03:51Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

Imported from GitHub pull request. Original GitHub pull request: #2539 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2539 Original created: 2026-01-27T09:29:24Z Original updated: 2026-01-27T23:03:53Z Original head: carverauto/serviceradar:2533-feat-agent-missing-edge-onboarding-support Original base: staging Original merged: 2026-01-27T23:03:51Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?

mfreeman451 commented

2026-01-27 09:34:40 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2539#discussion_r2731097075
Original created: 2026-01-27T09:34:40Z
Original path: web-ng/lib/serviceradar_web_ng/edge/collector_bundle_generator.ex
Original line: 528

why do we need the core address in the bundle at all anymore?

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2539#discussion_r2731097075 Original created: 2026-01-27T09:34:40Z Original path: web-ng/lib/serviceradar_web_ng/edge/collector_bundle_generator.ex Original line: 528 --- why do we need the core address in the bundle at all anymore?

github-advanced-security[bot] commented

2026-01-27 10:45:13 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @github-advanced-security[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2539#discussion_r2731393754
Original created: 2026-01-27T10:45:13Z
Original path: pkg/edgeonboarding/collector_enroll.go
Original line: 232

Arbitrary file access during archive extraction ("Zip Slip")

Unsanitized archive entry, which may contain '..', is used in a file system operation.
Unsanitized archive entry, which may contain '..', is used in a file system operation.
Unsanitized archive entry, which may contain '..', is used in a file system operation.

Show more details

Imported GitHub PR review comment. Original author: @github-advanced-security[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2539#discussion_r2731393754 Original created: 2026-01-27T10:45:13Z Original path: pkg/edgeonboarding/collector_enroll.go Original line: 232 --- ## Arbitrary file access during archive extraction ("Zip Slip") Unsanitized archive entry, which may contain '..', is used in a [file system operation](1). Unsanitized archive entry, which may contain '..', is used in a [file system operation](2). Unsanitized archive entry, which may contain '..', is used in a [file system operation](3). [Show more details](https://github.com/carverauto/serviceradar/security/code-scanning/93)

mfreeman451 commented

2026-01-27 11:07:12 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2539#discussion_r2731479758
Original created: 2026-01-27T11:07:12Z
Original path: pkg/edgeonboarding/collector_enroll.go
Original line: 232

added guard

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2539#discussion_r2731479758 Original created: 2026-01-27T11:07:12Z Original path: pkg/edgeonboarding/collector_enroll.go Original line: 232 --- added guard

qodo-code-review[bot] commented

2026-01-27 11:07:18 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2539#issuecomment-3804540112
Original created: 2026-01-27T11:07:18Z

ⓘ Your monthly quota for Qodo has expired. Upgrade your plan

ⓘ Paying users. Check that your Qodo account is linked with this Git user account

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2539#issuecomment-3804540112 Original created: 2026-01-27T11:07:18Z --- <pre>ⓘ Your monthly quota for Qodo has expired. <a href="https://www.qodo.ai/pricing">Upgrade your plan</a></pre> <pre>ⓘ Paying users. Check that your <a href="https://app.qodo.ai">Qodo account</a> is linked with this Git user account</pre>