carverauto/serviceradar

Fork 0

updating log schema openspec #2701

Merged

mfreeman451 merged 1 commit from refs/pull/2701/head into staging

2026-01-18 19:47:23 +00:00

mfreeman451 commented

2026-01-18 19:47:15 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2356
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2356
Original created: 2026-01-18T19:47:15Z
Original updated: 2026-01-18T19:47:45Z
Original head: carverauto/serviceradar:updates/otel-log-schema-tasks
Original base: staging
Original merged: 2026-01-18T19:47:23Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Other

Description

Mark four log schema implementation tasks as completed
Tasks cover OTEL schema audit, field mapping, UI updates, and test coverage

Diagram Walkthrough

flowchart LR
  A["Task Checklist"] -- "Mark completed" --> B["1.1 Audit OTEL schema"]
  A -- "Mark completed" --> C["1.2 Field mapping"]
  A -- "Mark completed" --> D["1.4 UI rendering"]
  A -- "Mark completed" --> E["1.5 Test coverage"]

File Walkthrough

Relevant files

Documentation

tasks.md

Complete four OTEL log schema tasks

openspec/changes/restore-otel-log-schema/tasks.md

Mark task 1.1 (OTEL schema audit) as completed
Mark task 1.2 (field mapping implementation) as completed
Mark task 1.4 (UI rendering updates) as completed
Mark task 1.5 (test coverage) as completed

+4/-4

Imported from GitHub pull request. Original GitHub pull request: #2356 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2356 Original created: 2026-01-18T19:47:15Z Original updated: 2026-01-18T19:47:45Z Original head: carverauto/serviceradar:updates/otel-log-schema-tasks Original base: staging Original merged: 2026-01-18T19:47:23Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Other ___ ### **Description** - Mark four log schema implementation tasks as completed - Tasks cover OTEL schema audit, field mapping, UI updates, and test coverage ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Task Checklist"] -- "Mark completed" --> B["1.1 Audit OTEL schema"] A -- "Mark completed" --> C["1.2 Field mapping"] A -- "Mark completed" --> D["1.4 UI rendering"] A -- "Mark completed" --> E["1.5 Test coverage"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td>Documentation</td><td><table> <tr> <td> <details> <summary>tasks.md<dd><code>Complete four OTEL log schema tasks</code>                                            </dd></summary> <hr> openspec/changes/restore-otel-log-schema/tasks.md <ul><li>Mark task 1.1 (OTEL schema audit) as completed <li> Mark task 1.2 (field mapping implementation) as completed <li> Mark task 1.4 (UI rendering updates) as completed <li> Mark task 1.5 (test coverage) as completed</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2356/files#diff-d39d8463ab316bb79b9898a5225d03269d05bc29f59d8fc6e86bb45ddb56258d">+4/-4</a>      </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2026-01-18 19:47:33 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2356#issuecomment-3765670754
Original created: 2026-01-18T19:47:33Z

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
⚪	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: No code changes: The PR only marks documentation tasks as completed and contains no code or configuration changes to verify that critical actions are logged with required audit context. Referred Code ## 1. Implementation - [x] 1.1 Audit current log ingestion/storage for OTEL schema retention and identify where fields are dropped. - [x] 1.2 Define and implement mapping for syslog/SNMP/GELF into OTEL log record fields (severity, body, resource/scope/attributes). - [ ] 1.3 Update log query/SRQL paths to return OTEL fields required by the UI. - [x] 1.4 Update Logs UI to render OTEL schema fields in list/detail views. - [x] 1.5 Add coverage (unit/integration) to verify OTEL fields persist from ingest through UI. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: No code changes: The PR contains only a tasks checklist update and does not include executable code where error handling and edge case management can be assessed. Referred Code ## 1. Implementation - [x] 1.1 Audit current log ingestion/storage for OTEL schema retention and identify where fields are dropped. - [x] 1.2 Define and implement mapping for syslog/SNMP/GELF into OTEL log record fields (severity, body, resource/scope/attributes). - [ ] 1.3 Update log query/SRQL paths to return OTEL fields required by the UI. - [x] 1.4 Update Logs UI to render OTEL schema fields in list/detail views. - [x] 1.5 Add coverage (unit/integration) to verify OTEL fields persist from ingest through UI. Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: No code changes: The PR only updates documentation task status and provides no logging implementation changes to validate structured logging and absence of sensitive data in logs. Referred Code ## 1. Implementation - [x] 1.1 Audit current log ingestion/storage for OTEL schema retention and identify where fields are dropped. - [x] 1.2 Define and implement mapping for syslog/SNMP/GELF into OTEL log record fields (severity, body, resource/scope/attributes). - [ ] 1.3 Update log query/SRQL paths to return OTEL fields required by the UI. - [x] 1.4 Update Logs UI to render OTEL schema fields in list/detail views. - [x] 1.5 Add coverage (unit/integration) to verify OTEL fields persist from ingest through UI. Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2356#issuecomment-3765670754 Original created: 2026-01-18T19:47:33Z --- <pre>ⓘ Your approaching your monthly quota for Qodo. <a href="https://www.qodo.ai/pricing">Upgrade your plan</a></pre> ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR: <table><tbody><tr><td colspan='2'>Security Compliance</td></tr> <tr><td>🟢</td><td><details><summary>No security concerns identified</summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'>Ticket Compliance</td></tr> <tr><td>⚪</td><td><details><summary>🎫 No ticket provided </summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'>Codebase Duplication Compliance</td></tr> <tr><td>⚪</td><td><details><summary>Codebase context is not defined </summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'>Custom Compliance</td></tr> <tr><td rowspan=3>🟢</td><td> <details><summary>Generic: Meaningful Naming and Self-Documenting Code</summary> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code self-documenting **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Secure Error Handling</summary> **Objective:** To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Security-First Input Validation and Data Handling</summary> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td rowspan=3>⚪</td> <td><details> <summary>Generic: Comprehensive Audit Trails</summary> **Objective:** To create a detailed and reliable record of critical system actions for security analysis and compliance. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2356/files#diff-d39d8463ab316bb79b9898a5225d03269d05bc29f59d8fc6e86bb45ddb56258dR1-R6'>No code changes</a>: The PR only marks documentation tasks as completed and contains no code or configuration changes to verify that critical actions are logged with required audit context. <details open><summary>Referred Code</summary> ```markdown ## 1. Implementation - [x] 1.1 Audit current log ingestion/storage for OTEL schema retention and identify where fields are dropped. - [x] 1.2 Define and implement mapping for syslog/SNMP/GELF into OTEL log record fields (severity, body, resource/scope/attributes). - [ ] 1.3 Update log query/SRQL paths to return OTEL fields required by the UI. - [x] 1.4 Update Logs UI to render OTEL schema fields in list/detail views. - [x] 1.5 Add coverage (unit/integration) to verify OTEL fields persist from ingest through UI. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Robust Error Handling and Edge Case Management</summary> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful degradation **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2356/files#diff-d39d8463ab316bb79b9898a5225d03269d05bc29f59d8fc6e86bb45ddb56258dR1-R6'>No code changes</a>: The PR contains only a tasks checklist update and does not include executable code where error handling and edge case management can be assessed. <details open><summary>Referred Code</summary> ```markdown ## 1. Implementation - [x] 1.1 Audit current log ingestion/storage for OTEL schema retention and identify where fields are dropped. - [x] 1.2 Define and implement mapping for syslog/SNMP/GELF into OTEL log record fields (severity, body, resource/scope/attributes). - [ ] 1.3 Update log query/SRQL paths to return OTEL fields required by the UI. - [x] 1.4 Update Logs UI to render OTEL schema fields in list/detail views. - [x] 1.5 Add coverage (unit/integration) to verify OTEL fields persist from ingest through UI. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary>Generic: Secure Logging Practices</summary> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2356/files#diff-d39d8463ab316bb79b9898a5225d03269d05bc29f59d8fc6e86bb45ddb56258dR1-R6'>No code changes</a>: The PR only updates documentation task status and provides no logging implementation changes to validate structured logging and absence of sensitive data in logs. <details open><summary>Referred Code</summary> ```markdown ## 1. Implementation - [x] 1.1 Audit current log ingestion/storage for OTEL schema retention and identify where fields are dropped. - [x] 1.2 Define and implement mapping for syslog/SNMP/GELF into OTEL log record fields (severity, body, resource/scope/attributes). - [ ] 1.3 Update log query/SRQL paths to return OTEL fields required by the UI. - [x] 1.4 Update Logs UI to render OTEL schema fields in list/detail views. - [x] 1.5 Add coverage (unit/integration) to verify OTEL fields persist from ingest through UI. ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant 🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label </details>

qodo-code-review[bot] commented

2026-01-18 19:47:44 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2356#issuecomment-3765670998
Original created: 2026-01-18T19:47:44Z

ⓘ Your approaching your monthly quota for Qodo. Upgrade your plan

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2356#issuecomment-3765670998 Original created: 2026-01-18T19:47:44Z --- <pre>ⓘ Your approaching your monthly quota for Qodo. <a href="https://www.qodo.ai/pricing">Upgrade your plan</a></pre> ## PR Code Suggestions ✨ No code suggestions found for the PR.