adding missing files #2673

Merged

mfreeman451 merged 1 commit from refs/pull/2673/head into staging

2026-01-14 21:22:47 +00:00

mfreeman451 commented

2026-01-14 21:22:22 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2309
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2309
Original created: 2026-01-14T21:22:22Z
Original updated: 2026-01-14T21:23:00Z
Original head: carverauto/serviceradar:update/missing-event-writer-checkin
Original base: staging
Original merged: 2026-01-14T21:22:47Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Other

Description

Format HTML attributes across multiple lines for readability
Fix whitespace inconsistency in text content
Adjust HTML comment indentation for consistency

Diagram Walkthrough

flowchart LR
  A["Template Files"] -->|"Format attributes"| B["Multi-line HTML"]
  A -->|"Fix whitespace"| C["Consistent spacing"]
  A -->|"Adjust indentation"| D["Aligned comments"]

File Walkthrough

Relevant files

Formatting

index.ex `Reformat span element attributes` web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex Reformatted element attributes to span multiple lines Improved readability by breaking `data-testid`, `class` attributes onto separate lines Maintained functional equivalence with better code formatting	+7/-4
index.ex `Fix whitespace in host count display` web-ng/lib/serviceradar_web_ng_web/live/settings/networks_live/index.ex Fixed whitespace inconsistency in text content string Changed spacing in "of {@hosts_processed} hosts" text for alignment	+1/-1
index.ex `Align JSON preview modal comment` web-ng/lib/serviceradar_web_ng_web/live/settings/sysmon_profiles_live/index.ex Adjusted HTML comment indentation to align with surrounding code Changed comment indentation from 8 spaces to 4 spaces	+1/-1

Imported from GitHub pull request. Original GitHub pull request: #2309 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2309 Original created: 2026-01-14T21:22:22Z Original updated: 2026-01-14T21:23:00Z Original head: carverauto/serviceradar:update/missing-event-writer-checkin Original base: staging Original merged: 2026-01-14T21:22:47Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Other ___ ### **Description** - Format HTML attributes across multiple lines for readability - Fix whitespace inconsistency in text content - Adjust HTML comment indentation for consistency ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Template Files"] -->|"Format attributes"| B["Multi-line HTML"] A -->|"Fix whitespace"| C["Consistent spacing"] A -->|"Adjust indentation"| D["Aligned comments"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td>Formatting</td><td><table> <tr> <td> <details> <summary>index.ex<dd><code>Reformat span element attributes</code>                                                  </dd></summary> <hr> web-ng/lib/serviceradar_web_ng_web/live/device_live/index.ex <ul><li>Reformatted <code></code> element attributes to span multiple lines <li> Improved readability by breaking <code>data-testid</code>, <code>class</code> attributes onto separate lines <li> Maintained functional equivalence with better code formatting</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2309/files#diff-261a01f4876e5984e1d9e9b38a3540675dfb0272abc30e6bdb2a4fa610353cc7">+7/-4</a>      </td> </tr> <tr> <td> <details> <summary>index.ex<dd><code>Fix whitespace in host count display</code>                                          </dd></summary> <hr> web-ng/lib/serviceradar_web_ng_web/live/settings/networks_live/index.ex <ul><li>Fixed whitespace inconsistency in text content string <li> Changed spacing in "of {@hosts_processed} hosts" text for alignment</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2309/files#diff-b2127e71582033bc6dfd2d7397f56bf43c1f7c613defffc504b3d8ee1e7406c4">+1/-1</a>      </td> </tr> <tr> <td> <details> <summary>index.ex<dd><code>Align JSON preview modal comment</code>                                                  </dd></summary> <hr> web-ng/lib/serviceradar_web_ng_web/live/settings/sysmon_profiles_live/index.ex <ul><li>Adjusted HTML comment indentation to align with surrounding code <li> Changed comment indentation from 8 spaces to 4 spaces</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2309/files#diff-8849d05a7171d718f17babecdf46709110ad58d7dbf378ed29429f2a4d50a5c5">+1/-1</a>      </td> </tr> </table></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2026-01-14 21:22:47 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2309#issuecomment-3751773516
Original created: 2026-01-14T21:22:47Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2309#issuecomment-3751773516 Original created: 2026-01-14T21:22:47Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR: <table><tbody><tr><td colspan='2'>Security Compliance</td></tr> <tr><td>🟢</td><td><details><summary>No security concerns identified</summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'>Ticket Compliance</td></tr> <tr><td>⚪</td><td><details><summary>🎫 No ticket provided </summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'>Codebase Duplication Compliance</td></tr> <tr><td>⚪</td><td><details><summary>Codebase context is not defined </summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'>Custom Compliance</td></tr> <tr><td rowspan=6>🟢</td><td> <details><summary>Generic: Comprehensive Audit Trails</summary> **Objective:** To create a detailed and reliable record of critical system actions for security analysis and compliance. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Meaningful Naming and Self-Documenting Code</summary> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code self-documenting **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Robust Error Handling and Edge Case Management</summary> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful degradation **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Secure Error Handling</summary> **Objective:** To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Secure Logging Practices</summary> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Security-First Input Validation and Data Handling</summary> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant 🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label </details>

qodo-code-review[bot] commented

2026-01-14 21:23:00 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2309#issuecomment-3751774273
Original created: 2026-01-14T21:23:00Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2309#issuecomment-3751774273 Original created: 2026-01-14T21:23:00Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.