carverauto/serviceradar

Fork 0

cleanup removed web #2648

Merged

mfreeman451 merged 1 commit from refs/pull/2648/head into testing

2026-01-11 18:00:56 +00:00

mfreeman451 commented

2026-01-11 18:00:21 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2245
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2245
Original created: 2026-01-11T18:00:21Z
Original updated: 2026-01-11T18:02:00Z
Original head: carverauto/serviceradar:chore/remove-legacy-agent
Original base: testing
Original merged: 2026-01-11T18:00:56Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Enhancement

Description

Remove legacy Next.js web application and all associated artifacts
Clean up Makefile targets and build system references to deprecated web
Update documentation to remove legacy UI configuration details
Archive change specification documenting complete legacy web removal

Diagram Walkthrough

flowchart LR
  A["Legacy Web Artifacts"] -->|Remove| B["web/ directory"]
  A -->|Remove| C["packaging/web/"]
  A -->|Remove| D["Docker files"]
  A -->|Remove| E["CI workflows"]
  F["Build System"] -->|Clean up| G["Makefile targets"]
  F -->|Update| H["SBOM workflow"]
  I["Documentation"] -->|Update| J["web-ui.md"]
  I -->|Update| K["installation.md"]
  L["Archive"] -->|Document| M["Change specification"]

File Walkthrough

Relevant files

Configuration changes

1 files

Makefile
Remove legacy web build targets and dependencies +3/-42

Documentation

5 files

web-ui.md `Remove deprecated Next.js UI documentation`	+3/-35
spec.md `Update requirements to reflect complete legacy removal`	+12/-8
spec.md `Archive modified requirements for legacy web removal`
tasks.md `Archive completed tasks for legacy web cleanup`	+28/-0
proposal.md `Archive change proposal for legacy web removal`	+20/-0

Additional files

101 files

sbom-images.yml	+0/-2
web-lint.yml	+0/-60
Dockerfile.web	+0/-110
entrypoint-web.sh	+0/-160
Dockerfile.rpm.web	+0/-273
installation.md	+0/-2
spec.md	+31/-0
serviceradar-web.spec	+0/-168
nginx.conf	+0/-132
web.json	+0/-5
package.sh	+0/-169
postinstall.sh	+0/-118
preremove.sh	+0/-54
serviceradar-web.service	+0/-20
build-web-rpm.sh	+0/-136
.npmrc	+0/-2
BUILD.bazel	+0/-13
README.md	+0/-36
build-and-run.sh	+0/-16
eslint.config.mjs	+0/-5
next.cli.js	+0/-43
next.config.bazel.d.ts	+0/-4
next.config.bazel.mjs	+0/-27
next.config.docker.ts	+0/-15
next.config.ts	+0/-25
package.json	+0/-61
pnpm-lock.yaml	+0/-6033
postcss.config.mjs	+0/-8
build-info.json	+0/-6
site.webmanifest	+0/-1
auth.ts	+0/-25
page.tsx	+0/-2208
layout.tsx	+0/-29
page.tsx	+0/-233
page.tsx	+0/-6
route.ts	+0/-95
route.ts	+0/-53
route.ts	+0/-23
proxy.ts	+0/-124
route.ts	+0/-43
route.ts	+0/-45
route.ts	+0/-39
route.ts	+0/-40
route.ts	+0/-39
route.ts	+0/-58
route.ts	+0/-22
helpers.ts	+0/-125
route.ts	+0/-46
route.ts	+0/-46
route.ts	+0/-46
route.ts	+0/-46
route.ts	+0/-55
route.ts	+0/-69
route.ts	+0/-26
route.ts	+0/-60
route.ts	+0/-39
route.ts	+0/-92
route.ts	+0/-1
route.ts	+0/-88
route.ts	+0/-120
route.ts	+0/-107
route.ts	+0/-96
route.ts	+0/-142
route.ts	+0/-129
route.ts	+0/-154
route.ts	+0/-89
route.ts	+0/-46
route.ts	+0/-205
route.ts	+0/-234
route.ts	+0/-247
route.ts	+0/-111
route.ts	+0/-73
route.ts	+0/-68
route.ts	+0/-55
route.ts	+0/-75
route.ts	+0/-75
route.ts	+0/-64
route.ts	+0/-77
route.ts	+0/-34
route.ts	+0/-81
route.ts	+0/-85
route.ts	+0/-57
route.ts	+0/-85
route.ts	+0/-81
route.ts	+0/-49
route.ts	+0/-101
route.ts	+0/-111
route.ts	+0/-249
route.ts	+0/-36
route.ts	+0/-64
page.tsx	+0/-29
page.tsx	+0/-55
page.tsx	+0/-39
page.tsx	+0/-37
globals.css	+0/-118
page.tsx	+0/-378
page.tsx	+0/-70
layout.tsx	+0/-29
page.tsx	+0/-90
page.tsx	+0/-25
Additional files not shown

Imported from GitHub pull request. Original GitHub pull request: #2245 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2245 Original created: 2026-01-11T18:00:21Z Original updated: 2026-01-11T18:02:00Z Original head: carverauto/serviceradar:chore/remove-legacy-agent Original base: testing Original merged: 2026-01-11T18:00:56Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Enhancement ___ ### **Description** - Remove legacy Next.js web application and all associated artifacts - Clean up Makefile targets and build system references to deprecated web - Update documentation to remove legacy UI configuration details - Archive change specification documenting complete legacy web removal ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Legacy Web Artifacts"] -->|Remove| B["web/ directory"] A -->|Remove| C["packaging/web/"] A -->|Remove| D["Docker files"] A -->|Remove| E["CI workflows"] F["Build System"] -->|Clean up| G["Makefile targets"] F -->|Update| H["SBOM workflow"] I["Documentation"] -->|Update| J["web-ui.md"] I -->|Update| K["installation.md"] L["Archive"] -->|Document| M["Change specification"] ``` <details><summary><h3>File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td>Configuration changes</td><td><details><summary>1 files</summary><table> <tr> <td>Makefile<dd><code>Remove legacy web build targets and dependencies</code>                  </dd></td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52">+3/-42</a>    </td> </tr> </table></details></td></tr><tr><td>Documentation</td><td><details><summary>5 files</summary><table> <tr> <td>web-ui.md<dd><code>Remove deprecated Next.js UI documentation</code>                              </dd></td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-7e4dc17ccc5b2fd5773b7e6c9583dbe0f597ab9ae21849a2ec0a31554a6337a3">+3/-35</a>    </td> </tr> <tr> <td>spec.md<dd><code>Update requirements to reflect complete legacy removal</code>      </dd></td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-d7dc254f1f43d90da9194e0827bb9fadcd7c2d007ff525a4e0e978c8ab40cdd2">+12/-8</a>    </td> </tr> <tr> <td>spec.md<dd><code>Archive modified requirements for legacy web removal</code>          </dd></td> <td><a href=""></a></td> </tr> <tr> <td>tasks.md<dd><code>Archive completed tasks for legacy web cleanup</code>                      </dd></td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-dd807806c52cb81037a12e57a460a7128082104bcb19f35254b84155d821bf47">+28/-0</a>    </td> </tr> <tr> <td>proposal.md<dd><code>Archive change proposal for legacy web removal</code>                      </dd></td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-545cf1a7e238d8e0b017f7efe45a68abef79e8853061b138c9ed3eb7beb01601">+20/-0</a>    </td> </tr> </table></details></td></tr><tr><td>Additional files</td><td><details><summary>101 files</summary><table> <tr> <td>sbom-images.yml</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-306f4aa8e8e286f727246a7517eecd45f3535fd99a644f60d635b9fa39875f54">+0/-2</a>      </td> </tr> <tr> <td>web-lint.yml</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-9d090859e31fc574efb47cacf534d619a3e83d55e59da3be2484999b9055b1b2">+0/-60</a>    </td> </tr> <tr> <td>Dockerfile.web</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-89393e743136e5cf7e1d67b378bc56da802452c481f2d63399bf72aac3d21e67">+0/-110</a>  </td> </tr> <tr> <td>entrypoint-web.sh</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-cbf60f692a5b524b141bf8b7fcff7abba11038d0b1c5a08378c0fd89e742d74e">+0/-160</a>  </td> </tr> <tr> <td>Dockerfile.rpm.web</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-36c05b67d8739bd0f1cda6ecc1f207a14363869a7acf7fb98180eb486c4f1217">+0/-273</a>  </td> </tr> <tr> <td>installation.md</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-19fd876fb56da88a1becb80817b52db1a40e8491641d547913b93bb7ecda3d22">+0/-2</a>      </td> </tr> <tr> <td>spec.md</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c7dc149ae08a50499a66025b37ffb2434404572942e109628c8289fd4e4e8513">+31/-0</a>    </td> </tr> <tr> <td>serviceradar-web.spec</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c84b985ecad45b6ee62657446e763878a6dd4e9a01e5903053cc923d88c34edb">+0/-168</a>  </td> </tr> <tr> <td>nginx.conf</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-7dcbfb7855889d0bfddfb3aae36cd21a9fa0cc8d504cca3f9561445db8d15dc7">+0/-132</a>  </td> </tr> <tr> <td>web.json</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-fa626c692453f664acceee4cca4a4b99915bb03b5dc7cae197a7d05e8818fd13">+0/-5</a>      </td> </tr> <tr> <td>package.sh</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-df1241cf1a027fbc4ca7a50d6fa7e58f7ee7d71ea341f9750152f009e8504d5c">+0/-169</a>  </td> </tr> <tr> <td>postinstall.sh</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-2ea7576bd0ccdd66a3b2f12c7736adf8745fd3be7907486701ccaefd319e057a">+0/-118</a>  </td> </tr> <tr> <td>preremove.sh</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-08f4cb2528514dd5b0d3e5bc7410615212a51cf180ed356d24605dea23f1c16d">+0/-54</a>    </td> </tr> <tr> <td>serviceradar-web.service</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-bc9f252862e87ed3e1c6bcb70e01df5695d896d1ed8b48d09b687a97cb53bac0">+0/-20</a>    </td> </tr> <tr> <td>build-web-rpm.sh</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-9750bd39fd69a4d0a445cd1c23a4199b41c6dd388cafcb0a1a7fd5081a5d6083">+0/-136</a>  </td> </tr> <tr> <td>.npmrc</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-586bd717b47ee72437b28aa702285175e654e2dec291e946834964cf753f0d98">+0/-2</a>      </td> </tr> <tr> <td>BUILD.bazel</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-1d59088f07bd1569a5a928ec3d13f6a85f7277c23483e5b7fa05a12d5fcaa394">+0/-13</a>    </td> </tr> <tr> <td>README.md</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-4a534cf0dab53faad7a19d1926cb05f63ebf793e827bdf11a4a19e0e654ef639">+0/-36</a>    </td> </tr> <tr> <td>build-and-run.sh</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-6710ee3c0b642f99d7e36eec495831671c272390a640538655ae91907e764a23">+0/-16</a>    </td> </tr> <tr> <td>eslint.config.mjs</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-ea30ea50e8837fd0d703b99e19ea7b5d4d2f5edd468bd9875591d6cfa983cf11">+0/-5</a>      </td> </tr> <tr> <td>next.cli.js</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-bc73cf67bdc8538063b46c77bb658c4b141dd161339ed2e39b00a83491499c73">+0/-43</a>    </td> </tr> <tr> <td>next.config.bazel.d.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-7054f48e02730b5f1619d7042e75e566de3af3bd44d18a919e71d3fc74c5c5d1">+0/-4</a>      </td> </tr> <tr> <td>next.config.bazel.mjs</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-02dc3251220daf4ccac6e0ef65f430fb0191cdfc7920e65a05aa7a2586615584">+0/-27</a>    </td> </tr> <tr> <td>next.config.docker.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-36d259848ec50c52fb3a1ce0bf4a9a42f793066eb473f3d393d8bcb6db452ad0">+0/-15</a>    </td> </tr> <tr> <td>next.config.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-9770efbcc0339bcebd28cd21a93170b901a9bb7041888b0e962861f38d3458cb">+0/-25</a>    </td> </tr> <tr> <td>package.json</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-b861012a5dd72b8a9f3281b7cf09f5a779c98569d040b1bbc1db50f1b15e7cce">+0/-61</a>    </td> </tr> <tr> <td>pnpm-lock.yaml</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-f11bfba22b3604b3a7b52e44e10f4eae265b030b5682714833ba689eda12a27b">+0/-6033</a></td> </tr> <tr> <td>postcss.config.mjs</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-5e5f03171f043ab5bd0ed9c795886d7e163b47e99cc248983fcb4f6acbb2bb71">+0/-8</a>      </td> </tr> <tr> <td>build-info.json</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-27336c978a24dc1efea27c315b22cea8a6ae27e9db6db4f69abd07faad604ad1">+0/-6</a>      </td> </tr> <tr> <td>site.webmanifest</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a45a521b12191393851a4a18a8c577b69fbbc98b447cc8d882e7b9713522431a">+0/-1</a>      </td> </tr> <tr> <td>auth.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-acb6e826f9508804bcf38c4ee7423dcb916c0a95f23d8209bd54d5a22f9fbda4">+0/-25</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-d627c4ba6a102a46a28024061371276f01053b63f20c75986aef2631b967bafc">+0/-2208</a></td> </tr> <tr> <td>layout.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-3fbb1beffc0ad0252665071114dc83044489508c2f1499aea265eba2218f1749">+0/-29</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-5e9f59af945d350f1fa3c76cd19d0d786df3cbb0947b53934f17dad4cd5ff546">+0/-233</a>  </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a3aace1a228a0df74f88a772f05cbd097f2b5f1b2aa037ca5e680bacc8c7d184">+0/-6</a>      </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-49bcbc728d894cabdb765f4e392b06024ffffa9d819e7134746f29222137d6c6">+0/-95</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c1db4e1be2726a7a59a3f56cfc09581699792a21ad80be938bc06a6561c57edc">+0/-53</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-cb55bb18ed52e3dc35d18e17d25f22c42db346e96c0f870c2973ce13df953281">+0/-23</a>    </td> </tr> <tr> <td>proxy.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-efbdcfc4a88b03f4292320f91f31515bd86eb070be3b8c65a3dc2e583276e9d7">+0/-124</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-cd21c2156b445a89675aafed261e647269cef390709656ee228c8c0859ace35b">+0/-43</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-4f5ec68ced779f56a0a889dc853bfbb631f9bb460128df3460b0015ba4802bce">+0/-45</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-e8b3fe18fdeaaa2134d4f4505e2ddcee69f97edf80c9202489da0355e39ea0c9">+0/-39</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c9500c2dddd4255b416bc0be06d427abbbf2d292fa8df9d461108cf09a6c503b">+0/-40</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c51b7264e94028406a13e011aca3cfa5ce5ea19fe3e5d2bbfa17c4f7e888f0eb">+0/-39</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c63680c9a4de5400810621f4c2607447142bf94c6a46d865d322ee8e0d6436b4">+0/-58</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-9c17227e99a84224bee16952ca80052acc47638686b211c8ccc7d15c518d631e">+0/-22</a>    </td> </tr> <tr> <td>helpers.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-6df873ec7c5ad9fab8b7efb3710243510651810ee51492fb3e5160b2c6edbb3d">+0/-125</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a0eaf7366d8bc22320b721030a965bfe01f2c974a787bdab88da98aae029f257">+0/-46</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-31f1a97d38f46c769083c7d59cecda05985d17ca40941024b9e6b5b904e03b44">+0/-46</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-c695f0093534b660b3d2482add2977d4661414d6b48ca093e01583a82e47aa92">+0/-46</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a7bb7def2b03e6255181252fbefaf63d018e2b767683eeb5f5a2faff9f56f883">+0/-46</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a58fc093c342a7bee7450e655b72ca7cd6139fab997a5718f7a41232b62b97c7">+0/-55</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-f1f6d40d82d85d2bff54cbd5bd8f24ac0fca0a6d7c517075f16837cba9d5cfd8">+0/-69</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-9ceed82129617772d52ea15a4c0cbfbe26bfcf1f1d03fc331327c37a57e2891b">+0/-26</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a46232cedfd896d0f83441aad8c9004ba00e2b13599eeed7ea93a9e313af0205">+0/-60</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-8ec3e6eab784db17164c21c173f8254157bcb0ab8f330dfb21b39fc6cbda72cd">+0/-39</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-bd4bcbded92386bca17b24cdbc2d1a1ddcf7394378f0c8405ac4550349066091">+0/-92</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-6297b1155c8b72db8b666e418a31e6f332324c4a6315b1934981d25ca5916330">+0/-1</a>      </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-5e0c82bc64633456165b7d1dcc72aeaed97ce0c9a2cc8d9b2315774136374adb">+0/-88</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-df5c14bda2056abb43b35a912cf133975024c21204a6b47071441a429ea6936d">+0/-120</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-2a19ebf99c6162553c17bfe515cfe7ffaa47a1424345953cfd5336fe2414b033">+0/-107</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-ea725df24de22d7f31e66dc5258e45d8970aa1cf0fdbe46a752e3929b8a5e228">+0/-96</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-8383b3b401bd9c9f9d5bf42926d8d8fa3cfb99c5e0346b349db92e17a8ad0b92">+0/-142</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-565dceead2e723f416ae3cee24e62a1e93364ce67237233e01b4a26c09bf8ba5">+0/-129</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-43ce6603c09c2e465d81122016d4259a139827ad31e500b61237c8707908eaae">+0/-154</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-6089b517f1838c001db6339f9855eaf3e88c76c36b9c33d7945b080b27cc5264">+0/-89</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-b4cb2683c8c8782c528b2bbb3f839b16d298a9bc73675e4c35873df971533ac1">+0/-46</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-89100d827efeda36efe13476c3922837fa28263650b601f7a07ba04a7d82080a">+0/-205</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-827b571570c5bad1d3facde18487184853c4f493239beaf00a1fb44e73c2046c">+0/-234</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-fca079849d880964a25c08e35d4eb30099fa0a442893ac7c7fb55b694bd25fd1">+0/-247</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-5815cb5ccddc2574c442a39d7fd4fc3e134974e6818248611e0b879a3ccbc4d8">+0/-111</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-bd27ff165fe55e9c3b69adeaa2247eca3cf364aef28faf693db8be790a4c7eae">+0/-73</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-00105b93f9dabec55b1d87e2479c00f428d9095d7a6a6adf8de907b74334f473">+0/-68</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-99d32617d55933536dcc9e352f1a0777ee49e5b19e1594bfd25ecc00e805747d">+0/-55</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-60dcc31e214dbd0965b10111d70bc78b82ae79e710926ddc15d8a55c4e31467e">+0/-75</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-e84537bbe57ef86554926810c838b1d58656272ed0915d34ee0244cbf1b047eb">+0/-75</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-30f0a7031ca883309f1a797ac7142921787e72c66214489f4e3499810ec65147">+0/-64</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-3d6327c82142422748fbdfe5556a1ec0d540fdffd0ce3b09c3b6b7e47d416241">+0/-77</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-4276ccfd877abfee5e8b01ee46ffc729037f3178cae2d20d141abceff044ebea">+0/-34</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a7cc421fa03fbc32705d1a4c05cbfff4c9936616aaae15e24fa8c4cde8cd5767">+0/-81</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-23eaa193daf67db00d17698f95e52b125267e29486536f6dbb0e416c3d8a8d40">+0/-85</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-88f94d3f50b69e2fc623db8edbca0acf5ee4808bc1a3830727fffaa985211ace">+0/-57</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-7498c8cc193c810ae6cd46d34d8108f5ed8fb1e66dfc6b96c191e4fd11e65c30">+0/-85</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-a4db040d20cc0b6e8319bcc07692f5bab0ec2de58426fb9ffd438daf885fd2c9">+0/-81</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-7eee952bc4573cf7fb60242b95e83269ef904013b5d2d6cf6518c5237fb6e553">+0/-49</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-8b59229cfa9e8e8f66e10be9569364853176d09da7cf0b4c987c85225da7fa55">+0/-101</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-f91e7130ff229964ba214215ac6366ed196a4fa77f9b7f2a7c62ad4785d74d0e">+0/-111</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-53eee72ee62c074b7ff0b7556920802805621e9e16bfa91f85675ec55b66bf32">+0/-249</a>  </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-dfb03c7fb0ea761b8710d40756def61b728492237703933e18463a0689beae58">+0/-36</a>    </td> </tr> <tr> <td>route.ts</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-347d2ec01d1a011fa6b72acd2fc55fddc924d24405ccd050ba8a055b3a18f85e">+0/-64</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-18f82626550e60fb487aa69b59822873b7a15aadb9241d9ade497aa7bfdeadfa">+0/-29</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-e809c54103258e08ab3a8706606939ece728b540f7bf6b0ae11984c18dd5267d">+0/-55</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-82bdeae7c59c4ed59eaab1acf291bade6faafa0403d5239bae1eeeabce0aa7a7">+0/-39</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-170fb3f739712e1150d0b831d8ffb58dff7c220d68562feb14e880af74e69f39">+0/-37</a>    </td> </tr> <tr> <td>globals.css</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-907b8ee36ef2dcc8cc0e1e315ec79895c944ae44255dfa2145ee996d60498b18">+0/-118</a>  </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-7d97637dd296bd515adeda8adb73e738d90a48fec745d944ed546b280e5f2f9c">+0/-378</a>  </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-faca274c1cefd7b665633ec6b133a58b0de89820f493f092867037197803f9f6">+0/-70</a>    </td> </tr> <tr> <td>layout.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-4792b521edf60449a591a5401bc931b74f601c62c7f443c7182e310d663ded6f">+0/-29</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-07c3171f5c210df36fdffe17f4adfedcf390711719aa1c4692ccc2b796ad547a">+0/-90</a>    </td> </tr> <tr> <td>page.tsx</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-ed2e2797dfaffdeafa2537aacc856101be8b392fd39dea2ad2f32540ae0d21aa">+0/-25</a>    </td> </tr> <tr> <td>Additional files not shown</td> <td><a href="https://github.com/carverauto/serviceradar/pull/2245/files#diff-2f328e4cd8dbe3ad193e49d92bcf045f47a6b72b1e9487d366f6b8288589b4ca"></a></td> </tr> </table></details></td></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2026-01-11 18:01:00 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2245#issuecomment-3735204724
Original created: 2026-01-11T18:01:00Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
🟢	Generic: Comprehensive Audit Trails Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Robust Error Handling and Edge Case Management Objective: Ensure comprehensive error handling that provides meaningful context and graceful degradation Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Error Handling Objective: To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Secure Logging Practices Objective: To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
	Generic: Security-First Input Validation and Data Handling Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities Status: Passed Learn more about managing compliance generic rules or creating your own custom rules
🔴	Generic: Meaningful Naming and Self-Documenting Code Objective: Ensure all identifiers clearly express their purpose and intent, making code self-documenting Status: Misleading target name: The `deb-all-container` Makefile target name and description imply container support, but the updated commands no longer indicate container-related behavior, making the identifier misleading. Referred Code `.PHONY: deb-all-container deb-all-container: ## Build all Debian packages @echo "$(COLOR_BOLD)Building all Debian packages$(COLOR_RESET)" @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb agent @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb nats @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb kv @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb sync @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb dusk-checker` Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2245#issuecomment-3735204724 Original created: 2026-01-11T18:01:00Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR: <table><tbody><tr><td colspan='2'>Security Compliance</td></tr> <tr><td>🟢</td><td><details><summary>No security concerns identified</summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'>Ticket Compliance</td></tr> <tr><td>⚪</td><td><details><summary>🎫 No ticket provided </summary> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'>Codebase Duplication Compliance</td></tr> <tr><td>⚪</td><td><details><summary>Codebase context is not defined </summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'>Custom Compliance</td></tr> <tr><td rowspan=5>🟢</td><td> <details><summary>Generic: Comprehensive Audit Trails</summary> **Objective:** To create a detailed and reliable record of critical system actions for security analysis and compliance. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Robust Error Handling and Edge Case Management</summary> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful degradation **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Secure Error Handling</summary> **Objective:** To prevent the leakage of sensitive system information through error messages while providing sufficient detail for internal debugging. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Secure Logging Practices</summary> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive information like PII, PHI, or cardholder data. **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary>Generic: Security-First Input Validation and Data Handling</summary> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent vulnerabilities **Status:** Passed > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td rowspan=1>🔴</td> <td><details> <summary>Generic: Meaningful Naming and Self-Documenting Code</summary> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code self-documenting **Status:** <a href='https://github.com/carverauto/serviceradar/pull/2245/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R407-R414'>Misleading target name</a>: The <code>deb-all-container</code> Makefile target name and description imply container support, but the updated commands no longer indicate container-related behavior, making the identifier misleading. <details open><summary>Referred Code</summary> ```txt .PHONY: deb-all-container deb-all-container: ## Build all Debian packages @echo "$(COLOR_BOLD)Building all Debian packages$(COLOR_RESET)" @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb agent @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb nats @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb kv @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb sync @VERSION=$(VERSION) ./scripts/setup-package.sh --type=deb dusk-checker ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2">   </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant 🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label </details>

qodo-code-review[bot] commented

2026-01-11 18:02:00 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2245#issuecomment-3735207687
Original created: 2026-01-11T18:02:00Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
High-level	Update root AGENTS.md documentation Update the `AGENTS.md` file to remove the reference to the legacy `web/` directory in the "Repository Layout" section. This change ensures the documentation accurately reflects the removal of the old UI. Solution Walkthrough: Before: # In AGENTS.md ## Repository Layout ... - `docs/`: Project documentation - `web/`: Legacy Next.js UI (deprecated) - `web-ng/`: Current Phoenix LiveView UI ... After: # In AGENTS.md ## Repository Layout ... - `docs/`: Project documentation - `web-ng/`: Current Phoenix LiveView UI ... Suggestion importance[1-10]: 7 __ Why: The suggestion identifies a relevant documentation file (`AGENTS.md`) likely missed during the cleanup, and updating it is crucial for maintaining consistency with the PR's goal of removing all legacy artifacts.	Medium
Possible issue	Add build prerequisite for agent Add `build-binaries` as a prerequisite to the `deb-agent` target. Makefile [358] `-deb-agent: ## Build the agent Debian package +deb-agent: build-binaries ## Build the agent Debian package` Apply / Chat Suggestion importance[1-10]: 7 __ Why: This is a valid suggestion that improves the robustness of the `Makefile` by explicitly declaring a dependency, preventing potential build failures if `deb-agent` is run in isolation.	Medium
More

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2245#issuecomment-3735207687 Original created: 2026-01-11T18:02:00Z --- ## PR Code Suggestions ✨  Explore these optional code suggestions: <table><thead><tr><td>Category</td><td align=left>Suggestion                                                                                                                                    </td><td align=center>Impact</td></tr><tbody><tr><td rowspan=1>High-level</td> <td> <details><summary>Update root AGENTS.md documentation</summary> ___ **Update the <code>AGENTS.md</code> file to remove the reference to the legacy <code>web/</code> directory in the "Repository Layout" section. This change ensures the documentation accurately reflects the removal of the old UI.** ### Solution Walkthrough: #### Before: ```pseudocode # In AGENTS.md ## Repository Layout ... - `docs/`: Project documentation - `web/`: Legacy Next.js UI (deprecated) - `web-ng/`: Current Phoenix LiveView UI ... ``` #### After: ```pseudocode # In AGENTS.md ## Repository Layout ... - `docs/`: Project documentation - `web-ng/`: Current Phoenix LiveView UI ... ``` <details><summary>Suggestion importance[1-10]: 7</summary> __ Why: The suggestion identifies a relevant documentation file (`AGENTS.md`) likely missed during the cleanup, and updating it is crucial for maintaining consistency with the PR's goal of removing all legacy artifacts. </details></details></td><td align=center>Medium </td></tr><tr><td rowspan=1>Possible issue</td> <td> <details><summary>Add build prerequisite for agent</summary> ___ **Add `build-binaries` as a prerequisite to the `deb-agent` target.** [Makefile [358]](https://github.com/carverauto/serviceradar/pull/2245/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R358-R358) ```diff -deb-agent: ## Build the agent Debian package +deb-agent: build-binaries ## Build the agent Debian package ``` - [ ] **Apply / Chat**  <details><summary>Suggestion importance[1-10]: 7</summary> __ Why: This is a valid suggestion that improves the robustness of the `Makefile` by explicitly declaring a dependency, preventing potential build failures if `deb-agent` is run in isolation. </details></details></td><td align=center>Medium </td></tr> <tr><td align="center" colspan="2"> - [ ] More  </td><td></td></tr></tbody></table>