carverauto/serviceradar

Fork 0

adding trigram extension and indices #2499

Merged

mfreeman451 merged 3 commits from refs/pull/2499/head into main

2025-12-03 06:08:25 +00:00

mfreeman451 commented

2025-12-03 06:00:17 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #2048
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/2048
Original created: 2025-12-03T06:00:17Z
Original updated: 2025-12-03T06:08:29Z
Original head: carverauto/serviceradar:2047-chorecnpg-enable-pg_trgm
Original base: main
Original merged: 2025-12-03T06:08:25Z by @mfreeman451

User description

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Issue ticket number and link

Code checklist before requesting a review

I have signed the DCO?
The build completes without errors?
All tests are passing when running make test?

PR Type

Enhancement

Description

Enable pg_trgm PostgreSQL extension for trigram-based text search optimization
Create GIN indexes on unified_devices hostname and ip columns
Add database migration files for extension and index management
Document performance characteristics and implementation requirements

Diagram Walkthrough

flowchart LR
  A["SRQL Query Engine<br/>ILIKE Queries"] -->|"Without Index"| B["Full Table Scan<br/>Performance Issue"]
  A -->|"With pg_trgm"| C["GIN Trigram Index<br/>Fast Pattern Matching"]
  D["Migration Up<br/>Enable Extension"] -->|"Creates"| C
  E["Migration Down<br/>Cleanup"] -->|"Removes"| C
  C -->|"Accelerates"| F["Wildcard Searches<br/>e.g., %server%"]

File Walkthrough

Relevant files

Documentation

proposal.md `Proposal for pg_trgm extension and trigram index implementation` openspec/changes/add-cnpg-pg-trgm-extension/proposal.md Explains rationale for pg_trgm extension to optimize ILIKE queries with leading wildcards Details scope including migration creation and GIN index placement on unified_devices Documents performance trade-offs: marginally slower writes, significantly faster reads Specifies storage overhead of 1-3x column data size per trigram index	+28/-0
spec.md `CNPG spec requirements for pg_trgm extension and indexes` openspec/changes/add-cnpg-pg-trgm-extension/specs/cnpg/spec.md Modifies requirement to include pg_trgm in CNPG Postgres image alongside TimescaleDB and Apache AGE Adds scenarios validating pg_trgm extension loading and GIN index creation Adds scenarios confirming ILIKE queries use trigram indexes via EXPLAIN ANALYZE Adds requirement for migration files to enable extension and create indexes with down migration cleanup	+42/-0
tasks.md `Implementation tasks for pg_trgm extension rollout` openspec/changes/add-cnpg-pg-trgm-extension/tasks.md Defines task checklist for enabling pg_trgm extension with migration files Specifies creation of GIN trigram indexes on unified_devices hostname and ip columns Includes validation tasks for index creation and EXPLAIN ANALYZE verification Notes future evaluation of additional high-traffic columns for indexing	+22/-0

Configuration changes

00000000000016_pg_trgm_extension.up.sql

Migration to enable pg_trgm and create trigram indexes

pkg/db/cnpg/migrations/00000000000016_pg_trgm_extension.up.sql

Creates pg_trgm extension with IF NOT EXISTS clause for idempotency
Creates GIN trigram index on unified_devices.hostname for device
lookup optimization
Creates GIN trigram index on unified_devices.ip for IP pattern search
optimization
Uses CONCURRENTLY flag to avoid locking during index creation

+15/-0

00000000000016_pg_trgm_extension.down.sql

Rollback migration for pg_trgm extension removal

pkg/db/cnpg/migrations/00000000000016_pg_trgm_extension.down.sql

Drops trigram indexes on unified_devices hostname and ip columns
Removes pg_trgm extension with IF EXISTS clause for safe rollback
Uses CONCURRENTLY flag for non-blocking index removal

+6/-0

Imported from GitHub pull request. Original GitHub pull request: #2048 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/2048 Original created: 2025-12-03T06:00:17Z Original updated: 2025-12-03T06:08:29Z Original head: carverauto/serviceradar:2047-chorecnpg-enable-pg_trgm Original base: main Original merged: 2025-12-03T06:08:25Z by @mfreeman451 --- ### **User description** ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test? ___ ### **PR Type** Enhancement ___ ### **Description** - Enable pg_trgm PostgreSQL extension for trigram-based text search optimization - Create GIN indexes on unified_devices hostname and ip columns - Add database migration files for extension and index management - Document performance characteristics and implementation requirements ___ ### Diagram Walkthrough ```mermaid flowchart LR A["SRQL Query Engine<br/>ILIKE Queries"] -->|"Without Index"| B["Full Table Scan<br/>Performance Issue"] A -->|"With pg_trgm"| C["GIN Trigram Index<br/>Fast Pattern Matching"] D["Migration Up<br/>Enable Extension"] -->|"Creates"| C E["Migration Down<br/>Cleanup"] -->|"Removes"| C C -->|"Accelerates"| F["Wildcard Searches<br/>e.g., %server%"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>proposal.md</strong><dd><code>Proposal for pg_trgm extension and trigram index implementation</code></dd></summary> <hr> openspec/changes/add-cnpg-pg-trgm-extension/proposal.md <ul><li>Explains rationale for pg_trgm extension to optimize ILIKE queries <br>with leading wildcards<br> <li> Details scope including migration creation and GIN index placement on <br>unified_devices<br> <li> Documents performance trade-offs: marginally slower writes, <br>significantly faster reads<br> <li> Specifies storage overhead of 1-3x column data size per trigram index</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2048/files#diff-d6268051144d50da6e9519dafeb22369b72897970e28dc6be76f1932e081f05a">+28/-0</a>    </td> </tr> <tr> <td> <details> <summary><strong>spec.md</strong><dd><code>CNPG spec requirements for pg_trgm extension and indexes</code>  </dd></summary> <hr> openspec/changes/add-cnpg-pg-trgm-extension/specs/cnpg/spec.md <ul><li>Modifies requirement to include pg_trgm in CNPG Postgres image <br>alongside TimescaleDB and Apache AGE<br> <li> Adds scenarios validating pg_trgm extension loading and GIN index <br>creation<br> <li> Adds scenarios confirming ILIKE queries use trigram indexes via <br>EXPLAIN ANALYZE<br> <li> Adds requirement for migration files to enable extension and create <br>indexes with down migration cleanup</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2048/files#diff-e9b364f2fee6653d8a3a76645f84b9112fe28e3588127d7f85f0c6e706f4744e">+42/-0</a>    </td> </tr> <tr> <td> <details> <summary><strong>tasks.md</strong><dd><code>Implementation tasks for pg_trgm extension rollout</code>              </dd></summary> <hr> openspec/changes/add-cnpg-pg-trgm-extension/tasks.md <ul><li>Defines task checklist for enabling pg_trgm extension with migration <br>files<br> <li> Specifies creation of GIN trigram indexes on unified_devices hostname <br>and ip columns<br> <li> Includes validation tasks for index creation and EXPLAIN ANALYZE <br>verification<br> <li> Notes future evaluation of additional high-traffic columns for <br>indexing</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2048/files#diff-a99958042a169266448dd3d85aea9183372d5646189460ecf91651ba72b5a0a8">+22/-0</a>    </td> </tr> </table></td></tr><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>00000000000016_pg_trgm_extension.up.sql</strong><dd><code>Migration to enable pg_trgm and create trigram indexes</code>      </dd></summary> <hr> pkg/db/cnpg/migrations/00000000000016_pg_trgm_extension.up.sql <ul><li>Creates pg_trgm extension with IF NOT EXISTS clause for idempotency<br> <li> Creates GIN trigram index on unified_devices.hostname for device <br>lookup optimization<br> <li> Creates GIN trigram index on unified_devices.ip for IP pattern search <br>optimization<br> <li> Uses CONCURRENTLY flag to avoid locking during index creation</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2048/files#diff-2ef7d7749ef3416960d35d8c6aaf67a802fba0720e2473e030f97a0b7c2b77a4">+15/-0</a>    </td> </tr> <tr> <td> <details> <summary><strong>00000000000016_pg_trgm_extension.down.sql</strong><dd><code>Rollback migration for pg_trgm extension removal</code>                  </dd></summary> <hr> pkg/db/cnpg/migrations/00000000000016_pg_trgm_extension.down.sql <ul><li>Drops trigram indexes on unified_devices hostname and ip columns<br> <li> Removes pg_trgm extension with IF EXISTS clause for safe rollback<br> <li> Uses CONCURRENTLY flag for non-blocking index removal</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/2048/files#diff-08e2f3769e8cf0da0bb529a62eda80977fd0350b4712858d7b3b3d4ee2091a0a">+6/-0</a>      </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-12-03 06:01:20 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2048#issuecomment-3605229903
Original created: 2025-12-03T06:01:20Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance

🟢

No security concerns identified

No security vulnerabilities detected by AI analysis. Human verification advised for critical code.

Ticket Compliance

🟡

🎫 #2047

🟢	Enable the pg_trgm Postgres extension to optimize ILIKE queries used across the codebase.
	Create appropriate trigram-based GIN/GiST indexes on searchable text columns so ILIKE queries (including leading wildcards) avoid full table scans.
	At minimum, cover frequently searched columns mentioned in unified_devices (e.g., hostname; ip if applicable) with trigram indexes.
	Implement via CNPG database migrations with up/down scripts to manage extension and indexes.
	Document performance trade-offs and implementation in specs/docs.
⚪	Verify at runtime that EXPLAIN plans for representative ILIKE queries use Bitmap Index Scan on the new trigram indexes in real environments.
	Confirm the CNPG Postgres image actually bundles pg_trgm alongside other required extensions in deployed clusters.
	Assess write performance impact and storage overhead in production-scale datasets.

Codebase Duplication Compliance

⚪

Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance

🟢

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

⚪

Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status:
Missing audit logs: The migration enables an extension and creates indexes without any accompanying audit
logging or recorded context of who performed these critical database changes.

Referred Code

CREATE EXTENSION IF NOT EXISTS pg_trgm;

-- Create GIN trigram indexes on frequently searched text columns in unified_devices
-- These indexes enable fast ILIKE/LIKE queries without requiring sequential scans

-- Index on hostname - primary search target for device lookups
CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_hostname_trgm
    ON unified_devices USING gin (hostname gin_trgm_ops);

-- Index on ip - commonly used for searching devices by IP pattern
CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_ip_trgm
    ON unified_devices USING gin (ip gin_trgm_ops);

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status:
No failure handling: SQL migration statements execute without explicit error handling or safeguards for
concurrent environments beyond IF NOT EXISTS, which may require additional operational
handling not visible in the diff.

Referred Code

CREATE EXTENSION IF NOT EXISTS pg_trgm;

-- Create GIN trigram indexes on frequently searched text columns in unified_devices
-- These indexes enable fast ILIKE/LIKE queries without requiring sequential scans

-- Index on hostname - primary search target for device lookups
CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_hostname_trgm
    ON unified_devices USING gin (hostname gin_trgm_ops);

-- Index on ip - commonly used for searching devices by IP pattern
CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_ip_trgm
    ON unified_devices USING gin (ip gin_trgm_ops);

Learn more about managing compliance generic rules or creating your own custom rules

Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2048#issuecomment-3605229903 Original created: 2025-12-03T06:01:20Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>🟡</td> <td> <details> <summary>🎫 <a href=https://github.com/carverauto/serviceradar/issues/2047>#2047</a></summary> <table width='100%'><tbody> <tr><td rowspan=5>🟢</td> <td>Enable the pg_trgm Postgres extension to optimize ILIKE queries used across the codebase.</td></tr> <tr><td>Create appropriate trigram-based GIN/GiST indexes on searchable text columns so ILIKE <br>queries (including leading wildcards) avoid full table scans.</td></tr> <tr><td>At minimum, cover frequently searched columns mentioned in unified_devices (e.g., <br>hostname; ip if applicable) with trigram indexes.</td></tr> <tr><td>Implement via CNPG database migrations with up/down scripts to manage extension and <br>indexes.</td></tr> <tr><td>Document performance trade-offs and implementation in specs/docs.</td></tr> <tr><td rowspan=3>⚪</td> <td>Verify at runtime that EXPLAIN plans for representative ILIKE queries use Bitmap Index <br>Scan on the new trigram indexes in real environments.</td></tr> <tr><td>Confirm the CNPG Postgres image actually bundles pg_trgm alongside other required <br>extensions in deployed clusters.</td></tr> <tr><td>Assess write performance impact and storage overhead in production-scale datasets.</td></tr> </tbody></table> </details> </td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td rowspan=4>🟢</td><td> <details><summary><strong>Generic: Meaningful Naming and Self-Documenting Code</strong></summary><br> **Objective:** Ensure all identifiers clearly express their purpose and intent, making code <br>self-documenting<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Error Handling</strong></summary><br> **Objective:** To prevent the leakage of sensitive system information through error messages while <br>providing sufficient detail for internal debugging.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Secure Logging Practices</strong></summary><br> **Objective:** To ensure logs are useful for debugging and auditing without exposing sensitive <br>information like PII, PHI, or cardholder data.<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td> <details><summary><strong>Generic: Security-First Input Validation and Data Handling</strong></summary><br> **Objective:** Ensure all data inputs are validated, sanitized, and handled securely to prevent <br>vulnerabilities<br> **Status:** Passed<br> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td rowspan=2>⚪</td> <td><details> <summary><strong>Generic: Comprehensive Audit Trails</strong></summary><br> **Objective:** To create a detailed and reliable record of critical system actions for security analysis <br>and compliance.<br> **Status:** <br><a href='https://github.com/carverauto/serviceradar/pull/2048/files#diff-2ef7d7749ef3416960d35d8c6aaf67a802fba0720e2473e030f97a0b7c2b77a4R4-R15'><strong>Missing audit logs</strong></a>: The migration enables an extension and creates indexes without any accompanying audit <br>logging or recorded context of who performed these critical database changes.<br> <details open><summary>Referred Code</summary> ```sql CREATE EXTENSION IF NOT EXISTS pg_trgm; -- Create GIN trigram indexes on frequently searched text columns in unified_devices -- These indexes enable fast ILIKE/LIKE queries without requiring sequential scans -- Index on hostname - primary search target for device lookups CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_hostname_trgm ON unified_devices USING gin (hostname gin_trgm_ops); -- Index on ip - commonly used for searching devices by IP pattern CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_ip_trgm ON unified_devices USING gin (ip gin_trgm_ops); ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td><details> <summary><strong>Generic: Robust Error Handling and Edge Case Management</strong></summary><br> **Objective:** Ensure comprehensive error handling that provides meaningful context and graceful <br>degradation<br> **Status:** <br><a href='https://github.com/carverauto/serviceradar/pull/2048/files#diff-2ef7d7749ef3416960d35d8c6aaf67a802fba0720e2473e030f97a0b7c2b77a4R4-R15'><strong>No failure handling</strong></a>: SQL migration statements execute without explicit error handling or safeguards for <br>concurrent environments beyond IF NOT EXISTS, which may require additional operational <br>handling not visible in the diff.<br> <details open><summary>Referred Code</summary> ```sql CREATE EXTENSION IF NOT EXISTS pg_trgm; -- Create GIN trigram indexes on frequently searched text columns in unified_devices -- These indexes enable fast ILIKE/LIKE queries without requiring sequential scans -- Index on hostname - primary search target for device lookups CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_hostname_trgm ON unified_devices USING gin (hostname gin_trgm_ops); -- Index on ip - commonly used for searching devices by IP pattern CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_ip_trgm ON unified_devices USING gin (ip gin_trgm_ops); ``` </details> > Learn more about managing compliance <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#configuration-options'>generic rules</a> or creating your own <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/#custom-compliance'>custom rules</a> </details></td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2025-12-03 06:02:10 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/2048#issuecomment-3605231940
Original created: 2025-12-03T06:02:10Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix migration failure in transactions Remove the `CONCURRENTLY` keyword from `CREATE INDEX` statements to prevent migration failures within transaction blocks, or configure the migration runner to execute this migration outside a transaction. pkg/db/cnpg/migrations/00000000000016_pg_trgm_extension.up.sql [10-15] `-CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_hostname_trgm +CREATE INDEX IF NOT EXISTS idx_unified_devices_hostname_trgm ON unified_devices USING gin (hostname gin_trgm_ops); -- Index on ip - commonly used for searching devices by IP pattern -CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_ip_trgm +CREATE INDEX IF NOT EXISTS idx_unified_devices_ip_trgm ON unified_devices USING gin (ip gin_trgm_ops);` Apply / Chat Suggestion importance[1-10]: 9 __ Why: The suggestion correctly identifies a critical issue where `CREATE INDEX CONCURRENTLY` will fail inside a transaction block, which is a common default for migration tools, thus preventing the migration from succeeding.	High
Update

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/2048#issuecomment-3605231940 Original created: 2025-12-03T06:02:10Z --- ## PR Code Suggestions ✨  Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>Possible issue</td> <td> <details><summary>Fix migration failure in transactions</summary> ___ **Remove the <code>CONCURRENTLY</code> keyword from <code>CREATE INDEX</code> statements to prevent <br>migration failures within transaction blocks, or configure the migration runner <br>to execute this migration outside a transaction.** [pkg/db/cnpg/migrations/00000000000016_pg_trgm_extension.up.sql [10-15]](https://github.com/carverauto/serviceradar/pull/2048/files#diff-2ef7d7749ef3416960d35d8c6aaf67a802fba0720e2473e030f97a0b7c2b77a4R10-R15) ```diff -CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_hostname_trgm +CREATE INDEX IF NOT EXISTS idx_unified_devices_hostname_trgm ON unified_devices USING gin (hostname gin_trgm_ops); -- Index on ip - commonly used for searching devices by IP pattern -CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_unified_devices_ip_trgm +CREATE INDEX IF NOT EXISTS idx_unified_devices_ip_trgm ON unified_devices USING gin (ip gin_trgm_ops); ``` - [ ] **Apply / Chat**  <details><summary>Suggestion importance[1-10]: 9</summary> __ Why: The suggestion correctly identifies a critical issue where `CREATE INDEX CONCURRENTLY` will fail inside a transaction block, which is a common default for migration tools, thus preventing the migration from succeeding. </details></details></td><td align=center>High </td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td><td></td></tr></tbody></table>