fixing service selection #2381

Merged
mfreeman451 merged 4 commits from refs/pull/2381/head into main 2025-10-24 05:23:36 +00:00
mfreeman451 commented 2025-10-24 04:42:43 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #1876
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1876
Original created: 2025-10-24T04:42:43Z
Original updated: 2025-10-24T05:23:39Z
Original head: carverauto/serviceradar:1844-bugui-observabilitylogs-no-longer-lets-you-select-a-service
Original base: main
Original merged: 2025-10-24T05:23:36Z by @mfreeman451

IMPORTANT: Please sign the Developer Certificate of Origin

Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:

Signed-off-by: J. Doe <j.doe@domain.com>

Describe your changes

Code checklist before requesting a review

  • I have signed the DCO?
  • The build completes without errors?
  • All tests are passing when running make test?
Imported from GitHub pull request. Original GitHub pull request: #1876 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1876 Original created: 2025-10-24T04:42:43Z Original updated: 2025-10-24T05:23:39Z Original head: carverauto/serviceradar:1844-bugui-observabilitylogs-no-longer-lets-you-select-a-service Original base: main Original merged: 2025-10-24T05:23:36Z by @mfreeman451 --- ## IMPORTANT: Please sign the Developer Certificate of Origin Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include a [DCO sign-off statement]( https://developercertificate.org/) indicating the DCO acceptance in one commit message. Here is an example DCO Signed-off-by line in a commit message: ``` Signed-off-by: J. Doe <j.doe@domain.com> ``` ## Describe your changes ## Issue ticket number and link ## Code checklist before requesting a review - [ ] I have signed the DCO? - [ ] The build completes without errors? - [ ] All tests are passing when running make test?
mfreeman451 commented 2025-10-24 05:07:14 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1876#discussion_r2458913680
Original created: 2025-10-24T05:07:14Z
Original path: web/src/utils/logServiceOptions.ts
Original line: 18

ssh should just map to the agent

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1876#discussion_r2458913680 Original created: 2025-10-24T05:07:14Z Original path: web/src/utils/logServiceOptions.ts Original line: 18 --- ssh should just map to the agent
mfreeman451 commented 2025-10-24 05:07:27 +00:00 (Migrated from github.com)
Author
Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1876#discussion_r2458913942
Original created: 2025-10-24T05:07:27Z
Original path: web/src/utils/logServiceOptions.ts
Original line: 17

ping should map to the agent

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1876#discussion_r2458913942 Original created: 2025-10-24T05:07:27Z Original path: web/src/utils/logServiceOptions.ts Original line: 17 --- ping should map to the agent
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!2381
No description provided.