carverauto/serviceradar

Fork 0

adding srql and kong #2277

Merged

mfreeman451 merged 3 commits from refs/pull/2277/head into main

2025-10-05 17:57:22 +00:00

mfreeman451 commented

2025-10-05 17:47:58 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1705
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1705
Original created: 2025-10-05T17:47:58Z
Original updated: 2025-10-05T17:57:27Z
Original head: carverauto/serviceradar:k8s/missing_kong
Original base: main
Original merged: 2025-10-05T17:57:22Z by @mfreeman451

PR Type

Enhancement

Description

Add Kong API gateway service to Kubernetes deployment
Add SRQL service to the service mesh
Update ingress routing to use Kong gateway
Create service aliases for new components

Diagram Walkthrough

flowchart LR
  Client["Client Requests"] --> Kong["Kong Gateway"]
  Kong --> Core["ServiceRadar Core"]
  Kong --> SRQL["SRQL Service"]
  Core --> Backend["Backend Services"]

File Walkthrough

Relevant files

Configuration changes

kustomization.yaml `Add Kong and SRQL resources` k8s/demo/base/kustomization.yaml Add `serviceradar-kong.yaml` resource to kustomization Add `serviceradar-srql.yaml` resource to kustomization	+2/-0
ingress.yaml `Update ingress routing to Kong gateway` k8s/demo/prod/ingress.yaml Route `/api/stream` endpoint to `serviceradar-kong` service on port 8000 Route `/api` prefix to `serviceradar-kong` service instead of core service	+4/-4
service-aliases.demo.yaml `Add service aliases for Kong and SRQL` k8s/demo/prod/service-aliases.demo.yaml Add `kong` service alias pointing to `serviceradar-kong.demo.svc.cluster.local` Add `srql` service alias pointing to `serviceradar-srql.demo.svc.cluster.local`	+18/-0

Imported from GitHub pull request. Original GitHub pull request: #1705 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1705 Original created: 2025-10-05T17:47:58Z Original updated: 2025-10-05T17:57:27Z Original head: carverauto/serviceradar:k8s/missing_kong Original base: main Original merged: 2025-10-05T17:57:22Z by @mfreeman451 --- ### **PR Type** Enhancement ___ ### **Description** - Add Kong API gateway service to Kubernetes deployment - Add SRQL service to the service mesh - Update ingress routing to use Kong gateway - Create service aliases for new components ___ ### Diagram Walkthrough ```mermaid flowchart LR Client["Client Requests"] --> Kong["Kong Gateway"] Kong --> Core["ServiceRadar Core"] Kong --> SRQL["SRQL Service"] Core --> Backend["Backend Services"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>kustomization.yaml</strong><dd><code>Add Kong and SRQL resources</code>                                                            </dd></summary> <hr> k8s/demo/base/kustomization.yaml <ul><li>Add <code>serviceradar-kong.yaml</code> resource to kustomization<br> <li> Add <code>serviceradar-srql.yaml</code> resource to kustomization</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1705/files#diff-c4260176971b950ef1b967a2631b446225071906172f56287c465ad2e29788d9">+2/-0</a>      </td> </tr> <tr> <td> <details> <summary><strong>ingress.yaml</strong><dd><code>Update ingress routing to Kong gateway</code>                                      </dd></summary> <hr> k8s/demo/prod/ingress.yaml <ul><li>Route <code>/api/stream</code> endpoint to <code>serviceradar-kong</code> service on port 8000<br> <li> Route <code>/api</code> prefix to <code>serviceradar-kong</code> service instead of core service</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1705/files#diff-d96e18b44fecc10112cc02dc42b8deeba6aaed070dfd88771921e228465d4257">+4/-4</a>      </td> </tr> <tr> <td> <details> <summary><strong>service-aliases.demo.yaml</strong><dd><code>Add service aliases for Kong and SRQL</code>                                        </dd></summary> <hr> k8s/demo/prod/service-aliases.demo.yaml <ul><li>Add <code>kong</code> service alias pointing to <br><code>serviceradar-kong.demo.svc.cluster.local</code><br> <li> Add <code>srql</code> service alias pointing to <br><code>serviceradar-srql.demo.svc.cluster.local</code></ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1705/files#diff-2a652ee3803d2decc7bf62439ee5712d719b72ebbf146d2a02093d4c06638f13">+18/-0</a>    </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-10-05 17:48:18 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1705#issuecomment-3369214556
Original created: 2025-10-05T17:48:18Z

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢	No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪	🎫 No ticket provided Create ticket/issue
Codebase Duplication Compliance
⚪	Codebase context is not defined Follow the guide to enable codebase context checks.
Custom Compliance
⚪	No custom compliance provided Follow the guide to enable custom compliance check.
Update

Compliance status legend

🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1705#issuecomment-3369214556 Original created: 2025-10-05T17:48:18Z --- ## PR Compliance Guide 🔍  Below is a summary of compliance checks for this PR:<br> <table><tbody><tr><td colspan='2'><strong>Security Compliance</strong></td></tr> <tr><td>🟢</td><td><details><summary><strong>No security concerns identified</strong></summary> No security vulnerabilities detected by AI analysis. Human verification advised for critical code. </details></td></tr> <tr><td colspan='2'><strong>Ticket Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary>🎫 <strong>No ticket provided </summary></strong> - [ ] Create ticket/issue  </details></td></tr> <tr><td colspan='2'><strong>Codebase Duplication Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>Codebase context is not defined </strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/core-abilities/rag_context_enrichment/'>guide</a> to enable codebase context checks. </details></td></tr> <tr><td colspan='2'><strong>Custom Compliance</strong></td></tr> <tr><td>⚪</td><td><details><summary><strong>No custom compliance provided</strong></summary> Follow the <a href='https://qodo-merge-docs.qodo.ai/tools/compliance/'>guide</a> to enable custom compliance check. </details></td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td></tr></tbody></table> <details><summary>Compliance status legend</summary> 🟢 - Fully Compliant<br> 🟡 - Partial Compliant<br> 🔴 - Not Compliant<br> ⚪ - Requires Further Human Verification<br> 🏷️ - Compliance label<br> </details>

qodo-code-review[bot] commented

2025-10-05 17:49:00 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1705#issuecomment-3369214947
Original created: 2025-10-05T17:49:00Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category Suggestion Impact

High-level

Category	Suggestion	Impact
High-level	Include missing service definition files The PR is missing the Kubernetes manifest files, `serviceradar-kong.yaml` and `serviceradar-srql.yaml`, which define the new services. These files should be added to the PR to allow for a complete review. Examples: k8s/demo/base/kustomization.yaml [22-23] `- serviceradar-kong.yaml - serviceradar-srql.yaml` Solution Walkthrough: Before: `# k8s/demo/base/kustomization.yaml resources: ... - serviceradar-tools.yaml - serviceradar-kong.yaml # Referenced but file is missing - serviceradar-srql.yaml # Referenced but file is missing - serviceradar-sync.yaml ... # k8s/demo/prod/ingress.yaml ... - path: /api backend: service: name: serviceradar-kong # Service definition is missing port: number: 8000` After: `# k8s/demo/base/kustomization.yaml resources: ... - serviceradar-tools.yaml - serviceradar-kong.yaml # File is now present - serviceradar-srql.yaml # File is now present - serviceradar-sync.yaml ... # k8s/demo/base/serviceradar-kong.yaml (New file) apiVersion: apps/v1 kind: Deployment metadata: name: serviceradar-kong spec: # ... Kong deployment configuration --- apiVersion: v1 kind: Service metadata: name: serviceradar-kong spec: # ... Kong service configuration` Suggestion importance[1-10]: 10 __ Why: The suggestion correctly identifies a critical omission of the core Kubernetes manifest files (`serviceradar-kong.yaml`, `serviceradar-srql.yaml`), which makes the PR incomplete and unreviewable.	High
Update

Include missing service definition files

The PR is missing the Kubernetes manifest files, serviceradar-kong.yaml and
serviceradar-srql.yaml, which define the new services. These files should be
added to the PR to allow for a complete review.

Examples:

k8s/demo/base/kustomization.yaml [22-23]

- serviceradar-kong.yaml
- serviceradar-srql.yaml

Solution Walkthrough:

Before:

# k8s/demo/base/kustomization.yaml
resources:
  ...
  - serviceradar-tools.yaml
  - serviceradar-kong.yaml  # Referenced but file is missing
  - serviceradar-srql.yaml  # Referenced but file is missing
  - serviceradar-sync.yaml
  ...

# k8s/demo/prod/ingress.yaml
...
  - path: /api
    backend:
      service:
        name: serviceradar-kong # Service definition is missing
        port:
          number: 8000

After:

# k8s/demo/base/kustomization.yaml
resources:
  ...
  - serviceradar-tools.yaml
  - serviceradar-kong.yaml  # File is now present
  - serviceradar-srql.yaml  # File is now present
  - serviceradar-sync.yaml
  ...

# k8s/demo/base/serviceradar-kong.yaml (New file)
apiVersion: apps/v1
kind: Deployment
metadata:
  name: serviceradar-kong
spec:
  # ... Kong deployment configuration
---
apiVersion: v1
kind: Service
metadata:
  name: serviceradar-kong
spec:
  # ... Kong service configuration

Suggestion importance[1-10]: 10

Why: The suggestion correctly identifies a critical omission of the core Kubernetes manifest files (serviceradar-kong.yaml, serviceradar-srql.yaml), which makes the PR incomplete and unreviewable.

High

Update

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1705#issuecomment-3369214947 Original created: 2025-10-05T17:49:00Z --- ## PR Code Suggestions ✨  Explore these optional code suggestions: <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>High-level</td> <td> <details><summary>Include missing service definition files</summary> ___ **The PR is missing the Kubernetes manifest files, <code>serviceradar-kong.yaml</code> and <br><code>serviceradar-srql.yaml</code>, which define the new services. These files should be <br>added to the PR to allow for a complete review.** ### Examples: <details> <summary> <a href="https://github.com/carverauto/serviceradar/pull/1705/files#diff-c4260176971b950ef1b967a2631b446225071906172f56287c465ad2e29788d9R22-R23">k8s/demo/base/kustomization.yaml [22-23]</a> </summary> ```yaml - serviceradar-kong.yaml - serviceradar-srql.yaml ``` </details> ### Solution Walkthrough: #### Before: ```yaml # k8s/demo/base/kustomization.yaml resources: ... - serviceradar-tools.yaml - serviceradar-kong.yaml # Referenced but file is missing - serviceradar-srql.yaml # Referenced but file is missing - serviceradar-sync.yaml ... # k8s/demo/prod/ingress.yaml ... - path: /api backend: service: name: serviceradar-kong # Service definition is missing port: number: 8000 ``` #### After: ```yaml # k8s/demo/base/kustomization.yaml resources: ... - serviceradar-tools.yaml - serviceradar-kong.yaml # File is now present - serviceradar-srql.yaml # File is now present - serviceradar-sync.yaml ... # k8s/demo/base/serviceradar-kong.yaml (New file) apiVersion: apps/v1 kind: Deployment metadata: name: serviceradar-kong spec: # ... Kong deployment configuration --- apiVersion: v1 kind: Service metadata: name: serviceradar-kong spec: # ... Kong service configuration ``` <details><summary>Suggestion importance[1-10]: 10</summary> __ Why: The suggestion correctly identifies a critical omission of the core Kubernetes manifest files (`serviceradar-kong.yaml`, `serviceradar-srql.yaml`), which makes the PR incomplete and unreviewable. </details></details></td><td align=center>High </td></tr> <tr><td align="center" colspan="2"> - [ ] Update  </td><td></td></tr></tbody></table>