flowgger fix #2244

Merged

mfreeman451 merged 1 commit from refs/pull/2244/head into main

2025-09-28 21:14:52 +00:00

mfreeman451 commented

2025-09-28 21:14:25 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1664
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1664
Original created: 2025-09-28T21:14:25Z
Original updated: 2025-09-28T21:15:18Z
Original head: carverauto/serviceradar:update/flowgger_build_error
Original base: main
Original merged: 2025-09-28T21:14:52Z by @mfreeman451

PR Type

Bug fix

Description

Add missing build dependencies for Flowgger RPM build
Include perl and pkgconf-pkg-config packages to fix compilation

Diagram Walkthrough

flowchart LR
  A["Build Dependencies"] --> B["Add perl package"]
  A --> C["Add pkgconf-pkg-config"]
  B --> D["Fix OpenSSL configure"]
  C --> D
  D --> E["Successful RPM Build"]

File Walkthrough

Relevant files

Bug fix

Dockerfile.rpm.rust.flowgger

Add missing build dependencies

docker/rpm/Dockerfile.rpm.rust.flowgger

Add perl package for OpenSSL configure script
Add pkgconf-pkg-config for build configuration
Update comment to reflect new dependencies

+2/-2

Imported from GitHub pull request. Original GitHub pull request: #1664 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1664 Original created: 2025-09-28T21:14:25Z Original updated: 2025-09-28T21:15:18Z Original head: carverauto/serviceradar:update/flowgger_build_error Original base: main Original merged: 2025-09-28T21:14:52Z by @mfreeman451 --- ### **PR Type** Bug fix ___ ### **Description** - Add missing build dependencies for Flowgger RPM build - Include perl and pkgconf-pkg-config packages to fix compilation ___ ### Diagram Walkthrough ```mermaid flowchart LR A["Build Dependencies"] --> B["Add perl package"] A --> C["Add pkgconf-pkg-config"] B --> D["Fix OpenSSL configure"] C --> D D --> E["Successful RPM Build"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix</strong></td><td><table> <tr> <td> <details> <summary><strong>Dockerfile.rpm.rust.flowgger</strong><dd><code>Add missing build dependencies</code>                                                      </dd></summary> <hr> docker/rpm/Dockerfile.rpm.rust.flowgger <ul><li>Add <code>perl</code> package for OpenSSL configure script<br> <li> Add <code>pkgconf-pkg-config</code> for build configuration<br> <li> Update comment to reflect new dependencies</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1664/files#diff-6ae2da8fc631ae1a5b25905220b538bf5171e75564f8abc8843ae0b4a016a14a">+2/-2</a>      </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-09-28 21:14:43 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1664#issuecomment-3344261846
Original created: 2025-09-28T21:14:43Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Deterministic Builds

Consider pinning package versions or enabling dnf -y install --setopt=install_weak_deps=False and using a specific repo snapshot to avoid non-reproducible builds caused by rolling dependencies.

# Install build dependencies (openssl + protoc + perl for OpenSSL configure script)
RUN dnf install -y openssl-devel protobuf-compiler perl pkgconf-pkg-config && \
    echo "OpenSSL development libraries installed successfully" && \
    dnf clean all && \
    echo "DNF cache cleaned"

Layer Optimization

Combine echo/clean steps or order commands to minimize layers and leverage caching; also consider --nodocs to reduce image size during dependency install.

# Install build dependencies (openssl + protoc + perl for OpenSSL configure script)
RUN dnf install -y openssl-devel protobuf-compiler perl pkgconf-pkg-config && \
    echo "OpenSSL development libraries installed successfully" && \
    dnf clean all && \
    echo "DNF cache cleaned"

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1664#issuecomment-3344261846 Original created: 2025-09-28T21:14:43Z --- ## PR Reviewer Guide 🔍 Here are some key observations to aid the review process: <table> <tr><td>⏱️ <strong>Estimated effort to review</strong>: 1 🔵⚪⚪⚪⚪</td></tr> <tr><td>🧪 <strong>No relevant tests</strong></td></tr> <tr><td>🔒 <strong>No security concerns identified</strong></td></tr> <tr><td>⚡ <strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://github.com/carverauto/serviceradar/pull/1664/files#diff-6ae2da8fc631ae1a5b25905220b538bf5171e75564f8abc8843ae0b4a016a14aR20-R24'><strong>Deterministic Builds</strong></a> Consider pinning package versions or enabling `dnf -y install --setopt=install_weak_deps=False` and using a specific repo snapshot to avoid non-reproducible builds caused by rolling dependencies. </summary> ```txt # Install build dependencies (openssl + protoc + perl for OpenSSL configure script) RUN dnf install -y openssl-devel protobuf-compiler perl pkgconf-pkg-config && \ echo "OpenSSL development libraries installed successfully" && \ dnf clean all && \ echo "DNF cache cleaned" ``` </details> <details><summary><a href='https://github.com/carverauto/serviceradar/pull/1664/files#diff-6ae2da8fc631ae1a5b25905220b538bf5171e75564f8abc8843ae0b4a016a14aR20-R24'><strong>Layer Optimization</strong></a> Combine echo/clean steps or order commands to minimize layers and leverage caching; also consider `--nodocs` to reduce image size during dependency install. </summary> ```txt # Install build dependencies (openssl + protoc + perl for OpenSSL configure script) RUN dnf install -y openssl-devel protobuf-compiler perl pkgconf-pkg-config && \ echo "OpenSSL development libraries installed successfully" && \ dnf clean all && \ echo "DNF cache cleaned" ``` </details> </td></tr> </table>

qodo-code-review[bot] commented

2025-09-28 21:15:18 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1664#issuecomment-3344262167
Original created: 2025-09-28T21:15:18Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1664#issuecomment-3344262167 Original created: 2025-09-28T21:15:18Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.