cleanup #2235

Merged

mfreeman451 merged 1 commit from refs/pull/2235/head into main

2025-09-23 16:57:47 +00:00

mfreeman451 commented

2025-09-23 16:57:39 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1655
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1655
Original created: 2025-09-23T16:57:39Z
Original updated: 2025-09-23T16:58:07Z
Original head: carverauto/serviceradar:bazel/build_issues
Original base: main
Original merged: 2025-09-23T16:57:47Z by @mfreeman451

PR Type

Other

Description

Remove unused Bazel load statements for os and cpu
Add missing newline at end of file

File Walkthrough

Relevant files

Formatting

BUILD.bazel

Remove unused imports and fix formatting

platforms/BUILD.bazel

Removed unused load statements for @platforms//os:os.bzl and
@platforms//cpu:cpu.bzl
Added missing newline at end of file

+1/-4

Imported from GitHub pull request. Original GitHub pull request: #1655 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1655 Original created: 2025-09-23T16:57:39Z Original updated: 2025-09-23T16:58:07Z Original head: carverauto/serviceradar:bazel/build_issues Original base: main Original merged: 2025-09-23T16:57:47Z by @mfreeman451 --- ### **PR Type** Other ___ ### **Description** - Remove unused Bazel load statements for os and cpu - Add missing newline at end of file ___ <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Formatting</strong></td><td><table> <tr> <td> <details> <summary><strong>BUILD.bazel</strong><dd><code>Remove unused imports and fix formatting</code>                                  </dd></summary> <hr> platforms/BUILD.bazel <ul><li>Removed unused load statements for @platforms//os:os.bzl and <br>@platforms//cpu:cpu.bzl<br> <li> Added missing newline at end of file</ul> </details> </td> <td><a href="https://github.com/carverauto/serviceradar/pull/1655/files#diff-e7aed8c1f0aa84f04005b98a61f13eae1bad9bfc0f13dc02afde9f62961193e2">+1/-4</a>      </td> </tr> </table></td></tr></tr></tbody></table> </details> ___

qodo-code-review[bot] commented

2025-09-23 16:57:55 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1655#issuecomment-3324849436
Original created: 2025-09-23T16:57:55Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Build Integrity

Confirm that removing the load statements for @platforms//os:os.bzl and @platforms//cpu:cpu.bzl does not affect symbols used elsewhere in this BUILD file or in macros; ensure constraint labels remain valid without the loads.

# Platform definitions for ServiceRadar multi-arch builds

platform(
    name = "linux_amd64",

Syntax Closure

Validate the added closing parenthesis and newline properly terminate the platform rule and that there are no trailing characters or formatting issues that could affect Bazel parsing.

platform(
    name = "rbe_linux_arm64",
    constraint_values = [
        "@platforms//os:linux",
        "@platforms//cpu:aarch64",
    ],
    exec_properties = {
        "container-image": "gcr.io/buildbuddy-io/executor:latest",
        "OSFamily": "linux",
        "Arch": "arm64",
        "dockerNetwork": "off",
        "Pool": "default",
    },
    visibility = ["//visibility:public"],
)

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1655#issuecomment-3324849436 Original created: 2025-09-23T16:57:55Z --- ## PR Reviewer Guide 🔍 Here are some key observations to aid the review process: <table> <tr><td>⏱️ <strong>Estimated effort to review</strong>: 1 🔵⚪⚪⚪⚪</td></tr> <tr><td>🧪 <strong>No relevant tests</strong></td></tr> <tr><td>🔒 <strong>No security concerns identified</strong></td></tr> <tr><td>⚡ <strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://github.com/carverauto/serviceradar/pull/1655/files#diff-e7aed8c1f0aa84f04005b98a61f13eae1bad9bfc0f13dc02afde9f62961193e2R1-R4'><strong>Build Integrity</strong></a> Confirm that removing the load statements for `@platforms//os:os.bzl` and `@platforms//cpu:cpu.bzl` does not affect symbols used elsewhere in this BUILD file or in macros; ensure constraint labels remain valid without the loads. </summary> ```txt # Platform definitions for ServiceRadar multi-arch builds platform( name = "linux_amd64", ``` </details> <details><summary><a href='https://github.com/carverauto/serviceradar/pull/1655/files#diff-e7aed8c1f0aa84f04005b98a61f13eae1bad9bfc0f13dc02afde9f62961193e2R56-R70'><strong>Syntax Closure</strong></a> Validate the added closing parenthesis and newline properly terminate the `platform` rule and that there are no trailing characters or formatting issues that could affect Bazel parsing. </summary> ```txt platform( name = "rbe_linux_arm64", constraint_values = [ "@platforms//os:linux", "@platforms//cpu:aarch64", ], exec_properties = { "container-image": "gcr.io/buildbuddy-io/executor:latest", "OSFamily": "linux", "Arch": "arm64", "dockerNetwork": "off", "Pool": "default", }, visibility = ["//visibility:public"], ) ``` </details> </td></tr> </table>

qodo-code-review[bot] commented

2025-09-23 16:58:07 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @qodo-code-review[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1655#issuecomment-3324849980
Original created: 2025-09-23T16:58:07Z

PR Code Suggestions ✨

No code suggestions found for the PR.

Imported GitHub PR comment. Original author: @qodo-code-review[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1655#issuecomment-3324849980 Original created: 2025-09-23T16:58:07Z --- ## PR Code Suggestions ✨ No code suggestions found for the PR.