Updates/k8s fixes #2164

Merged

mfreeman451 merged 32 commits from refs/pull/2164/head into main

2025-08-28 18:39:57 +00:00

mfreeman451 commented

2025-08-27 02:24:46 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1576
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1576
Original created: 2025-08-27T02:24:46Z
Original updated: 2025-08-28T18:40:01Z
Original head: carverauto/serviceradar:updates/k8s_fixes
Original base: main
Original merged: 2025-08-28T18:39:57Z by @mfreeman451

No description provided.

Imported from GitHub pull request. Original GitHub pull request: #1576 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1576 Original created: 2025-08-27T02:24:46Z Original updated: 2025-08-28T18:40:01Z Original head: carverauto/serviceradar:updates/k8s_fixes Original base: main Original merged: 2025-08-28T18:39:57Z by @mfreeman451 --- _No description provided._

gitguardian[bot] commented

2025-08-27 02:24:51 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @gitguardian[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/1576#issuecomment-3226527847
Original created: 2025-08-27T02:24:51Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
20438075	Triggered	Kubernetes Docker Secret	`99ce8d9cf0`	k8s/demo/base/secrets.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

Imported GitHub PR comment. Original author: @gitguardian[bot] Original URL: https://github.com/carverauto/serviceradar/pull/1576#issuecomment-3226527847 Original created: 2025-08-27T02:24:51Z --- #### ⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request. Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components. <details> <summary>🔎 Detected hardcoded secret in your pull request</summary> | GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [20438075](https://dashboard.gitguardian.com/workspace/312055/incidents/20438075?occurrence=210347565) | Triggered | Kubernetes Docker Secret | 99ce8d9cf0b54369aa35445ac68a178c3a08008d | k8s/demo/base/secrets.yaml | [View secret](https://github.com/carverauto/serviceradar/commit/99ce8d9cf0b54369aa35445ac68a178c3a08008d#diff-606d5c27a32fb978e98f7041e6dc6d30c013cec8052b8f48cf2f890c882b2022R26) | </details> <details> <summary>🛠 Guidelines to remediate hardcoded secrets</summary> 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/kubernetes_docker_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation. </details> --- 🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&utm_campaign=cr1) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

mfreeman451 commented

2025-08-28 18:39:52 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1576#issuecomment-3234558254
Original created: 2025-08-28T18:39:52Z

lgtm

Imported GitHub PR comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1576#issuecomment-3234558254 Original created: 2025-08-28T18:39:52Z --- lgtm