cleanup unused code #2083

Merged
mfreeman451 merged 1 commit from refs/pull/2083/head into main 2025-08-04 07:59:56 +00:00
mfreeman451 commented 2025-08-04 07:58:44 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #1456
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1456
Original created: 2025-08-04T07:58:44Z
Original updated: 2025-08-04T07:59:59Z
Original head: carverauto/serviceradar:1455-bugdb-event-writer-creating-consumer-with-missing-subjects
Original base: main
Original merged: 2025-08-04T07:59:56Z by @mfreeman451

  1. Removed unused code from processor.go:
    - Deleted SpanAttrsRow struct
    - Removed extractNormalizedSpanAttributes() function
    - Simplified processOTELTracesMessage() to only handle traces
    - Updated processTracesTable() to remove span attributes batch processing
    - Replaced parseOTELTracesWithAttrs() with simpler parseOTELTraces()
    - Created simplified processSpanSimple() without span attributes extraction
  2. Cleaned up debug logging added during troubleshooting
  3. Verified compilation - the code builds without errors
Imported from GitHub pull request. Original GitHub pull request: #1456 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1456 Original created: 2025-08-04T07:58:44Z Original updated: 2025-08-04T07:59:59Z Original head: carverauto/serviceradar:1455-bugdb-event-writer-creating-consumer-with-missing-subjects Original base: main Original merged: 2025-08-04T07:59:56Z by @mfreeman451 --- 1. Removed unused code from processor.go: - Deleted SpanAttrsRow struct - Removed extractNormalizedSpanAttributes() function - Simplified processOTELTracesMessage() to only handle traces - Updated processTracesTable() to remove span attributes batch processing - Replaced parseOTELTracesWithAttrs() with simpler parseOTELTraces() - Created simplified processSpanSimple() without span attributes extraction 2. Cleaned up debug logging added during troubleshooting 3. Verified compilation - the code builds without errors
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!2083
No description provided.