Bug/armis results propagation failure #2005

Merged

mfreeman451 merged 6 commits from refs/pull/2005/head into main

2025-07-22 08:19:34 +00:00

mfreeman451 commented

2025-07-22 07:08:21 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1309
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1309
Original created: 2025-07-22T07:08:21Z
Original updated: 2025-07-22T08:19:40Z
Original head: carverauto/serviceradar:bug/armis_results_propagation_failure
Original base: main
Original merged: 2025-07-22T08:19:34Z by @mfreeman451

No description provided.

Imported from GitHub pull request. Original GitHub pull request: #1309 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1309 Original created: 2025-07-22T07:08:21Z Original updated: 2025-07-22T08:19:40Z Original head: carverauto/serviceradar:bug/armis_results_propagation_failure Original base: main Original merged: 2025-07-22T08:19:34Z by @mfreeman451 --- _No description provided._

mfreeman451 commented

2025-07-22 07:55:36 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1309#discussion_r2221570957
Original created: 2025-07-22T07:55:36Z
Original path: pkg/sync/integrations/armis/armis_test.go
Original line: 842

need to update this to process the 3rd field (Events)

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1309#discussion_r2221570957 Original created: 2025-07-22T07:55:36Z Original path: pkg/sync/integrations/armis/armis_test.go Original line: 842 --- need to update this to process the 3rd field (Events)

mfreeman451 commented

2025-07-22 08:15:00 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1309#discussion_r2221636867
Original created: 2025-07-22T08:15:00Z
Original path: pkg/sync/integrations/armis/devices.go
Original line: 501

need to verify if we're using the correct armis_device_id field here for the armis updater

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1309#discussion_r2221636867 Original created: 2025-07-22T08:15:00Z Original path: pkg/sync/integrations/armis/devices.go Original line: 501 --- need to verify if we're using the correct armis_device_id field here for the armis updater

mfreeman451 commented

2025-07-22 08:17:28 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1309#discussion_r2221647988
Original created: 2025-07-22T08:17:28Z
Original path: pkg/sync/integrations/armis/devices.go
Original line: 501

looks good

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1309#discussion_r2221647988 Original created: 2025-07-22T08:17:28Z Original path: pkg/sync/integrations/armis/devices.go Original line: 501 --- looks good