Refactor/device id transition #1904

Merged

mfreeman451 merged 10 commits from refs/pull/1904/head into main

2025-06-30 17:06:09 +00:00

mfreeman451 commented

2025-06-30 05:40:47 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #1170
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1170
Original created: 2025-06-30T05:40:47Z
Original updated: 2025-06-30T17:06:12Z
Original head: carverauto/serviceradar:refactor/device_id_transition
Original base: main
Original merged: 2025-06-30T17:06:09Z by @mfreeman451

No description provided.

Imported from GitHub pull request. Original GitHub pull request: #1170 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1170 Original created: 2025-06-30T05:40:47Z Original updated: 2025-06-30T17:06:12Z Original head: carverauto/serviceradar:refactor/device_id_transition Original base: main Original merged: 2025-06-30T17:06:09Z by @mfreeman451 --- _No description provided._

mfreeman451 commented

2025-06-30 05:57:56 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1170#discussion_r2174282545
Original created: 2025-06-30T05:57:56Z
Original path: web/src/components/Metrics/DeviceAttributionBanner.tsx
Original line: 64

this is not going to work, we cant talk to the API directly need to go through nextjs middleware

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1170#discussion_r2174282545 Original created: 2025-06-30T05:57:56Z Original path: web/src/components/Metrics/DeviceAttributionBanner.tsx Original line: 64 --- this is not going to work, we cant talk to the API directly need to go through nextjs middleware

mfreeman451 commented

2025-06-30 17:04:37 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR review comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/1170#discussion_r2175533961
Original created: 2025-06-30T17:04:37Z
Original path: web/src/components/Metrics/DeviceAttributionBanner.tsx
Original line: 64

was wrong about this just had a bad nginx config

Imported GitHub PR review comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/1170#discussion_r2175533961 Original created: 2025-06-30T17:04:37Z Original path: web/src/components/Metrics/DeviceAttributionBanner.tsx Original line: 64 --- was wrong about this just had a bad nginx config