Fix sweep_results default filter #1764

Merged

mfreeman451 merged 1 commit from refs/pull/1764/head into 849-update-devices_mv-materialized-view-to-include-relationship-metadata

2025-06-20 01:53:19 +00:00

mfreeman451 commented

2025-06-20 01:53:02 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #990
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/990
Original created: 2025-06-20T01:53:02Z
Original updated: 2025-06-20T01:53:25Z
Original head: carverauto/serviceradar:codex/fix-sweep_results-query-filtering
Original base: 849-update-devices_mv-materialized-view-to-include-relationship-metadata
Original merged: 2025-06-20T01:53:19Z by @mfreeman451

Summary

add implicit discovery_source = 'sweep' filter when querying sweep_results
update tests for translator to expect the filter
add regression test for implicit filter

Testing

go test ./pkg/srql -run TestSRQLParsingAndTranslation -count=1
go test ./pkg/srql -run TestSRQLParsingAndTranslation -count=1

https://chatgpt.com/codex/tasks/task_e_6854bbd9f56c8320911fe6c2fecd05fa

Imported from GitHub pull request. Original GitHub pull request: #990 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/990 Original created: 2025-06-20T01:53:02Z Original updated: 2025-06-20T01:53:25Z Original head: carverauto/serviceradar:codex/fix-sweep_results-query-filtering Original base: 849-update-devices_mv-materialized-view-to-include-relationship-metadata Original merged: 2025-06-20T01:53:19Z by @mfreeman451 --- ## Summary - add implicit `discovery_source = 'sweep'` filter when querying `sweep_results` - update tests for translator to expect the filter - add regression test for implicit filter ## Testing - `go test ./pkg/srql -run TestSRQLParsingAndTranslation -count=1` - `go test ./pkg/srql -run TestSRQLParsingAndTranslation -count=1` ------ https://chatgpt.com/codex/tasks/task_e_6854bbd9f56c8320911fe6c2fecd05fa

Rows
Columns