Move device publishing to sync #1740

Merged
mfreeman451 merged 1 commit from refs/pull/1740/head into 800-live-armis-poc-integration-into-serviceradar 2025-06-18 17:59:45 +00:00
mfreeman451 commented 2025-06-18 17:56:40 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #964
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/964
Original created: 2025-06-18T17:56:40Z
Original updated: 2025-06-18T17:59:49Z
Original head: carverauto/serviceradar:codex/refactor-armis-integration-and-move-nats-logic
Original base: 800-live-armis-poc-integration-into-serviceradar
Original merged: 2025-06-18T17:59:45Z by @mfreeman451

Summary

  • simplify Armis integration by removing direct JetStream handling
  • add JetStream device publishing logic to the sync package
  • update integration interfaces and implementations
  • adapt tests to new signatures

Testing

  • go test ./...

https://chatgpt.com/codex/tasks/task_e_6852fb27a1bc83208bbf75ff3fe5649e

Imported from GitHub pull request. Original GitHub pull request: #964 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/964 Original created: 2025-06-18T17:56:40Z Original updated: 2025-06-18T17:59:49Z Original head: carverauto/serviceradar:codex/refactor-armis-integration-and-move-nats-logic Original base: 800-live-armis-poc-integration-into-serviceradar Original merged: 2025-06-18T17:59:45Z by @mfreeman451 --- ## Summary - simplify Armis integration by removing direct JetStream handling - add JetStream device publishing logic to the sync package - update integration interfaces and implementations - adapt tests to new signatures ## Testing - `go test ./...` ------ https://chatgpt.com/codex/tasks/task_e_6852fb27a1bc83208bbf75ff3fe5649e
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!1740
No description provided.