Fix nil kv client in sync service #1739

Merged
mfreeman451 merged 1 commit from refs/pull/1739/head into 800-live-armis-poc-integration-into-serviceradar 2025-06-18 17:13:40 +00:00
mfreeman451 commented 2025-06-18 17:12:26 +00:00 (Migrated from github.com)
Owner

Imported from GitHub pull request.

Original GitHub pull request: #963
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/963
Original created: 2025-06-18T17:12:26Z
Original updated: 2025-06-18T17:34:51Z
Original head: carverauto/serviceradar:codex/fix-sync-service-panic-due-to-nil-pointer
Original base: 800-live-armis-poc-integration-into-serviceradar
Original merged: 2025-06-18T17:13:40Z by @mfreeman451

Summary

  • connect to KV in sync.NewWithGRPC
  • store and close the KV gRPC client
  • update tests for new parameter

Testing

  • go test ./...

https://chatgpt.com/codex/tasks/task_e_6852f17e36c88320b5c4b9ba50a05566

Imported from GitHub pull request. Original GitHub pull request: #963 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/963 Original created: 2025-06-18T17:12:26Z Original updated: 2025-06-18T17:34:51Z Original head: carverauto/serviceradar:codex/fix-sync-service-panic-due-to-nil-pointer Original base: 800-live-armis-poc-integration-into-serviceradar Original merged: 2025-06-18T17:13:40Z by @mfreeman451 --- ## Summary - connect to KV in `sync.NewWithGRPC` - store and close the KV gRPC client - update tests for new parameter ## Testing - `go test ./...` ------ https://chatgpt.com/codex/tasks/task_e_6852f17e36c88320b5c4b9ba50a05566
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!1739
No description provided.