719 packaging proton #1588

Merged

mfreeman451 merged 2 commits from refs/pull/1588/head into main

2025-05-05 04:29:38 +00:00

mfreeman451 commented

2025-05-05 04:24:10 +00:00

(Migrated from github.com)

Owner

Imported from GitHub pull request.

Original GitHub pull request: #722
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/pull/722
Original created: 2025-05-05T04:24:10Z
Original updated: 2025-05-05T04:29:44Z
Original head: carverauto/serviceradar:719-packaging---proton
Original base: main
Original merged: 2025-05-05T04:29:38Z by @mfreeman451

No description provided.

Imported from GitHub pull request. Original GitHub pull request: #722 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/pull/722 Original created: 2025-05-05T04:24:10Z Original updated: 2025-05-05T04:29:44Z Original head: carverauto/serviceradar:719-packaging---proton Original base: main Original merged: 2025-05-05T04:29:38Z by @mfreeman451 --- _No description provided._

gitguardian[bot] commented

2025-05-05 04:24:14 +00:00

(Migrated from github.com)

Author

Owner

Imported GitHub PR comment.

Original author: @gitguardian[bot]
Original URL: https://github.com/carverauto/serviceradar/pull/722#issuecomment-2849875987
Original created: 2025-05-05T04:24:14Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
16948338	Triggered	Generic Password	`cd2eab65e4`	packaging/proton/config/users.yaml	View secret
16948339	Triggered	Generic Password	`cd2eab65e4`	packaging/proton/config/users.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

Imported GitHub PR comment. Original author: @gitguardian[bot] Original URL: https://github.com/carverauto/serviceradar/pull/722#issuecomment-2849875987 Original created: 2025-05-05T04:24:14Z --- #### ⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request. Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components. <details> <summary>🔎 Detected hardcoded secrets in your pull request</summary> | GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [16948338](https://dashboard.gitguardian.com/workspace/312055/incidents/16948338?occurrence=186142885) | Triggered | Generic Password | cd2eab65e420390db337d06a3a921b93357adfd9 | packaging/proton/config/users.yaml | [View secret](https://github.com/carverauto/serviceradar/commit/cd2eab65e420390db337d06a3a921b93357adfd9#diff-32824be2fa438a36e361e4a8dd2a56af61499915c233803cc65fba61ab726d89R107) | | [16948339](https://dashboard.gitguardian.com/workspace/312055/incidents/16948339?occurrence=186142884) | Triggered | Generic Password | cd2eab65e420390db337d06a3a921b93357adfd9 | packaging/proton/config/users.yaml | [View secret](https://github.com/carverauto/serviceradar/commit/cd2eab65e420390db337d06a3a921b93357adfd9#diff-32824be2fa438a36e361e4a8dd2a56af61499915c233803cc65fba61ab726d89R41) | </details> <details> <summary>🛠 Guidelines to remediate hardcoded secrets</summary> 1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation. </details> --- 🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&utm_source=github&utm_campaign=cr1) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.