bug(srql): srql builder not handling discovery_sources array correctly #773

New issue

Closed

opened 2026-03-28 04:28:24 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:28:24 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #2363
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/2363
Original created: 2026-01-19T01:22:52Z

Describe the bug
If you are using the srql builder to build your SRQL query, and you want to search for devices with discovery_sources set to 'armis', if you did so like this:

in:devices discovery_sources:armis sort:last_seen:desc limit:20

That would return 0 results

If you do

in:devices discovery_sources:(armis) sort:last_seen:desc limit:20

Users should not be expected to know what is an array and what isn't, the SRQL engine should be smart enough to translate that or the SRQL query builder, not exactly sure where this should go but, I feel like in SRQL (rust) is the best place instead of patching the UI or ash adapter.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Imported from GitHub. Original GitHub issue: #2363 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/2363 Original created: 2026-01-19T01:22:52Z --- **Describe the bug** If you are using the srql builder to build your SRQL query, and you want to search for devices with discovery_sources set to 'armis', if you did so like this: `in:devices discovery_sources:armis sort:last_seen:desc limit:20` That would return 0 results If you do `in:devices discovery_sources:(armis) sort:last_seen:desc limit:20` Users should not be expected to know what is an array and what isn't, the SRQL engine should be smart enough to translate that or the SRQL query builder, not exactly sure where this should go but, I feel like in SRQL (rust) is the best place instead of patching the UI or ash adapter. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. **Screenshots** If applicable, add screenshots to help explain your problem. **Desktop (please complete the following information):** - OS: [e.g. iOS] - Browser [e.g. chrome, safari] - Version [e.g. 22] **Smartphone (please complete the following information):** - Device: [e.g. iPhone6] - OS: [e.g. iOS8.1] - Browser [e.g. stock browser, safari] - Version [e.g. 22] **Additional context** Add any other context about the problem here.