ui cleanup work #753

New issue

Closed

opened 2026-03-28 04:28:11 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented 2026-03-28 04:28:11 +00:00

Owner

Copy link

Imported from GitHub.

Original GitHub issue: #2310
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/2310
Original created: 2026-01-15T03:50:53Z

---

Describe the bug

• Navigating to SNMP in settings makes topbar and sidebar nav disappear
• SNMP settings missing credentials forms (no way to input community strings etc) - Already exists in SNMPTarget resource
• SNMP stuff should be moved in under Networks tab in Settings UI
• Networks tab should be renamed 'Network'
• Create new 'Agents' section
• Move 'Sysmon' under 'Agents' section
• Add button to deploy new agent in 'Agents' section
• Edge Ops cleanup -- Renamed tabs to "Edge Sites", "Data Collectors", "Components". Updated Deploy Agent page with clearer guidance.
• There should only be two edge onboarding processes - Simplified to Standard Agent vs Edge Site Agent in Deploy page
• #2289 - sysmon settings ui broken (Fixed: added Layouts.app wrapper)
• #2292 - Update Device Details UI to allow Edits (Fixed: Edit button with RBAC, editable form)
• #2293 - feat: RBAC builder/editor (out of scope for this issue)
• #2254 - bug(srql): search filters broken in UI (separate issue)
• #2269 - show total device count (Fixed: added total_count to pagination)
• #2265 - add devices from UI (Fixed: Add Device modal, CSV import with preview)
• #2262 - network sweep profile creator broken (Fixed: added transform_profile_params)
• #2259 - integration source cleanup (Fixed: dynamic credential forms for Armis, SNMP, Netbox)

Implementation Summary

Completed Changes:

1. Navigation & Layout: Fixed SNMP/Sysmon pages with proper Layouts.app wrapper
2. Settings Reorganization:
   • Renamed "Networks" → "Network" tab
   • Created "Agents" section with sub-navigation (Sysmon, Deploy)
   • Added Network sub-navigation (Sweep Profiles, SNMP)
3. Edge Ops: Renamed tabs, improved Deploy Agent page guidance
4. Form Fixes: Added array field transforms for Sysmon (disk_paths) and Networks (ports)
5. Integration Forms: Dynamic credential fields for Armis, SNMP, Netbox
6. Device UI:
   • Added total count to pagination ("Showing X of Y results")
   • Action buttons (Add Device, Import CSV, Network Discovery)
   • Edit button with RBAC protection (admin/owner only)
   • Editable form with phx-debounce="300"
   • CSV import with LiveView uploads, preview table, and validation

Remaining (Nice-to-have):

• Page number pagination (current prev/next works fine)
• Network blacklist field conditional display
• Remove/deprecate nmap integration source

See OpenSpec proposal: openspec/changes/refactor-settings-ui-cleanup/

Imported from GitHub. Original GitHub issue: #2310 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/2310 Original created: 2026-01-15T03:50:53Z --- **Describe the bug** - [x] Navigating to SNMP in settings makes topbar and sidebar nav disappear - [x] SNMP settings missing credentials forms (no way to input community strings etc) - Already exists in SNMPTarget resource - [x] SNMP stuff should be moved in under Networks tab in Settings UI - [x] Networks tab should be renamed 'Network' - [x] Create new 'Agents' section - [x] Move 'Sysmon' under 'Agents' section - [x] Add button to deploy new agent in 'Agents' section - [x] Edge Ops cleanup -- Renamed tabs to "Edge Sites", "Data Collectors", "Components". Updated Deploy Agent page with clearer guidance. - [x] There should only be two edge onboarding processes - Simplified to Standard Agent vs Edge Site Agent in Deploy page - [x] #2289 - sysmon settings ui broken (Fixed: added Layouts.app wrapper) - [x] #2292 - Update Device Details UI to allow Edits (Fixed: Edit button with RBAC, editable form) - [ ] #2293 - feat: RBAC builder/editor (out of scope for this issue) - [ ] #2254 - bug(srql): search filters broken in UI (separate issue) - [x] #2269 - show total device count (Fixed: added total_count to pagination) - [x] #2265 - add devices from UI (Fixed: Add Device modal, CSV import with preview) - [x] #2262 - network sweep profile creator broken (Fixed: added transform_profile_params) - [x] #2259 - integration source cleanup (Fixed: dynamic credential forms for Armis, SNMP, Netbox) ## Implementation Summary ### Completed Changes: 1. **Navigation & Layout**: Fixed SNMP/Sysmon pages with proper Layouts.app wrapper 2. **Settings Reorganization**: - Renamed "Networks" → "Network" tab - Created "Agents" section with sub-navigation (Sysmon, Deploy) - Added Network sub-navigation (Sweep Profiles, SNMP) 3. **Edge Ops**: Renamed tabs, improved Deploy Agent page guidance 4. **Form Fixes**: Added array field transforms for Sysmon (disk_paths) and Networks (ports) 5. **Integration Forms**: Dynamic credential fields for Armis, SNMP, Netbox 6. **Device UI**: - Added total count to pagination ("Showing X of Y results") - Action buttons (Add Device, Import CSV, Network Discovery) - Edit button with RBAC protection (admin/owner only) - Editable form with phx-debounce="300" - CSV import with LiveView uploads, preview table, and validation ### Remaining (Nice-to-have): - Page number pagination (current prev/next works fine) - Network blacklist field conditional display - Remove/deprecate nmap integration source See OpenSpec proposal: `openspec/changes/refactor-settings-ui-cleanup/`

mfreeman451 closed this issue 2026-03-28 04:28:11 +00:00

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

staging

2406-feat-agent-fleet-management-secure-self-update-system

bug/k8s-helm-deployments

chore/k8s-arc-update

rust-fix

2371-analytics-stats-cards-should-abbreviate-numbers

chore/perl-cleanup

2942-featweb-ng-add-logs-tab-to-device-details-page

192-feat-tftp-server

mikemiles-dev/feature/netflow_collection

testing

dependabot/cargo/hostname-0.4.1

dependabot/cargo/redis-1.0.1

dependabot/cargo/bb8-0.9.0

dependabot/cargo/rcgen-0.14.6

dependabot/cargo/hyper-1.8.1

dependabot/cargo/hyper-util-0.1.19

dependabot/cargo/clap-4.5.51

dependabot/cargo/thiserror-2.0.17

dependabot/cargo/time-tz-2.0.0

dependabot/cargo/tonic-build-0.14.2

main

dependabot/npm_and_yarn/docs/mdast-util-to-hast-13.2.1

815-feat-support-win32-for-agentpoller

gh-pages

v1.2.5

v1.2.4

v1.2.3

v1.2.2

v1.2.1

v1.2.0

v1.1.2

v1.1.0

v1.0.92

v1.0.91

v1.0.90

v1.0.89

v1.0.88

v1.0.87

v1.0.86

v1.0.85

v1.0.84

v1.0.83

v1.0.82

v1.0.81

v1.0.78

v1.0.77

v1.0.76

v1.0.70

v1.0.69

v1.0.68

v1.0.67

v1.0.66

v1.0.65

v1.0.64

v1.0.63

v1.0.62

v1.0.61

v1.0.60

v1.0.59

v1.0.58

1.0.57

v1.0.56

v1.0.55

v1.0.54-pre5

v1.0.53

v1.0.53-pre19

v1.0.53-pre18

v1.0.53-pre17

v1.0.53-pre15

1.0.53-pre10

1.0.53-pre9

1.0.53-pre8

1.0.53-pre7

1.0.53-pre6

1.0.53-pre5

1.0.53-pre4

1.0.53-pre3

1.0.53-pre2

1.0.53-pre1

1.0.52

1.0.51

1.0.50

1.0.49

1.0.49-pre5

1.0.49-pre4

1.0.49-pre3

1.0.49-pre2

1.0.48

1.0.48-rc2

1.0.48-rc1

1.0.48-pre8

1.0.48-pre7

1.0.48-pre6

1.0.48-pre5

1.0.48-pre4

1.0.48-pre3

1.0.48-pre2

1.0.48-pre1

1.0.47

1.0.47-pre8

1.0.47-pre7

1.0.47-pre6

1.0.47-pre5

1.0.47-pre4

1.0.47-pre3

1.0.47-pre2

1.0.47-pre1

1.0.46

1.0.46-pre9

1.0.46-pre8

1.0.46-pre7

1.0.46-pre6

1.0.46-pre5

1.0.46-pre4

1.0.46-pre3

1.0.46-pre2

1.0.46-pre1

1.0.45

1.0.44

1.0.44-pre12

1.0.44-pre11

1.0.44-pre10

1.0.44-pre9

1.0.44-pre8

1.0.44-pre7

1.0.44-pre6

1.0.44-pre5

1.0.44-pre4

1.0.44-pre3

1.0.44-pre2

1.0.44-pre1

1.0.43

1.0.42

1.0.41

1.0.41-pre1

1.0.40

1.0.40-pre11

1.0.40-pre10

1.0.40-pre9

1.0.40-pre8

1.0.40-pre7

1.0.40-pre6

1.0.40-pre5

1.0.40-pre4

1.0.40-pre3

1.0.40-pre2

1.0.40-pre1

1.0.39

1.0.38

1.0.37

1.0.36

1.0.36-pre5

1.0.36-pre4

1.0.36-pre3

1.0.36-pre2

1.0.35

1.0.35-pre3

1.0.35-pre2

1.0.35-pre

1.0.34-pre3

1.0.34-pre2

1.0.34-pre1

1.0.33

1.0.33-pre2

1.0.33-pre

1.0.32

1.0.31

1.0.30

1.0.29

1.0.28

1.0.27

1.0.26

1.0.25

1.0.24

1.0.23

1.0.22

1.0.21

1.0.20

1.0.19

1.0.18

1.0.17

1.0.16

1.0.15

1.0.14

1.0.13

1.0.11

1.0.10

1.0.9

1.0.8

1.0.7

1.0.6

1.0.5

1.0.4

1.0.3

1.0.2

1.0.1

1.0.0

Labels

Clear labels   

1week

  

2weeks

  

Failed compliance check

  

IP cameras

  

NATS

NATS JetStream

  

Possible security concern

  

Review effort 1/5

  

Review effort 2/5

  

Review effort 3/5

  

Review effort 4/5

  

Review effort 5/5

  

UI

  

aardvark

  

accessibility

  

amd64

  

api

  

arm64

  

auth

  

back-end

  

bgp

  

blog

  

bug

Something isn't working

  

build

  

checkers

  

ci-cd

continuous integration-continuous deployments

  

cleanup

  

cnpg

cloud-native postgres

  

codex

  

core

core service

  

dependencies

Pull requests that update a dependency file

  

device-management

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

dusk

  

ebpf

  

enhancement

New feature or request

  

eta 1d

  

eta 1hr

  

eta 3d

  

eta 3hr

  

feature

  

fieldsurvey

  

github_actions

Pull requests that update GitHub Actions code

  

go

Pull requests that update Go code

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

javascript

Pull requests that update Javascript code

  

k8s

  

log-collector

  

mapper

  

mtr

multi traceroute

  

needs-triage

  

netflow

  

network-sweep

  

observability

  

oracle

Oracle Linux related issues

  

otel

opentelemetry logs, traces, metrics

  

plug-in

  

proton

timeplus proton streaming database

  

python

  

question

Further information is requested

  

reddit

  

redhat

  

research

  

rperf

  

rperf-checker

  

rust

Pull requests that update rust code

  

sdk

  

security

  

serviceradar-agent

  

serviceradar-agent-gateway

  

serviceradar-web

  

serviceradar-web-ng

  

siem

  

snmp

  

sysmon

  

topology

  

ubiquiti

  

wasm

  

wontfix

This will not be worked on

  

zen-engine

No labels

1week

2weeks

Failed compliance check

IP cameras

NATS

Possible security concern

Review effort 1/5

Review effort 2/5

Review effort 3/5

Review effort 4/5

Review effort 5/5

UI

aardvark

accessibility

amd64

api

arm64

auth

back-end

bgp

blog

bug

build

checkers

ci-cd

cleanup

cnpg

codex

core

dependencies

device-management

documentation

duplicate

dusk

ebpf

enhancement

eta 1d

eta 1hr

eta 3d

eta 3hr

feature

fieldsurvey

github_actions

go

good first issue

help wanted

invalid

javascript

k8s

log-collector

mapper

mtr

needs-triage

netflow

network-sweep

observability

oracle

otel

plug-in

proton

python

question

reddit

redhat

research

rperf

rperf-checker

rust

sdk

security

serviceradar-agent

serviceradar-agent-gateway

serviceradar-web

serviceradar-web-ng

siem

snmp

sysmon

topology

ubiquiti

wasm

wontfix

zen-engine

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

carverauto/serviceradar#753

No description provided.