carverauto/serviceradar

Fork 0

bug(ui): device inventory view fails to load #607

New issue

Closed

opened 2026-03-28 04:26:20 +00:00 by mfreeman451 · 7 comments

mfreeman451 commented

2026-03-28 04:26:20 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #1869
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869
Original created: 2025-10-23T07:56:17Z

Describe the bug
if you navigate to the 'Network' page/tab, and then back to 'Devices', it will sit there and spin and not load any devices.

Same goes with any other tab/view really, you can navigate to the 'Analytics' page and then back to 'Devices' same thing, no devices will load, spinner just runs forever unless you refresh the page.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Imported from GitHub. Original GitHub issue: #1869 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869 Original created: 2025-10-23T07:56:17Z --- **Describe the bug** if you navigate to the 'Network' page/tab, and then back to 'Devices', it will sit there and spin and not load any devices. Same goes with any other tab/view really, you can navigate to the 'Analytics' page and then back to 'Devices' same thing, no devices will load, spinner just runs forever unless you refresh the page. **To Reproduce** Steps to reproduce the behavior: 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error **Expected behavior** A clear and concise description of what you expected to happen. **Screenshots** If applicable, add screenshots to help explain your problem. **Desktop (please complete the following information):** - OS: [e.g. iOS] - Browser [e.g. chrome, safari] - Version [e.g. 22] **Smartphone (please complete the following information):** - Device: [e.g. iPhone6] - OS: [e.g. iOS8.1] - Browser [e.g. stock browser, safari] - Version [e.g. 22] **Additional context** Add any other context about the problem here.

mfreeman451 commented

2026-03-28 04:26:21 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437545711
Original created: 2025-10-23T15:10:50Z

Fix posted in latest web build: Devices dashboard now reclaims the SRQL context whenever you navigate back from another tab, so the table refetches immediately instead of spinning forever. Added regression coverage (selectDevicesQuery helper) and pushed ghcr.io/carverauto/serviceradar-web:sha-46be33ab07a5 to demo after npm run lint && npm run test.

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437545711 Original created: 2025-10-23T15:10:50Z --- Fix posted in latest web build: Devices dashboard now reclaims the SRQL context whenever you navigate back from another tab, so the table refetches immediately instead of spinning forever. Added regression coverage (selectDevicesQuery helper) and pushed ghcr.io/carverauto/serviceradar-web:sha-46be33ab07a5 to demo after npm run lint && npm run test.

mfreeman451 commented

2026-03-28 04:26:21 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437601168
Original created: 2025-10-23T15:21:08Z

Follow-up: Network → Sweeps now shows the correct totals again. We were coercing the Proton count response to 0 when the row came back as a string, so the stat cards always read zero. The view now normalises the values (and falls back to the deduped sweep results when Proton omits the stat row). Pushed in ghcr.io/carverauto/serviceradar-web:sha-d46798a63e67 and rolled to demo.

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437601168 Original created: 2025-10-23T15:21:08Z --- Follow-up: Network → Sweeps now shows the correct totals again. We were coercing the Proton count response to 0 when the row came back as a string, so the stat cards always read zero. The view now normalises the values (and falls back to the deduped sweep results when Proton omits the stat row). Pushed in ghcr.io/carverauto/serviceradar-web:sha-d46798a63e67 and rolled to demo.

mfreeman451 commented

2026-03-28 04:26:21 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437663844
Original created: 2025-10-23T15:30:44Z

Sweeps tab is rendering again after filtering out non-host rows coming back from the SRQL query. We now skip any result without an IP and guard the search filter so it doesn’t lowercase undefined, which was tripping React (#418). Fresh build is ghcr.io/carverauto/serviceradar-web:sha-0bd84847d30d and it’s rolled to demo.

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437663844 Original created: 2025-10-23T15:30:44Z --- Sweeps tab is rendering again after filtering out non-host rows coming back from the SRQL query. We now skip any result without an IP and guard the search filter so it doesn’t lowercase undefined, which was tripping React (#418). Fresh build is ghcr.io/carverauto/serviceradar-web:sha-0bd84847d30d and it’s rolled to demo.

mfreeman451 commented

2026-03-28 04:26:21 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437698177
Original created: 2025-10-23T15:37:16Z

Another tweak: if Proton sends sweep rows without an IP we now fall back to device_id when hydrating the results, so the host summary/host detail tables render instead of collapsing to zero. Search also matches device IDs. Image ghcr.io/carverauto/serviceradar-web:sha-08fc308d0355 is live in demo.

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437698177 Original created: 2025-10-23T15:37:16Z --- Another tweak: if Proton sends sweep rows without an IP we now fall back to device_id when hydrating the results, so the host summary/host detail tables render instead of collapsing to zero. Search also matches device IDs. Image ghcr.io/carverauto/serviceradar-web:sha-08fc308d0355 is live in demo.

mfreeman451 commented

2026-03-28 04:26:21 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437750719
Original created: 2025-10-23T15:46:59Z

Restored the original sweep result hydration (the earlier filter was dropping host rows). The SRQL count coercion and search guard remain, so the tables render with the full host list again. New image ghcr.io/carverauto/serviceradar-web:sha-72c5ab39da94 is live in demo.

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437750719 Original created: 2025-10-23T15:46:59Z --- Restored the original sweep result hydration (the earlier filter was dropping host rows). The SRQL count coercion and search guard remain, so the tables render with the full host list again. New image ghcr.io/carverauto/serviceradar-web:sha-72c5ab39da94 is live in demo.

mfreeman451 commented

2026-03-28 04:26:22 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437795940
Original created: 2025-10-23T15:56:09Z

Web now fetches sweep data via the SRQL /api/query endpoint instead of the deprecated /api/devices/sweep route. Shipped in ghcr.io/carverauto/serviceradar-web:sha-81c5c53925a8 (rolled to demo).

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3437795940 Original created: 2025-10-23T15:56:09Z --- Web now fetches sweep data via the SRQL /api/query endpoint instead of the deprecated /api/devices/sweep route. Shipped in ghcr.io/carverauto/serviceradar-web:sha-81c5c53925a8 (rolled to demo).

mfreeman451 commented

2026-03-28 04:26:22 +00:00

Author

Owner

Imported GitHub comment.

Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3446889256
Original created: 2025-10-25T16:41:52Z

closing, fixed

Imported GitHub comment. Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1869#issuecomment-3446889256 Original created: 2025-10-25T16:41:52Z --- closing, fixed