proto/monitoring.proto #44

New issue

Closed

opened 2026-03-28 04:20:43 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:20:43 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #81
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/81
Original created: 2025-01-20T03:47:41Z

The StatusRequest message includes fields like ServiceName, ServiceType, Details, and Port. These fields could be consolidated into a single map[string]string or a google.protobuf.Struct to make it more flexible.
The SweepServiceStatus message could be improved by including more detailed information about the sweep results.
The gRPC service definitions could be made more RESTful by using HTTP verbs and resource paths in the method names (e.g., GetStatus could be GetNodeStatus or GetServiceStatus).
The SweepServiceStatus message contains fields (Network, TotalHosts, AvailableHosts, Ports, LastSweep) which don't change between updates. It might be better to separate the static fields into a separate message, reducing the size of updates.
The generated code uses deprecated github.com/golang/protobuf/proto package.
The SweepServiceStatus message includes a field named AvailableHosts which is somewhat confusing. It represents the number of hosts that responded during the sweep, not the number of hosts that are currently available. A more accurate name might be RespondingHosts.

Imported from GitHub. Original GitHub issue: #81 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/81 Original created: 2025-01-20T03:47:41Z --- - [ ] The StatusRequest message includes fields like ServiceName, ServiceType, Details, and Port. These fields could be consolidated into a single map[string]string or a google.protobuf.Struct to make it more flexible. - [ ] The SweepServiceStatus message could be improved by including more detailed information about the sweep results. - [ ] The gRPC service definitions could be made more RESTful by using HTTP verbs and resource paths in the method names (e.g., GetStatus could be GetNodeStatus or GetServiceStatus). - [ ] The SweepServiceStatus message contains fields (Network, TotalHosts, AvailableHosts, Ports, LastSweep) which don't change between updates. It might be better to separate the static fields into a separate message, reducing the size of updates. - [ ] The generated code uses deprecated github.com/golang/protobuf/proto package. - [ ] The SweepServiceStatus message includes a field named AvailableHosts which is somewhat confusing. It represents the number of hosts that responded during the sweep, not the number of hosts that are currently available. A more accurate name might be RespondingHosts.

Rows
Columns