remove unused tests from pkg/core/discovery_correlation_test.go #424

New issue

Closed

opened 2026-03-28 04:24:26 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:24:26 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #1317
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/1317
Original created: 2025-07-23T19:56:28Z

Remove Outdated Tests: The tests TestCorrelationLogicFlow and TestSmartMerging appear to test for a smart-merging logic (using a ipToCanonicalDevice map) that no longer exists in the Go code. This logic was likely, and correctly, delegated to the database. These tests provide a false sense of security and should be removed or rewritten to mock and verify interactions with the DeviceRegistry.

Imported from GitHub. Original GitHub issue: #1317 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/1317 Original created: 2025-07-23T19:56:28Z --- Remove Outdated Tests: The tests TestCorrelationLogicFlow and TestSmartMerging appear to test for a smart-merging logic (using a ipToCanonicalDevice map) that no longer exists in the Go code. This logic was likely, and correctly, delegated to the database. These tests provide a false sense of security and should be removed or rewritten to mock and verify interactions with the DeviceRegistry.

Rows
Columns