pkg/grpc/server.go #42

New issue

Closed

opened 2026-03-28 04:20:42 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:20:42 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #79
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/79
Original created: 2025-01-20T03:45:35Z

The services map in the Server struct could be made a sync.Map to avoid the need for explicit locking.
The errHealthServerRegistered could be made more informative by including the service name.
The RegisterService() function could return an error if the service is already registered.

Imported from GitHub. Original GitHub issue: #79 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/79 Original created: 2025-01-20T03:45:35Z --- - [ ] The services map in the Server struct could be made a sync.Map to avoid the need for explicit locking. - [ ] The errHealthServerRegistered could be made more informative by including the service name. - [ ] The RegisterService() function could return an error if the service is already registered.

Rows
Columns