pkg/sweeper/sqlite_store.go #41

New issue

Closed

opened 2026-03-28 04:20:42 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:20:42 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #78
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/78
Original created: 2025-01-20T03:44:02Z

Error handling in many of the functions is too generic (e.g., using errGetResults). More specific error messages would improve debugging.
The queryBuilder could be improved to handle more complex queries and reduce code duplication.
The GetResults() function could be optimized by using a more efficient query.
The database schema could be improved by adding indexes to frequently queried columns.
This implementation does not store the mode used during a sweep.
This implementation does not update first_seen if an existing host/port is seen again with available == false.
This implementation does not store data about ICMP pings.

Imported from GitHub. Original GitHub issue: #78 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/78 Original created: 2025-01-20T03:44:02Z --- - [ ] Error handling in many of the functions is too generic (e.g., using errGetResults). More specific error messages would improve debugging. - [ ] The queryBuilder could be improved to handle more complex queries and reduce code duplication. - [ ] The GetResults() function could be optimized by using a more efficient query. - [ ] The database schema could be improved by adding indexes to frequently queried columns. - [ ] This implementation does not store the mode used during a sweep. - [ ] This implementation does not update first_seen if an existing host/port is seen again with available == false. - [ ] This implementation does not store data about ICMP pings.

Rows
Columns