pkg/sweeper/icmp_scanner.go #38

New issue

Closed

opened 2026-03-28 04:20:40 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:20:40 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #75
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/75
Original created: 2025-01-20T03:42:23Z

The fallbackScan() function creates a new TCPScanner for each call, which is inefficient.
The sendPing() function logs errors that might not be actual errors (e.g., timeout).
The pingHost() function could be made more robust by handling different types of ICMP responses.
The maxPacketSize constant could be made configurable.

Imported from GitHub. Original GitHub issue: #75 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/75 Original created: 2025-01-20T03:42:23Z --- - [ ] The fallbackScan() function creates a new TCPScanner for each call, which is inefficient. - [ ] The sendPing() function logs errors that might not be actual errors (e.g., timeout). - [ ] The pingHost() function could be made more robust by handling different types of ICMP responses. - [ ] The maxPacketSize constant could be made configurable.

Rows
Columns