carverauto/serviceradar
carverauto/serviceradar
2
3
Fork 0
Code Issues 233 Pull requests 24 Projects Releases 254 Packages Wiki Activity Actions 8

Fix native add-on artifact downloads #3537

Merged
mfreeman451 merged 2 commits from fix/native-addon-datasvc-download into staging 2026-06-05 05:29:15 +00:00
Conversation 0 Commits 2 Files changed 9 +244 -33
mfreeman451 commented 2026-06-05 03:22:27 +00:00
Owner
Copy link

Summary

  • serve native add-on download tokens from datasvc object storage instead of web-ng plugin JetStream storage
  • normalize datasvc missing-object status to the existing 404 response
  • bump serviceradar-netprobe crate metadata to 0.2.1 so the binary version matches the published add-on manifest

Validation

  • mix test test/serviceradar/plugins/native_addon_artifact_mirror_test.exs
  • TEST_CNPG_* srql-fixtures scratch DB + SERVICERADAR_REQUIRE_DB_TESTS=1 mix test test/phoenix/controllers/api/addon_package_controller_test.exs
  • sfw cargo check -p serviceradar-netprobe --no-default-features
  • cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name=="serviceradar-netprobe") | .version'
## Summary - serve native add-on download tokens from datasvc object storage instead of web-ng plugin JetStream storage - normalize datasvc missing-object status to the existing 404 response - bump serviceradar-netprobe crate metadata to 0.2.1 so the binary version matches the published add-on manifest ## Validation - mix test test/serviceradar/plugins/native_addon_artifact_mirror_test.exs - TEST_CNPG_* srql-fixtures scratch DB + SERVICERADAR_REQUIRE_DB_TESTS=1 mix test test/phoenix/controllers/api/addon_package_controller_test.exs - sfw cargo check -p serviceradar-netprobe --no-default-features - cargo metadata --format-version=1 --no-deps | jq -r '.packages[] | select(.name=="serviceradar-netprobe") | .version'
Fix native add-on artifact downloads
Some checks failed
Netprobe eBPF Verifier / Verify eBPF programs on Linux 5.15 (push) Waiting to run
Details
Netprobe eBPF Verifier / Verify eBPF programs on Linux 5.8 (push) Waiting to run
Details
Netprobe eBPF Verifier / Verify eBPF programs on Linux 6.x (push) Waiting to run
Details
Netprobe eBPF Verifier / Verify eBPF refusal on Linux 5.4 (push) Waiting to run
Details
Fingerprint Licensing / netprobe-fingerprint-licenses (push) Failing after 1m50s
Details
lint / lint (push) Successful in 1m58s
Details
Rust Tests / test-rust (rust/rdp-adapter, cargo) (push) Successful in 1m59s
Details
Golang Tests / test-go (push) Successful in 2m32s
Details
Secret Scan / gitleaks (pull_request) Successful in 40s
Details
Fingerprint Licensing / netprobe-fingerprint-licenses (pull_request) Failing after 1m4s
Details
Rust Add-on Interop Test / interop (push) Successful in 2m59s
Details
lint / lint (pull_request) Successful in 2m11s
Details
Rust Tests / test-rust (rust/trapd, cargo) (push) Successful in 2m17s
Details
Rust Tests / test-rust (//rust/netprobe:netprobe_test, rust/netprobe, bazel-test) (push) Successful in 3m12s
Details
Rust Tests / test-rust (//rust/netprobe:netprobe, //build/platforms:linux_x86_64_musl, rust/netprobe, bazel-static) (push) Successful in 3m15s
Details
Rust Tests / test-rust (//rust/netprobe:netprobe, //build/platforms:linux_aarch64_musl, rust/netprobe, bazel-static) (push) Successful in 3m23s
Details
Rust Tests / test-rust (rust/rperf-client, cargo) (push) Successful in 2m36s
Details
Rust Tests / test-rust (//rust/rperf-server:rperf, rust/rperf-server, bazel) (push) Successful in 3m24s
Details
Rust Tests / test-rust (rust/consumers/zen, cargo) (push) Successful in 3m30s
Details
Rust Tests / test-rust (rust/log-collector, cargo) (push) Successful in 3m41s
Details
Rust Tests / test-rust (rust/rdp-connector-probe, cargo) (push) Successful in 3m54s
Details
Rust Tests / test-rust (rust/srql, cargo) (push) Successful in 5m21s
Details
Elixir Quality / Elixir Quality (pull_request) Failing after 13m29s
Details
CI / build (pull_request) Failing after 16m33s
Details
b55b2eb145
Retry native add-on delivery after transient failures
Some checks failed
Secret Scan / gitleaks (pull_request) Successful in 48s
Details
lint / lint (push) Successful in 1m25s
Details
lint / lint (pull_request) Successful in 1m27s
Details
Golang Tests / test-go (push) Failing after 1m34s
Details
Fingerprint Licensing / netprobe-fingerprint-licenses (pull_request) Failing after 1m57s
Details
CI / build (pull_request) Failing after 3m11s
Details
Elixir Quality / Elixir Quality (pull_request) Failing after 10m34s
Details
a23f7acabf
mfreeman451 reviewed 2026-06-05 05:29:10 +00:00
mfreeman451 left a comment
Copy link

lgtm

lgtm
mfreeman451 deleted branch fix/native-addon-datasvc-download 2026-06-05 05:29:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
1week

   
2weeks

   
Failed compliance check

   
IP cameras

   
NATS
NATS JetStream

  
Possible security concern

   
Review effort 1/5

   
Review effort 2/5

   
Review effort 3/5

   
Review effort 4/5

   
Review effort 5/5

   
UI

   
aardvark

   
accessibility

   
amd64

   
api

   
arm64

   
auth

   
back-end

   
bgp

   
blog

   
bug
Something isn't working

  
build

   
checkers

   
ci-cd
continuous integration-continuous deployments

  
cleanup

   
cnpg
cloud-native postgres

  
codex

   
core
core service

  
dependencies
Pull requests that update a dependency file

  
device-management

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
dusk

   
ebpf

   
enhancement
New feature or request

  
eta 1d

   
eta 1hr

   
eta 3d

   
eta 3hr

   
feature

   
fieldsurvey

   
github_actions
Pull requests that update GitHub Actions code

  
go
Pull requests that update Go code

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
javascript
Pull requests that update Javascript code

  
k8s

   
log-collector

   
mapper

   
mtr
multi traceroute

  
needs-triage

   
netflow

   
network-sweep

   
observability

   
oracle
Oracle Linux related issues

  
otel
opentelemetry logs, traces, metrics

  
plug-in

   
proton
timeplus proton streaming database

  
python

   
question
Further information is requested

  
reddit

   
redhat

   
research

   
rperf

   
rperf-checker

   
rust
Pull requests that update rust code

  
sdk

   
security

   
serviceradar-agent

   
serviceradar-agent-gateway

   
serviceradar-web

   
serviceradar-web-ng

   
siem

   
snmp

   
sysmon

   
topology

   
ubiquiti

   
wasm

   
wontfix
This will not be worked on

  
zen-engine
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
carverauto/serviceradar!3537
No description provided.