fix(build): point rdp-adapter at the resolved serde_json crate target (#3425) #3485

Merged

mfreeman451 merged 1 commit from fix/rdp-adapter-serde-json-crate-ref into staging

2026-06-01 03:36:15 +00:00

mfreeman451 commented

2026-06-01 03:28:33 +00:00

Owner

Summary

Hotfix for a broken bazel build on staging. The Rust add-on SDK commit (bb01022b9, #3425) bumped the main Cargo.lock serde_json to 1.0.150, but rust/rdp-adapter/BUILD.bazel still pinned the now-nonexistent versioned target @rust_crates//:serde_json-1.0.149, so analysis fails:

ERROR: external/rules_rust++crate+rust_crates/BUILD.bazel: no such target
'@@rules_rust++crate+rust_crates//:serde_json-1.0.149' (did you mean serde_json-1.0.150?)

(Invocation 093d87f5-d7da-4765-bca0-fef38601f89f.)

Fix

Bump the two serde_json pins in rdp-adapter/BUILD.bazel from 1.0.149 → 1.0.150 to match the lock.

Why a versioned pin (not the versionless alias)

serde/zeroize beside it use the versionless @rust_crates//:<crate> alias, but serde_json is pinned to a versioned target on purpose: the main crate repo carries two serde_json versions (0.8.6 transitively + the 1.x line), so crate_universe emits no unambiguous versionless @rust_crates//:serde_json alias. The pin just went stale on the patch bump.

Validation

bazel query "deps(//rust/rdp-adapter:rdp_adapter_lib)" now resolves the dep to @rust_crates//:serde_json-1.0.150 (target exists; no "no such target"). Both rdp_adapter_lib and rdp_adapter_ironrdp_lib deps lists are updated.

Note

This pattern (versioned @rust_crates//:<crate>-<x.y.z> pins) is repo-wide and will re-break on any future serde_json bump until rdp-adapter is migrated to a single serde_json version or the pin is regenerated by the crate tooling — out of scope for this hotfix.

🤖 Generated with Claude Code

## Summary **Hotfix for a broken `bazel build` on staging.** The Rust add-on SDK commit (`bb01022b9`, #3425) bumped the main `Cargo.lock` `serde_json` to `1.0.150`, but `rust/rdp-adapter/BUILD.bazel` still pinned the now-nonexistent versioned target `@rust_crates//:serde_json-1.0.149`, so analysis fails: ``` ERROR: external/rules_rust++crate+rust_crates/BUILD.bazel: no such target '@@rules_rust++crate+rust_crates//:serde_json-1.0.149' (did you mean serde_json-1.0.150?) ``` (Invocation `093d87f5-d7da-4765-bca0-fef38601f89f`.) ## Fix Bump the two `serde_json` pins in `rdp-adapter/BUILD.bazel` from `1.0.149` → `1.0.150` to match the lock. ## Why a versioned pin (not the versionless alias) `serde`/`zeroize` beside it use the versionless `@rust_crates//:<crate>` alias, but `serde_json` is pinned to a versioned target on purpose: the main crate repo carries **two** serde_json versions (`0.8.6` transitively + the `1.x` line), so crate_universe emits no unambiguous versionless `@rust_crates//:serde_json` alias. The pin just went stale on the patch bump. ## Validation `bazel query "deps(//rust/rdp-adapter:rdp_adapter_lib)"` now resolves the dep to `@rust_crates//:serde_json-1.0.150` (target exists; no "no such target"). Both `rdp_adapter_lib` and `rdp_adapter_ironrdp_lib` deps lists are updated. ## Note This pattern (versioned `@rust_crates//:<crate>-<x.y.z>` pins) is repo-wide and will re-break on any future serde_json bump until rdp-adapter is migrated to a single serde_json version or the pin is regenerated by the crate tooling — out of scope for this hotfix. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns