test(core): confirm AgentConfigGenerator compiles the netprobe systemd-service assignment (#3425) #3484

Merged

mfreeman451 merged 1 commit from feat/netprobe-config-generator-test into staging

2026-06-01 03:15:56 +00:00

mfreeman451 commented

2026-06-01 03:11:42 +00:00

Owner

Summary

migrate-netprobe-to-native-addon §3.2 — confirm AgentConfigGenerator compiles the netprobe systemd-service assignment. The generic add-on compilation path already handles netprobe, so this is a confirm-via-test (no production code change) that locks the control-plane → agent contract the §2.2 cutover (#3483) depends on.

What the test asserts (DB-backed, `agent_config_generator_test.exs`)

A netprobe AddonPackage (addon_id: "netprobe", delivery: :pushed_artifact, supervision: :systemd_service, requires.os_capabilities: [cap_net_raw, cap_bpf, cap_perfmon], per-arch artifacts["linux/amd64"]) + an enabled AddonAssignment for a linux/amd64 agent → generate_config/1:

compiles an addon with addon_id "netprobe", :pushed_artifact/:systemd_service, the approved capability subset, the os_capabilities, and the per-arch artifact reference (object_key/sha256/target_os/target_arch).
Cross-system contract: to_proto_response/1 stringifies :systemd_service → "systemd_service" — the exact constant the agent's classifyAddonSupervision matches to route netprobe onto the attach path. A hyphen/format drift here would silently break the cutover, so it's pinned.
the VisibilityConfig rides in the same response — the agent §2.2 cutover reads both: the assignment to decide attach, VisibilityConfig for the capture params.

create_approved_addon_package gained supervision/addon_id/binary/requires opts (backward-compatible defaults; the existing addon tests are unchanged and still pass).

Validation

Full agent_config_generator_test.exs 38/38 green against an srql-fixtures scratch CNPG DB (--include integration).
mix format --check-formatted + mix credo --strict clean.

Where this sits

The build → sign → publish → import → assign → compile-config → agent-attach/configure loop is now covered in code + tests on both sides (control plane emits the netprobe assignment; the agent consumes it). The remaining migrate-netprobe items are §3.1 (seed/import a real netprobe AddonPackage — needs the Linux-built+published bundle), §2.3 status, §2.4 rollback, §3.3 Edge Ops UI, and the §4.3 scratch-Linux-agent e2e (the full-flow gate; bundles can't build/run on darwin).

🤖 Generated with Claude Code

## Summary `migrate-netprobe-to-native-addon` §3.2 — **confirm `AgentConfigGenerator` compiles the netprobe systemd-service assignment**. The generic add-on compilation path already handles netprobe, so this is a **confirm-via-test (no production code change)** that locks the control-plane → agent contract the §2.2 cutover (#3483) depends on. ## What the test asserts (DB-backed, `agent_config_generator_test.exs`) A netprobe `AddonPackage` (`addon_id: "netprobe"`, `delivery: :pushed_artifact`, `supervision: :systemd_service`, `requires.os_capabilities: [cap_net_raw, cap_bpf, cap_perfmon]`, per-arch `artifacts["linux/amd64"]`) + an enabled `AddonAssignment` for a `linux/amd64` agent → `generate_config/1`: - compiles an addon with `addon_id "netprobe"`, `:pushed_artifact`/`:systemd_service`, the approved capability subset, the os_capabilities, and the **per-arch artifact reference** (object_key/sha256/target_os/target_arch). - **Cross-system contract:** `to_proto_response/1` stringifies `:systemd_service` → `"systemd_service"` — the exact constant the agent's `classifyAddonSupervision` matches to route netprobe onto the **attach path**. A hyphen/format drift here would silently break the cutover, so it's pinned. - the **`VisibilityConfig` rides in the same response** — the agent §2.2 cutover reads *both*: the assignment to decide attach, `VisibilityConfig` for the capture params. `create_approved_addon_package` gained `supervision`/`addon_id`/`binary`/`requires` opts (backward-compatible defaults; the existing addon tests are unchanged and still pass). ## Validation - Full `agent_config_generator_test.exs` **38/38 green** against an `srql-fixtures` scratch CNPG DB (`--include integration`). - `mix format --check-formatted` + `mix credo --strict` clean. ## Where this sits The build → sign → publish → import → **assign → compile-config** → agent-attach/configure loop is now covered in code + tests on both sides (control plane emits the netprobe assignment; the agent consumes it). The remaining migrate-netprobe items are §3.1 (seed/import a real netprobe `AddonPackage` — needs the Linux-built+published bundle), §2.3 status, §2.4 rollback, §3.3 Edge Ops UI, and the **§4.3 scratch-Linux-agent e2e** (the full-flow gate; bundles can't build/run on darwin). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Rows
Columns

test(core): confirm AgentConfigGenerator compiles the netprobe systemd-service assignment (#3425) #3484

Summary

What the test asserts (DB-backed, agent_config_generator_test.exs)

Validation

Where this sits

What the test asserts (DB-backed, `agent_config_generator_test.exs`)