feat/host-network-visibility-phase-2 #3439
No reviewers
Labels
No labels
1week
2weeks
Failed compliance check
IP cameras
NATS
Possible security concern
Review effort 1/5
Review effort 2/5
Review effort 3/5
Review effort 4/5
Review effort 5/5
UI
aardvark
accessibility
amd64
api
arm64
auth
back-end
bgp
blog
bug
build
checkers
ci-cd
cleanup
cnpg
codex
core
dependencies
device-management
documentation
duplicate
dusk
ebpf
enhancement
eta 1d
eta 1hr
eta 3d
eta 3hr
feature
fieldsurvey
github_actions
go
good first issue
help wanted
invalid
javascript
k8s
log-collector
mapper
mtr
needs-triage
netflow
network-sweep
observability
oracle
otel
plug-in
proton
python
question
reddit
redhat
research
rperf
rperf-checker
rust
sdk
security
serviceradar-agent
serviceradar-agent-gateway
serviceradar-web
serviceradar-web-ng
siem
snmp
sysmon
topology
ubiquiti
wasm
wontfix
zen-engine
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
carverauto/serviceradar!3439
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/host-network-visibility-phase-2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
IMPORTANT: Please sign the Developer Certificate of Origin
Thank you for your contribution to ServiceRadar. Please note, when contributing, the developer must include
a DCO sign-off statement indicating the DCO acceptance in one commit message. Here
is an example DCO Signed-off-by line in a commit message:
Describe your changes
Issue ticket number and link
Code checklist before requesting a review
Pass 15 flagged proto/flow/flow.proto:132 declared string cmdline = 3 with no redaction prefix, no length cap, and no comment — contradicting spec §18.11 ("redacted cmdline") and the established redacted_cmdline convention shipped in rust/netprobe/src/attribution.rs:374-393 and proto/agent/netprobe/v1/netprobe.proto:281. Field number 3 is preserved (wire-compatible rename). Producers must strip secrets following the netprobe argv[0] + "[redacted N arg(s)]" placeholder discipline and cap at 256 bytes before publishing. No producer publishes attributed flows today, so no live data exists to migrate; the rename removes the legal/privacy blast radius before §21.2 producer wiring lands. Go binding regenerated via the Makefile generate-proto recipe. Elixir binding (flow.pb.ex) updated by hand because protoc-gen-elixir is not installed locally and the Makefile has no Elixir regen target; follow-up to add one is tracked in the Pass 15 punch list. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>flow_attribution_join_integration_test.exs covers acceptance bullets (1)-(4) of the §21.3 Option A design, with explicit B-4 boundary assertions in both directions: (1) Flow-then-attribution: incoming host-slice FlowMessage cached awaiting attribution; matching FlowAttributionEvent arrives; joiner constructs AttributedFlowMessage; verifies publish to flow.attributed.<core_partition_id>. (2) Attribution-then-flow: inverse order; same merged output. (3) TTL eviction: orphan flows expire after 60s without an attribution arm; orphan attributions same. (4) B-4 partition boundary (a): attacker-controlled batch envelope has no partition field — security by construction. (4) B-4 partition boundary (b): poisoned host-slice FlowMessage with a different partition is OVERRIDDEN at merge time; published subject + payload both carry core's self_partition_id. tasks.md §21.3 rewritten to record Option A closure + the gating note on host_slice_subscriber_enabled (production enablement is a separate verification step). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>lgtm
context out of thin air? why cant we pass one in
@ -156,0 +148,4 @@- [x] 16.1 Add `pktparse-rs` (or equivalent) to `Cargo.toml`; refresh crate-universe.- [x] 16.2 Implement the dissector pipeline assembler (parser feeds dissectors that subscribe to L7 prefixes).- [x] 16.3 Implement dissectors for HTTP/1.x, HTTP/2 cleartext, TLS SNI, DNS, SSH, FTP, QUIC version negotiation, MQTT, BitTorrent.- [x] 16.4 Apply privacy redaction at each dissector boundary (no URIs, no DNS names by default, no payload).do we really want/need this? wouldn't it be more helpful to include some of this stuff for troubleshooting/attribution of netflow-to-application?
mfreeman451 referenced this pull request2026-05-29 17:19:49 +00:00