pkg/sweeper/memory_store.go #34

New issue

Closed

opened 2026-03-28 04:20:38 +00:00 by mfreeman451 · 0 comments

mfreeman451 commented

2026-03-28 04:20:38 +00:00

Owner

Imported from GitHub.

Original GitHub issue: #71
Original author: @mfreeman451
Original URL: https://github.com/carverauto/serviceradar/issues/71
Original created: 2025-01-20T03:39:21Z

InMemoryStore methods could return errors instead of just logging them.
SaveHostResult() could be made more efficient by using a map instead of a slice.
GetHostResults() could be made more efficient by using a map instead of a slice.
GetSweepSummary() could be made more efficient by using a map instead of a slice.
The logic in matchesFilter(), checkTimeRange(), checkHost(), checkPort(), and checkAvailability() could be simplified.
The InMemoryStore type implements the Store interface, but the methods SaveHostResult(), GetHostResults(), and GetSweepSummary() are not defined in the Store interface.

Imported from GitHub. Original GitHub issue: #71 Original author: @mfreeman451 Original URL: https://github.com/carverauto/serviceradar/issues/71 Original created: 2025-01-20T03:39:21Z --- - [ ] InMemoryStore methods could return errors instead of just logging them. - [ ] SaveHostResult() could be made more efficient by using a map instead of a slice. - [ ] GetHostResults() could be made more efficient by using a map instead of a slice. - [ ] GetSweepSummary() could be made more efficient by using a map instead of a slice. - [ ] The logic in matchesFilter(), checkTimeRange(), checkHost(), checkPort(), and checkAvailability() could be simplified. - [ ] The InMemoryStore type implements the Store interface, but the methods SaveHostResult(), GetHostResults(), and GetSweepSummary() are not defined in the Store interface.

Rows
Columns